You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/03/27 23:02:00 UTC

[jira] [Commented] (IMPALA-11857) Join build fragments not displaying correctly in graphical plan

    [ https://issues.apache.org/jira/browse/IMPALA-11857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705717#comment-17705717 ] 

ASF subversion and git services commented on IMPALA-11857:
----------------------------------------------------------

Commit 588719d321bda8bc54f50fcbf0234986a0e28c4f in impala's branch refs/heads/branch-4.1.2 from Kurt Deschler
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=588719d32 ]

IMPALA-11857: Connect join build fragment to join in graphical plan

When support was added for join build sink, the plan JSON and plan
rendering logic were not updated to handle the new sink type. As a
result, the linkage from the join build fragment to its corresponding
join node were not expressed in the JSON and build fragments nodes were
rendered as orphaned.

This change adds a new JSON join_build_target field to join build
fragments and connects the build fragment to the join with a green dashed
line similar to the red dashed line used for data sender fragments.

Also changed the SVG fill type to 'none' for exchange edges to avoid
rendering a black triangle if the right child was an exchange as in the
join build case.

Testing:
- Manual testing with TPCH queries and reviewing rendered plan diagrams

Change-Id: I80af977e5c5e869268d3ee68fafe541adadc239d
Reviewed-on: http://gerrit.cloudera.org:8080/19437
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Join build fragments not displaying correctly in graphical plan
> ---------------------------------------------------------------
>
>                 Key: IMPALA-11857
>                 URL: https://issues.apache.org/jira/browse/IMPALA-11857
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>            Reporter: Kurt Deschler
>            Assignee: Kurt Deschler
>            Priority: Minor
>             Fix For: Impala 4.3.0
>
>
> Repro:
> Run a query with mt_dop enabled and look at the plan output in the web server. Join build fragments are not connected properly to the DAG.
> use tpch_parquet;
> set mt_dop = 10;
> select count(*) from part join partsupp on ps_partkey=p_partkey and ps_suppkey=10;



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org