You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by KaiXinXiaoLei <gi...@git.apache.org> on 2014/12/02 04:57:20 UTC
[GitHub] spark pull request: Add spark version to package
GitHub user KaiXinXiaoLei opened a pull request:
https://github.com/apache/spark/pull/3546
Add spark version to package
When building spark, add a file about version and build-time of project to package.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/KaiXinXiaoLei/spark add-spark-version
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/3546.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3546
----
commit c2fec72832a1fbdce9b6935f4e7bd1778dc5418f
Author: KaiXinXiaoLei <hu...@huawei.com>
Date: 2014-12-02T03:02:12Z
change pom.xml
Add version and time to package.
commit cf3f37966e311cfbc632b44dba3737c5f9406d39
Author: KaiXinXiaoLei <hu...@huawei.com>
Date: 2014-12-02T03:08:42Z
Add version.properties file
This file shows the version and build-time of project.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Add project-build-information to package
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3546#issuecomment-65180408
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Add project-build-information to package
Posted by KaiXinXiaoLei <gi...@git.apache.org>.
Github user KaiXinXiaoLei commented on the pull request:
https://github.com/apache/spark/pull/3546#issuecomment-65336649
I think this file can show information clearly, and not need to META-INF. In addition, we can add some information, For example, the md5sum of package, using it to check the package.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Add project-build-information to package
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3546#issuecomment-65189442
This is already available programmatically, or in META-INF, no? what is the use case for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Add project-build-information to package
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3546#issuecomment-65391880
On the other hand it is yet another duplicated source of this info to be maintained and not standard. Why can the existing sources of version not be used? I dont see the point about MD5 here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org