You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/02/20 06:46:41 UTC

[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on a change in pull request #232: [YUNIKORN-521] Placeholder pods are not cleaned when the job is deleted

yangwwei commented on a change in pull request #232:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/232#discussion_r579607351



##########
File path: pkg/appmgmt/general/general.go
##########
@@ -130,6 +130,7 @@ func (os *Manager) getAppMetadata(pod *v1.Pod) (interfaces.ApplicationMetadata,
 		User:          user,
 		Tags:          tags,
 		TaskGroups:    taskGroups,
+		PlaceholderOwnerReferences: pod.OwnerReferences,

Review comment:
       I think we can just call this owner reference since this is a general K8s concept.
   It doesn't mean only placeholder pod has that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org