You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2015/11/11 03:18:51 UTC

[Bug 7263] New: Mail::SpamAssassin module is missing the copyright

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7263

            Bug ID: 7263
           Summary: Mail::SpamAssassin module is missing the copyright
           Product: Spamassassin
           Version: 3.4.1
          Hardware: PC
                OS: Windows 7
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Building & Packaging
          Assignee: dev@spamassassin.apache.org
          Reporter: quanah@zimbra.com

While there is a Copyright section in the POD documentation for
Mail::SpamAssassin, it lists no copyright at all.  Instead, it refers to the
license, which isn't quite the same thing.

I'd expect something like:

Copyright 2001-2015 the Apache Foundation

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7263] Mail::SpamAssassin module is missing the copyright

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7263

--- Comment #6 from Quanah Gibson-Mount <qu...@zimbra.com> ---
SA joined the ASF in 2004:

https://en.wikipedia.org/wiki/SpamAssassin#History

We can see the move to do the work in 2003:

http://sourceforge.net/p/spamassassin/mailman/message/16868996/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7263] Mail::SpamAssassin module is missing the copyright

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7263

--- Comment #7 from Quanah Gibson-Mount <qu...@zimbra.com> ---
>From backpan, we can see that SA 3.0.1, released in 22 Oct 2004, was definitely
part of the ASF:

http://backpan.perl.org/authors/id/J/JM/JMASON/Mail-SpamAssassin-3.0.1.readme

So it was definitely part of ASF for that release.

The release just prior to that (2.64) from 04 Aug 2004, was at the old
spamassassin.sourceforge.net website, and does not reference ASF.

So 2004 is the correct starting year for SA as part of ASF. :)

--Quanah

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7263] Mail::SpamAssassin module is missing the copyright

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7263

--- Comment #8 from Quanah Gibson-Mount <qu...@zimbra.com> ---
2.64 readme, for reference:

http://backpan.perl.org/authors/id/J/JM/JMASON/Mail-SpamAssassin-2.64.readme

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7263] Mail::SpamAssassin module is missing the copyright

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7263

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Kevin A. McGrail <km...@pccc.com> ---
For now, I just used the current copyright year and updated the build doc to
review the Credits for accurate Copyright.

3.4:
Sending        CREDITS
Sending        build/README
Sending        sa-compile.raw
Sending        sa-update.raw
Sending        spamassassin.raw
Transmitting file data .....
Committed revision 1714589.

trunk:
Trunk is same for 1714591 + a spamdcheck under revision 1714592.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7263] Mail::SpamAssassin module is missing the copyright

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7263

Sidney Markowitz <si...@sidney.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sidney@sidney.com

--- Comment #10 from Sidney Markowitz <si...@sidney.com> ---
Committed to 3.4, revision 1791428 sa-check_spamd.raw port of revision 1714592
which was also part of this issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7263] Mail::SpamAssassin module is missing the copyright

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7263

--- Comment #5 from Kevin A. McGrail <km...@pccc.com> ---
I figure to start with the information I can defend.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7263] Mail::SpamAssassin module is missing the copyright

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7263

--- Comment #3 from Kevin A. McGrail <km...@pccc.com> ---
The project was brought into the ASF and my thought is baby steps because I
know what is correct now.  Figuring out the other information adds no value and
could be a large rabbithole.  But if someone knows the correct, factual
information, my thought is to add it.  Absent that information, this is a
triage step for a good point.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7263] Mail::SpamAssassin module is missing the copyright

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7263

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kmcgrail@pccc.com

--- Comment #1 from Kevin A. McGrail <km...@pccc.com> ---
A good thing to polish since.

I think these are the applicable instructions from the license to apply to the
code and the first line with the copyright is missing.

Copyright [yyyy] [name of copyright owner]

   Licensed under the Apache License, Version 2.0 (the "License");
   you may not use this file except in compliance with the License.
   You may obtain a copy of the License at

       http://www.apache.org/licenses/LICENSE-2.0

   Unless required by applicable law or agreed to in writing, software
   distributed under the License is distributed on an "AS IS" BASIS,
   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   See the License for the specific language governing permissions and
   limitations under the License.


Suggest we add use the Copyright (C) 2015 The Apache Software Foundation to any
file with @LICENSE.

And the release process should be updated to make sure the copyright is
updated.

Thoughts?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7263] Mail::SpamAssassin module is missing the copyright

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7263

Sidney Markowitz <si...@sidney.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|Undefined                   |3.4.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7263] Mail::SpamAssassin module is missing the copyright

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7263

--- Comment #4 from Quanah Gibson-Mount <qu...@zimbra.com> ---
Ok.  Well, we know it's been in the ASF I assume since at least X date, so
could start that copyright then? like 2010-2015 ASF etc?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7263] Mail::SpamAssassin module is missing the copyright

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7263

Quanah Gibson-Mount <qu...@zimbra.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |quanah@zimbra.com

--- Comment #2 from Quanah Gibson-Mount <qu...@zimbra.com> ---
Copyright usually starts from the starting point of the package.  I noted 2001
specifically, as that was the oldest year I could find a SpamAssassin release
for.  I assume it has been a part of the apache foundation that entire time. 
If not, there may need to be more than one copyright listed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7263] Mail::SpamAssassin module is missing the copyright

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7263

--- Comment #11 from Sidney Markowitz <si...@sidney.com> ---
Committed revision 1791430
The change to spamassassin.raw was committed to 3.4 branch but had never been
committed to trunk.

-- 
You are receiving this mail because:
You are the assignee for the bug.