You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/15 04:51:35 UTC
[GitHub] [spark] huaxingao commented on a change in pull request #35520: [SPARK-37867][SQL][FOLLOWUP] Compile aggregate functions for build-in DB2 dialect
huaxingao commented on a change in pull request #35520:
URL: https://github.com/apache/spark/pull/35520#discussion_r806444721
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/DB2Dialect.scala
##########
@@ -37,6 +37,26 @@ private object DB2Dialect extends JdbcDialect {
assert(f.inputs().length == 1)
val distinct = if (f.isDistinct) "DISTINCT " else ""
Some(s"VARIANCE($distinct${f.inputs().head})")
+ case f: GeneralAggregateFunc if f.name() == "VAR_SAMP" =>
+ assert(f.inputs().length == 1)
+ val distinct = if (f.isDistinct) "DISTINCT " else ""
+ Some(s"VARIANCE_SAMP($distinct${f.inputs().head})")
+ case f: GeneralAggregateFunc if f.name() == "STDDEV_POP" =>
+ assert(f.inputs().length == 1)
+ val distinct = if (f.isDistinct) "DISTINCT " else ""
+ Some(s"STDDEV($distinct${f.inputs().head})")
+ case f: GeneralAggregateFunc if f.name() == "STDDEV_SAMP" =>
+ assert(f.inputs().length == 1)
+ val distinct = if (f.isDistinct) "DISTINCT " else ""
+ Some(s"STDDEV_SAMP($distinct${f.inputs().head})")
+ case f: GeneralAggregateFunc if f.name() == "COVAR_POP" =>
+ assert(f.inputs().length == 2)
+ val distinct = if (f.isDistinct) "DISTINCT " else ""
+ Some(s"COVARIANCE($distinct${f.inputs().head}, ${f.inputs().last})")
Review comment:
<img width="397" alt="Screen Shot 2022-02-14 at 8 47 54 PM" src="https://user-images.githubusercontent.com/13592258/153994415-9778115a-dbf6-403c-8a81-487d551301f2.png">
`DISTINCT` is not supported in `covariance`
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/DB2Dialect.scala
##########
@@ -37,6 +37,26 @@ private object DB2Dialect extends JdbcDialect {
assert(f.inputs().length == 1)
val distinct = if (f.isDistinct) "DISTINCT " else ""
Some(s"VARIANCE($distinct${f.inputs().head})")
+ case f: GeneralAggregateFunc if f.name() == "VAR_SAMP" =>
+ assert(f.inputs().length == 1)
+ val distinct = if (f.isDistinct) "DISTINCT " else ""
+ Some(s"VARIANCE_SAMP($distinct${f.inputs().head})")
+ case f: GeneralAggregateFunc if f.name() == "STDDEV_POP" =>
+ assert(f.inputs().length == 1)
+ val distinct = if (f.isDistinct) "DISTINCT " else ""
+ Some(s"STDDEV($distinct${f.inputs().head})")
+ case f: GeneralAggregateFunc if f.name() == "STDDEV_SAMP" =>
+ assert(f.inputs().length == 1)
+ val distinct = if (f.isDistinct) "DISTINCT " else ""
+ Some(s"STDDEV_SAMP($distinct${f.inputs().head})")
+ case f: GeneralAggregateFunc if f.name() == "COVAR_POP" =>
+ assert(f.inputs().length == 2)
+ val distinct = if (f.isDistinct) "DISTINCT " else ""
+ Some(s"COVARIANCE($distinct${f.inputs().head}, ${f.inputs().last})")
+ case f: GeneralAggregateFunc if f.name() == "COVAR_SAMP" =>
+ assert(f.inputs().length == 2)
+ val distinct = if (f.isDistinct) "DISTINCT " else ""
+ Some(s"COVARIANCE_SAMP($distinct${f.inputs().head}, ${f.inputs().last})")
Review comment:
<img width="423" alt="Screen Shot 2022-02-14 at 8 49 39 PM" src="https://user-images.githubusercontent.com/13592258/153994615-f3985ccb-4ce4-4a65-8454-a34923f46c9a.png">
`DISTINCT` is not supported in `covariance_SAMP`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org