You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/27 20:38:27 UTC
[GitHub] [airflow] auyer opened a new pull request, #23307: Adds resultBackendSecretName warning in Helm production docs
auyer opened a new pull request, #23307:
URL: https://github.com/apache/airflow/pull/23307
Adds resultBackendSecretName warning in Helm production docs.
`resultBackendSecretName` expects a url that starts with `db+postgresql://`, while `metadataSecretName` expects `postgresql://` or `postgres://` and wont work with `db+postgresql://`. To solve this, it might be necessary to create multiple secrets.
closes: #23306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #23307: Adds resultBackendSecretName warning in Helm production docs
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #23307:
URL: https://github.com/apache/airflow/pull/23307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #23307: Adds resultBackendSecretName warning in Helm production docs
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #23307:
URL: https://github.com/apache/airflow/pull/23307#issuecomment-1117954145
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] auyer commented on a diff in pull request #23307: Adds resultBackendSecretName warning in Helm production docs
Posted by GitBox <gi...@apache.org>.
auyer commented on code in PR #23307:
URL: https://github.com/apache/airflow/pull/23307#discussion_r863288305
##########
docs/helm-chart/production-guide.rst:
##########
@@ -52,6 +52,9 @@ configure the secret name:
.. _production-guide:pgbouncer:
+.. warning::
+ If you use `CeleryExecutor`, keep in mind that `resultBackendSecretName` expects a url that starts with `db+postgresql://`, while `metadataSecretName` expects `postgresql://` and wont work with `db+postgresql://`. You'll need to create separate secrets with the correct schema.
Review Comment:
Should `CeleryKubernetesExecutor` be added as well ?
I notice the docs usually mention only one of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23307: Adds resultBackendSecretName warning in Helm production docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23307:
URL: https://github.com/apache/airflow/pull/23307#issuecomment-1115504664
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #23307: Adds resultBackendSecretName warning in Helm production docs
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #23307:
URL: https://github.com/apache/airflow/pull/23307#issuecomment-1111460026
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #23307: Adds resultBackendSecretName warning in Helm production docs
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #23307:
URL: https://github.com/apache/airflow/pull/23307#discussion_r863285713
##########
docs/helm-chart/production-guide.rst:
##########
@@ -52,6 +52,9 @@ configure the secret name:
.. _production-guide:pgbouncer:
+.. warning::
+ If you use `CeleryExecutor`, keep in mind that `resultBackendSecretName` expects a url that starts with `db+postgresql://`, while `metadataSecretName` expects `postgresql://` and wont work with `db+postgresql://`. You'll need to create separate secrets with the correct schema.
Review Comment:
```suggestion
If you use `CeleryExecutor`, keep in mind that `resultBackendSecretName` expects a url that starts with `db+postgresql://`, while `metadataSecretName` expects `postgresql://` and wont work with `db+postgresql://`. You'll need to create separate secrets with the correct scheme.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #23307: Adds resultBackendSecretName warning in Helm production docs
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #23307:
URL: https://github.com/apache/airflow/pull/23307#discussion_r863255675
##########
docs/helm-chart/production-guide.rst:
##########
@@ -49,9 +49,13 @@ configure the secret name:
data:
metadataSecretName: mydatabase
+ resultBackendSecretName: mydatabase
Review Comment:
```suggestion
```
Let's leave this executor agnostic.
##########
docs/helm-chart/production-guide.rst:
##########
@@ -49,9 +49,13 @@ configure the secret name:
data:
metadataSecretName: mydatabase
+ resultBackendSecretName: mydatabase
.. _production-guide:pgbouncer:
+.. warning::
+ `resultBackendSecretName` expects a url that starts with `db+postgresql://`, while `metadataSecretName` expects `postgresql://` or `postgres://` and wont work with `db+postgresql://`. To solve this, it might be necessary to create multiple secrets.
Review Comment:
```suggestion
If you use `CeleryExecutor`, keep in mind that `resultBackendSecretName` expects a url that starts with `db+postgresql://`, while `metadataSecretName` expects `postgresql://` and wont work with `db+postgresql://`. You'll need to create separate secrets with the correct schema.
```
Starting in 2.3.0, only `postgresql` works, so lets just keep that one. Otherwise, I think this sounds a little better, but feel free to adjust it more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #23307: Adds resultBackendSecretName warning in Helm production docs
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #23307:
URL: https://github.com/apache/airflow/pull/23307#discussion_r864132429
##########
docs/helm-chart/production-guide.rst:
##########
@@ -52,6 +52,9 @@ configure the secret name:
.. _production-guide:pgbouncer:
+.. warning::
+ If you use `CeleryExecutor`, keep in mind that `resultBackendSecretName` expects a url that starts with `db+postgresql://`, while `metadataSecretName` expects `postgresql://` and wont work with `db+postgresql://`. You'll need to create separate secrets with the correct scheme.
Review Comment:
```suggestion
If you use ``CeleryExecutor``, keep in mind that ``resultBackendSecretName`` expects a url that starts with ``db+postgresql://``, while ``metadataSecretName`` expects ``postgresql://`` and won't work with `db+postgresql://`. You'll need to create separate secrets with the correct scheme.
```
##########
docs/helm-chart/production-guide.rst:
##########
@@ -52,6 +52,9 @@ configure the secret name:
.. _production-guide:pgbouncer:
+.. warning::
+ If you use `CeleryExecutor`, keep in mind that `resultBackendSecretName` expects a url that starts with `db+postgresql://`, while `metadataSecretName` expects `postgresql://` and wont work with `db+postgresql://`. You'll need to create separate secrets with the correct scheme.
Review Comment:
```suggestion
If you use ``CeleryExecutor``, keep in mind that ``resultBackendSecretName`` expects a url that starts with ``db+postgresql://``, while ``metadataSecretName`` expects ``postgresql://`` and won't work with ``db+postgresql://``. You'll need to create separate secrets with the correct scheme.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #23307: Adds resultBackendSecretName warning in Helm production docs
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #23307:
URL: https://github.com/apache/airflow/pull/23307#discussion_r863294330
##########
docs/helm-chart/production-guide.rst:
##########
@@ -52,6 +52,9 @@ configure the secret name:
.. _production-guide:pgbouncer:
+.. warning::
+ If you use `CeleryExecutor`, keep in mind that `resultBackendSecretName` expects a url that starts with `db+postgresql://`, while `metadataSecretName` expects `postgresql://` and wont work with `db+postgresql://`. You'll need to create separate secrets with the correct schema.
Review Comment:
We normally just reference CeleryExecutor explicitly, as CeleryKubernetesExecutor actually runs a CeleryExecutor under the hood. Said another way, it's inferred (at least to me).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org