[GitHub] [echarts] DominiqueDeCordova commented on pull request #16217: the exceptiom prevents cicd running

[GitBox <gi...@apache.org>]

DominiqueDeCordova commented on pull request #16217:
URL: https://github.com/apache/echarts/pull/16217#issuecomment-993377324


   Thank you for the comment.
   
   As far as I see, the code throws an exception in DEV mode, but does not throw an exception in Production. That allows us to deploy to Production, but prevents using CICD.
   
   My request is to make the code uniform: if in one environment the code does not throw an exception, it should not do it in another.
   I would appreciate your consideration,
   Dmitriy
   
   From: Wenli Zhang ***@***.***>
   Sent: Monday, December 13, 2021 7:17 PM
   To: apache/echarts ***@***.***>
   Cc: Shornikov, DmitriyX ***@***.***>; Author ***@***.***>
   Subject: Re: [apache/echarts] the exceptiom prevents cicd running (PR #16217)
   
   
   @Ovilia commented on this pull request.
   
   Hi, this code should probably not be removed. If you meet with errors throw by it, you should probably check your option to make sure corresponding mistakes are taken care of.
   
   —
   You are receiving this because you authored the thread.
   Reply to this email directly, view it on GitHub<https://github.com/apache/echarts/pull/16217#pullrequestreview-830974708>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AVR44HV6TC7EB7BMEVNCPEDUQ2ZKFANCNFSM5J6YDATQ>.
   Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org