You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/16 13:51:38 UTC
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7318: sched/env: Skip the envirnment variable duplication of kernel thread
pkarashchenko commented on code in PR #7318:
URL: https://github.com/apache/incubator-nuttx/pull/7318#discussion_r996445093
##########
sched/init/nx_bringup.c:
##########
@@ -224,19 +224,34 @@ static inline void nx_workqueues(void)
static inline void nx_start_application(void)
{
-#ifdef CONFIG_INIT_ARGS
+#ifndef CONFIG_INIT_NONE
FAR char *const argv[] =
Review Comment:
```suggestion
FAR char * const argv[] =
```
##########
sched/init/nx_bringup.c:
##########
@@ -224,19 +224,34 @@ static inline void nx_workqueues(void)
static inline void nx_start_application(void)
{
-#ifdef CONFIG_INIT_ARGS
+#ifndef CONFIG_INIT_NONE
FAR char *const argv[] =
{
+# ifdef CONFIG_INIT_ARGS
CONFIG_INIT_ARGS,
+# endif
+ NULL,
+ };
+
+ FAR char *const envp[] =
Review Comment:
```suggestion
FAR char * const envp[] =
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org