You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/11 12:32:15 UTC

[GitHub] [flink] godfreyhe commented on a change in pull request #12577: [FLINK-17599][docs] Update documents due to FLIP-84

godfreyhe commented on a change in pull request #12577:
URL: https://github.com/apache/flink/pull/12577#discussion_r438747612



##########
File path: flink-end-to-end-tests/flink-batch-sql-test/src/main/java/org/apache/flink/sql/tests/BatchSQLTestProgram.java
##########
@@ -48,7 +48,7 @@
  *
  * <p>Parameters:
  * -outputPath output file path for CsvTableSink;
- * -sqlStatement SQL statement that will be executed as sqlUpdate
+ * -sqlStatement SQL statement that will be executed as executeSql

Review comment:
       Yes, I had replace all except `sqlUpdate` method in sql-client and `sqlUpdate` method in old planner.
   
   Regarding (1), we can't replace `sqlUpdate` with `executeSql ` now, because we need to do more refactor work about this. (such as: submit job logic)
   
   Regarding (2), them are in old planner




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org