You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/05/25 17:30:26 UTC

[GitHub] [spark] LuciferYang commented on pull request #41313: [SPARK-43795][CONNECT] Remove parameters not used for SparkConnectPlanner

LuciferYang commented on PR #41313:
URL: https://github.com/apache/spark/pull/41313#issuecomment-1563265319

   https://github.com/apache/spark/blob/3a6d2153b93c759b68e5827905d1867ba93ec9cf/connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala#L2700C38-L2702
   
   https://github.com/apache/spark/blob/3a6d2153b93c759b68e5827905d1867ba93ec9cf/connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala#L2946-L2948
   
   two similar cases in `SparkConnectPlanner`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org