[GitHub] GabeLoins commented on a change in pull request #5206: [adhoc-filters] Adding adhoc-filters to all viz types

[GitBox <gi...@apache.org>]

GabeLoins commented on a change in pull request #5206: [adhoc-filters] Adding adhoc-filters to all viz types
URL: https://github.com/apache/incubator-superset/pull/5206#discussion_r196165376
 
 

 ##########
 File path: superset/assets/src/components/AlteredSliceTag.jsx
 ##########
 @@ -56,13 +60,15 @@ export default class AlteredSliceTag extends React.Component {
       return 'N/A';
     } else if (value === null) {
       return 'null';
-    } else if (controls[key] && controls[key].type === 'FilterControl') {
+    } else if (controls[key] && controls[key].type === 'AdhocFilterControl') {
 
 Review comment:
   was this line necessary before? Should I have already made this change or was it only necessary once we removed the legacy filters?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org