You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@fineract.apache.org by Isaac Kamga <is...@mifos.org> on 2018/03/01 12:20:54 UTC
Re: Getting started on Fineract CN
Hi Myrle,
Thanks for taking out some time to review and merge the Pull Request.
I have just updated the copyright information and package name on the
fineract-cn-lang repository and sent in another pull request
<https://github.com/apache/fineract-cn-lang/pull/3> for review.
On a related note, I'd like to ask experienced developers on Fineract CN if
it would be necessary to change the project's name ( from *lang* to
*fineract-cn-lang* ) in the settings.gradle
<https://github.com/apache/fineract-cn-lang/blob/develop/settings.gradle>
file.
Also, in the bintray.pkg section of the build.gradle file
<https://github.com/apache/fineract-cn-lang/blob/develop/build.gradle>,
should the `repo` , `userOrg` and `vcsUrl` variables be changed too ? These
will help with subsequent updates to fineract-cn-api,
fineract-cn-cassandra, etc.
At Your Service,
Isaac Kamga
On Tue, Feb 27, 2018 at 8:02 PM, Isaac Kamga <is...@mifos.org> wrote:
> Hi Myrle,
>
> +Awasum
>
> Thanks for all the awesomeness !
>
> @Myrle, While awaiting your review of the PR, I'll be on those tasks.
>
> @Awasum, thanks for the dependency graph, it's definitely very helpful.
>
> At Your Service,
> Isaac Kamga.
>
>
> On Tue, Feb 27, 2018 at 7:55 PM, Awasum Yannick <aw...@apache.org> wrote:
>
>> Hi Isaac,
>>
>> Thanks for volunteering to take up the above tasks.
>>
>> Myrle, thank you for the needed tips and directions.
>>
>> Isaac, While you are at it, you might want to go inorder according to the
>> dependency graph.
>>
>> From what I have seen, here is how the order goes:
>>
>> lang, api, cassandra, mariadb, async, command, test, crypto, anubis,
>> service-starter, identity, permitted-feign-client, accounting, customer,
>> provisioner, rhythm, office, portfolio, deposit-account-management,
>> cheques, teller, payroll, group, reporting.
>>
>> Where the current project (might) depends on the previous ones. So that
>> the
>> builds should not be failing as you move ahead.
>>
>> So you might want to begin with lang.
>>
>>
>>
>> Thanks,
>> Awasum
>>
>>
>>
>> On Tue, Feb 27, 2018 at 7:34 PM, Myrle Krantz <my...@apache.org> wrote:
>>
>> > Hey Isaac,
>> >
>> > On Tue, Feb 27, 2018 at 3:38 PM, Isaac Kamga <is...@mifos.org>
>> > wrote:
>> > >> Other places are:
>> > >> * the package names
>> > >> * a couple of variables in build scripts
>> > >> * the copyright notice headers in the source files.
>> > >>
>> > >
>> > > Can I take on these tasks viz updating other places in the code base
>> such
>> > > as package names, copyright information, etc ?
>> >
>> > Oh please do. Can you start with the copyright notices, since that
>> > task can done be one repository at a time, and doesn't have
>> > cross-repository effects? A couple of tips while you're doing this:
>> > * I suggest doing one repository first, and letting us review it,
>> > before doing the rest of the repositories.
>> > * In projects without sub-modules, all you'll need to do is change the
>> > license section in the build.gradle file. Then run the license task
>> > and it should change all the headers in the project in one step.
>> > * In projects with sub-modules, it's kind of the same except that the
>> > block of code to change is in the shared.gradle file.
>> > * Some projects have "skip existing" set. You'll have to remove that
>> > setting, or the license task won't change anything.
>> >
>> > I'll not do anything else while you're doing that, since you'll have
>> > to touch every file in the repositories, and merges would be required.
>> >
>> > > I have just sent in a Pull Request
>> > > <https://github.com/apache/fineract-cn-demo-server/pull/2> to the
>> > > demo-server repository updating the initial-setup and pull-all scripts
>> > for
>> > > review.
>> >
>> > I will review it tomorrow morning (Berlin timezone). Right now, I'm
>> > too tired to properly check code.
>> >
>> > Best Regards,
>> > Myrle
>> >
>>
>
>
Re: Getting started on Fineract CN
Posted by Myrle Krantz <my...@apache.org>.
On Thu 1. Mar 2018 at 19:37 Isaac Kamga <is...@mifos.org> wrote:
> Hi Myrle,
>
> On Thu, Mar 1, 2018 at 6:34 PM, Myrle Krantz <my...@apache.org> wrote:
>
> > Hey Isaac,
> >
> > At a first glance, it looks good. May I ask though why you removed
> > the license parameter strictCh
> >
> My bad ! Do I update PR with new commit or close this and send in another
> ?
Updating the PR with a new commit is fine.
I’m not going to get to merging it till tomorrow, but if you want to start
on the fixing copyright notices on the rest of the repos I think you know
what you need to do them now.
: o),
Myrle
Re: Getting started on Fineract CN
Posted by Isaac Kamga <is...@mifos.org>.
Hi Myrle,
On Thu, Mar 1, 2018 at 6:34 PM, Myrle Krantz <my...@apache.org> wrote:
> Hey Isaac,
>
> At a first glance, it looks good. May I ask though why you removed
> the license parameter strictCheck?
>
>
My bad ! Do I update PR with new commit or close this and send in another
?
> Regards,
> Myrle
>
> On Thu, Mar 1, 2018 at 5:27 PM, Isaac Kamga <is...@mifos.org> wrote:
> > Hi Myrle,
> >
> > I've just updated copyright information in fineract-cn-lang and created a
> > new pull request <https://github.com/apache/fineract-cn-lang/pull/4>.
> >
> > I patiently await your review and possible merger.
> >
> > At Your Service,
> > Isaac Kamga.
> >
> > On Thu, Mar 1, 2018 at 5:05 PM, Isaac Kamga <is...@mifos.org>
> wrote:
> >
> >> Hi Myrle,
> >>
> >> Thanks a million for your advice and guidance on this.
> >>
> >> I've closed the Pull Request, will do appropriate changes and send in
> >> another for review.
> >>
> >> At Your Service,
> >> Isaac Kamga.
> >>
> >> On Thu, Mar 1, 2018 at 4:56 PM, Myrle Krantz <my...@apache.org> wrote:
> >>
> >>> Hey Isaac,
> >>>
> >>> Replies inline:
> >>>
> >>> On Thu, Mar 1, 2018 at 1:20 PM, Isaac Kamga <is...@mifos.org>
> >>> wrote:
> >>> > I have just updated the copyright information and package name on the
> >>> > fineract-cn-lang repository and sent in another pull request
> >>> > <https://github.com/apache/fineract-cn-lang/pull/3> for review.
> >>>
> >>> Please make a pull request with *just* the copyright information
> >>> adjusted. Changing package names is a backwards incompatible change.
> >>> By changing them, you break everything that depends on lang. And all
> >>> of the other fineract cn repositories depend on lang. Package names
> >>> will have to be changed in all the repositories at once.
> >>>
> >>> We will have to continue to be careful about backwards compatible
> >>> changes until we have three things:
> >>> * signature checking
> >>> * our artifacts in an artifactory
> >>> * an established process of incrementing versions.
> >>>
> >>> Because changing package names is a global change and changing
> >>> copyright information can be done locally, one repository at a time, I
> >>> believe we should adjust the copyright information first.
> >>>
> >>> > On a related note, I'd like to ask experienced developers on Fineract
> >>> CN if
> >>> > it would be necessary to change the project's name ( from *lang* to
> >>> > *fineract-cn-lang* ) in the settings.gradle
> >>> > <https://github.com/apache/fineract-cn-lang/blob/develop/set
> >>> tings.gradle>
> >>> > file.
> >>>
> >>> I don't see any reason to change those names. the project's name is
> >>> appended to the artifact id. If we did this, the artifact id in this
> >>> case would be org.apache.fineract.cn.fineract-cn-lang. It would
> >>> contain duplicated information. Of course we could adjust the build
> >>> elsewhere to change the artifact id back to lang. But i don't see a
> >>> benefit in changing the project name.
> >>>
> >>> But perhaps I'm missing something here?
> >>>
> >>> > Also, in the bintray.pkg section of the build.gradle file
> >>> > <https://github.com/apache/fineract-cn-lang/blob/develop/
> build.gradle>,
> >>> > should the `repo` , `userOrg` and `vcsUrl` variables be changed too ?
> >>> These
> >>> > will help with subsequent updates to fineract-cn-api,
> >>> > fineract-cn-cassandra, etc.
> >>>
> >>> Oops! Good catch. We can delete the bintray section in that
> >>> build.gradlel file until we're ready to introduce the use of the
> >>> apache artifactory. I don't think you'll find a section like that in
> >>> any other fineract cn project. I was experimenting there.
> >>>
> >>> Thank you for taking this on Isaac,
> >>> Myrle
> >>>
> >>
> >>
>
Re: Getting started on Fineract CN
Posted by Isaac Kamga <is...@mifos.org>.
Hi Myrle,
Thank you for the trust. Will endeavor to do more in the coming days.
At Your Service,
Isaac Kamga.
On Fri, Mar 16, 2018 at 12:01 PM, Myrle Krantz <my...@apache.org> wrote:
> Hi Isaac,
>
> My apologies for the long response time. I had intended to test
> compilation of each pull request, but I should have realized earlier
> that wasn't going to happen in a reasonable time, and just trusted
> you. The PR's are merged now.
>
> Thank you for doing that work. I really appreciate it.
>
> Best Regards,
> Myrle
>
> On Mon, Mar 12, 2018 at 4:59 PM, Isaac Kamga <is...@mifos.org>
> wrote:
> > Hi Myrle,
> >
> > I'm available to update these Pull Requests in case there are any pending
> > corrections you would love to see.
> >
> > At Your Service,
> > Isaac Kamga
> >
> > On Mon, Mar 5, 2018 at 10:03 PM, Isaac Kamga <is...@mifos.org>
> wrote:
> >
> >> Hi Myrle,
> >>
> >> I've updated the PRs which you hadn't merged yet and have opened new
> ones
> >> for the 5 repos you had merged.
> >>
> >> Please feel free to comment on the PRs if they're not perfect before you
> >> merge.
> >>
> >> Cheers,
> >> Isaac Kamga.
> >>
> >> On Mon, Mar 5, 2018 at 2:25 PM, Isaac Kamga <is...@mifos.org>
> wrote:
> >>
> >>> Okay,
> >>>
> >>> I see that you've merged PRs on fineract-cn-lang, fineract-cn-api,
> >>> fineract-cn-cassandra, fineract-cn-mariadb and fineract-cn-async.
> >>>
> >>> Yes please, I would like to update each PR on the repositories which
> you
> >>> haven't merged yet ( viz fineract-cn-command, fineract-cn-test,... )
> during
> >>> the later parts of today to early tomorrow.
> >>>
> >>> Cheers,
> >>> Isaac.
> >>>
> >>> On Mon, Mar 5, 2018 at 1:58 PM, Myrle Krantz <my...@apache.org> wrote:
> >>>
> >>>> : o)
> >>>>
> >>>> Did you want to do just the ones I haven't merged yet? If so, I'll
> >>>> hold up and wait.
> >>>>
> >>>> Greets,
> >>>> Myrle
> >>>>
> >>>> On Mon, Mar 5, 2018 at 1:49 PM, Isaac Kamga <
> isaac.kamga@skylabase.com>
> >>>> wrote:
> >>>> > Hi Myrle,
> >>>> >
> >>>> > Thanks for taking time out to review.
> >>>> >
> >>>> > About those 2 last lines of code, I could update all pull requests
> by
> >>>> > removing the ext.name and ext.year variables but you already
> started
> >>>> > merging some... ;-).
> >>>> >
> >>>> > Cheers,
> >>>> > Isaac Kamga.
> >>>>
> >>>
> >>>
> >>
>
Re: Getting started on Fineract CN
Posted by Myrle Krantz <my...@apache.org>.
Hi Isaac,
My apologies for the long response time. I had intended to test
compilation of each pull request, but I should have realized earlier
that wasn't going to happen in a reasonable time, and just trusted
you. The PR's are merged now.
Thank you for doing that work. I really appreciate it.
Best Regards,
Myrle
On Mon, Mar 12, 2018 at 4:59 PM, Isaac Kamga <is...@mifos.org> wrote:
> Hi Myrle,
>
> I'm available to update these Pull Requests in case there are any pending
> corrections you would love to see.
>
> At Your Service,
> Isaac Kamga
>
> On Mon, Mar 5, 2018 at 10:03 PM, Isaac Kamga <is...@mifos.org> wrote:
>
>> Hi Myrle,
>>
>> I've updated the PRs which you hadn't merged yet and have opened new ones
>> for the 5 repos you had merged.
>>
>> Please feel free to comment on the PRs if they're not perfect before you
>> merge.
>>
>> Cheers,
>> Isaac Kamga.
>>
>> On Mon, Mar 5, 2018 at 2:25 PM, Isaac Kamga <is...@mifos.org> wrote:
>>
>>> Okay,
>>>
>>> I see that you've merged PRs on fineract-cn-lang, fineract-cn-api,
>>> fineract-cn-cassandra, fineract-cn-mariadb and fineract-cn-async.
>>>
>>> Yes please, I would like to update each PR on the repositories which you
>>> haven't merged yet ( viz fineract-cn-command, fineract-cn-test,... ) during
>>> the later parts of today to early tomorrow.
>>>
>>> Cheers,
>>> Isaac.
>>>
>>> On Mon, Mar 5, 2018 at 1:58 PM, Myrle Krantz <my...@apache.org> wrote:
>>>
>>>> : o)
>>>>
>>>> Did you want to do just the ones I haven't merged yet? If so, I'll
>>>> hold up and wait.
>>>>
>>>> Greets,
>>>> Myrle
>>>>
>>>> On Mon, Mar 5, 2018 at 1:49 PM, Isaac Kamga <is...@skylabase.com>
>>>> wrote:
>>>> > Hi Myrle,
>>>> >
>>>> > Thanks for taking time out to review.
>>>> >
>>>> > About those 2 last lines of code, I could update all pull requests by
>>>> > removing the ext.name and ext.year variables but you already started
>>>> > merging some... ;-).
>>>> >
>>>> > Cheers,
>>>> > Isaac Kamga.
>>>>
>>>
>>>
>>
Re: Getting started on Fineract CN
Posted by Isaac Kamga <is...@mifos.org>.
Hi Myrle,
I'm available to update these Pull Requests in case there are any pending
corrections you would love to see.
At Your Service,
Isaac Kamga
On Mon, Mar 5, 2018 at 10:03 PM, Isaac Kamga <is...@mifos.org> wrote:
> Hi Myrle,
>
> I've updated the PRs which you hadn't merged yet and have opened new ones
> for the 5 repos you had merged.
>
> Please feel free to comment on the PRs if they're not perfect before you
> merge.
>
> Cheers,
> Isaac Kamga.
>
> On Mon, Mar 5, 2018 at 2:25 PM, Isaac Kamga <is...@mifos.org> wrote:
>
>> Okay,
>>
>> I see that you've merged PRs on fineract-cn-lang, fineract-cn-api,
>> fineract-cn-cassandra, fineract-cn-mariadb and fineract-cn-async.
>>
>> Yes please, I would like to update each PR on the repositories which you
>> haven't merged yet ( viz fineract-cn-command, fineract-cn-test,... ) during
>> the later parts of today to early tomorrow.
>>
>> Cheers,
>> Isaac.
>>
>> On Mon, Mar 5, 2018 at 1:58 PM, Myrle Krantz <my...@apache.org> wrote:
>>
>>> : o)
>>>
>>> Did you want to do just the ones I haven't merged yet? If so, I'll
>>> hold up and wait.
>>>
>>> Greets,
>>> Myrle
>>>
>>> On Mon, Mar 5, 2018 at 1:49 PM, Isaac Kamga <is...@skylabase.com>
>>> wrote:
>>> > Hi Myrle,
>>> >
>>> > Thanks for taking time out to review.
>>> >
>>> > About those 2 last lines of code, I could update all pull requests by
>>> > removing the ext.name and ext.year variables but you already started
>>> > merging some... ;-).
>>> >
>>> > Cheers,
>>> > Isaac Kamga.
>>>
>>
>>
>
Re: Getting started on Fineract CN
Posted by Isaac Kamga <is...@mifos.org>.
Hi Myrle,
I've updated the PRs which you hadn't merged yet and have opened new ones
for the 5 repos you had merged.
Please feel free to comment on the PRs if they're not perfect before you
merge.
Cheers,
Isaac Kamga.
On Mon, Mar 5, 2018 at 2:25 PM, Isaac Kamga <is...@mifos.org> wrote:
> Okay,
>
> I see that you've merged PRs on fineract-cn-lang, fineract-cn-api,
> fineract-cn-cassandra, fineract-cn-mariadb and fineract-cn-async.
>
> Yes please, I would like to update each PR on the repositories which you
> haven't merged yet ( viz fineract-cn-command, fineract-cn-test,... ) during
> the later parts of today to early tomorrow.
>
> Cheers,
> Isaac.
>
> On Mon, Mar 5, 2018 at 1:58 PM, Myrle Krantz <my...@apache.org> wrote:
>
>> : o)
>>
>> Did you want to do just the ones I haven't merged yet? If so, I'll
>> hold up and wait.
>>
>> Greets,
>> Myrle
>>
>> On Mon, Mar 5, 2018 at 1:49 PM, Isaac Kamga <is...@skylabase.com>
>> wrote:
>> > Hi Myrle,
>> >
>> > Thanks for taking time out to review.
>> >
>> > About those 2 last lines of code, I could update all pull requests by
>> > removing the ext.name and ext.year variables but you already started
>> > merging some... ;-).
>> >
>> > Cheers,
>> > Isaac Kamga.
>>
>
>
Re: Getting started on Fineract CN
Posted by Isaac Kamga <is...@mifos.org>.
Okay,
I see that you've merged PRs on fineract-cn-lang, fineract-cn-api,
fineract-cn-cassandra, fineract-cn-mariadb and fineract-cn-async.
Yes please, I would like to update each PR on the repositories which you
haven't merged yet ( viz fineract-cn-command, fineract-cn-test,... ) during
the later parts of today to early tomorrow.
Cheers,
Isaac.
On Mon, Mar 5, 2018 at 1:58 PM, Myrle Krantz <my...@apache.org> wrote:
> : o)
>
> Did you want to do just the ones I haven't merged yet? If so, I'll
> hold up and wait.
>
> Greets,
> Myrle
>
> On Mon, Mar 5, 2018 at 1:49 PM, Isaac Kamga <is...@skylabase.com>
> wrote:
> > Hi Myrle,
> >
> > Thanks for taking time out to review.
> >
> > About those 2 last lines of code, I could update all pull requests by
> > removing the ext.name and ext.year variables but you already started
> > merging some... ;-).
> >
> > Cheers,
> > Isaac Kamga.
>
Re: Getting started on Fineract CN
Posted by Myrle Krantz <my...@apache.org>.
: o)
Did you want to do just the ones I haven't merged yet? If so, I'll
hold up and wait.
Greets,
Myrle
On Mon, Mar 5, 2018 at 1:49 PM, Isaac Kamga <is...@skylabase.com> wrote:
> Hi Myrle,
>
> Thanks for taking time out to review.
>
> About those 2 last lines of code, I could update all pull requests by
> removing the ext.name and ext.year variables but you already started
> merging some... ;-).
>
> Cheers,
> Isaac Kamga.
Re: Getting started on Fineract CN
Posted by Isaac Kamga <is...@skylabase.com>.
Hi Myrle,
Thanks for taking time out to review.
About those 2 last lines of code, I could update all pull requests by
removing the ext.name and ext.year variables but you already started
merging some... ;-).
Cheers,
Isaac Kamga.
On Mon, Mar 5, 2018 at 12:57 PM, Myrle Krantz <my...@apache.org> wrote:
> Hey Isaac,
>
> I'm reviewing your pull requests bit-by-bit, but I'm not going to be
> able to get through them all today, because I've got some other stuff
> I have to work on.
>
> What I've seen so far looks great though, so I've been merging them,
> once I've tested the build on my local machine.
>
> One tiny niggle that I didn't feel was worth holding up the merge for:
> the ext.name and ext.year variables aren't necessary anymore because
> the header you're using doesn't address them. Those two lines can
> eventually be deleted, even if they aren't hurting anyone now.
>
> Best Regards,
> Myrle
>
> On Thu, Mar 1, 2018 at 8:38 PM, Isaac Kamga <is...@mifos.org> wrote:
> > Thanks a million Myrle and Phil.
> >
> > I followed your instructions and have updated the Pull Request with a new
> > commit.
> >
> > At Your Service,
> > Isaac Kamga.
> >
> > On Thu, Mar 1, 2018 at 7:49 PM, Myrle Krantz <my...@apache.org> wrote:
> >
> >> Oops. Do what Phil says. He knows better.
> >>
> >> Greets,
> >> Myrle
> >>
> >> On Thu 1. Mar 2018 at 19:43 Phil Steitz <ph...@gmail.com> wrote:
> >>
> >> > On 3/1/18 10:34 AM, Myrle Krantz wrote:
> >> > > Hey Isaac,
> >> > >
> >> > > At a first glance, it looks good. May I ask though why you removed
> >> > > the license parameter strictCheck?
> >> > >
> >> > > Regards,
> >> > > Myrle
> >> >
> >> > The copyright statement should be removed entirely from the source
> >> > header files and placed instead in NOTICE.txt.
> >> >
> >> > See http://www.apache.org/legal/src-headers.html
> >> >
> >> > Phil
> >> > >
> >> > > On Thu, Mar 1, 2018 at 5:27 PM, Isaac Kamga <is...@mifos.org>
> >> > wrote:
> >> > >> Hi Myrle,
> >> > >>
> >> > >> I've just updated copyright information in fineract-cn-lang and
> >> created
> >> > a
> >> > >> new pull request <https://github.com/apache/
> fineract-cn-lang/pull/4>.
> >> > >>
> >> > >> I patiently await your review and possible merger.
> >> > >>
> >> > >> At Your Service,
> >> > >> Isaac Kamga.
> >> > >>
> >> > >> On Thu, Mar 1, 2018 at 5:05 PM, Isaac Kamga <isaac.kamga@mifos.org
> >
> >> > wrote:
> >> > >>
> >> > >>> Hi Myrle,
> >> > >>>
> >> > >>> Thanks a million for your advice and guidance on this.
> >> > >>>
> >> > >>> I've closed the Pull Request, will do appropriate changes and
> send in
> >> > >>> another for review.
> >> > >>>
> >> > >>> At Your Service,
> >> > >>> Isaac Kamga.
> >> > >>>
> >> > >>> On Thu, Mar 1, 2018 at 4:56 PM, Myrle Krantz <my...@apache.org>
> >> wrote:
> >> > >>>
> >> > >>>> Hey Isaac,
> >> > >>>>
> >> > >>>> Replies inline:
> >> > >>>>
> >> > >>>> On Thu, Mar 1, 2018 at 1:20 PM, Isaac Kamga <
> isaac.kamga@mifos.org>
> >> > >>>> wrote:
> >> > >>>>> I have just updated the copyright information and package name
> on
> >> the
> >> > >>>>> fineract-cn-lang repository and sent in another pull request
> >> > >>>>> <https://github.com/apache/fineract-cn-lang/pull/3> for review.
> >> > >>>> Please make a pull request with *just* the copyright information
> >> > >>>> adjusted. Changing package names is a backwards incompatible
> >> change.
> >> > >>>> By changing them, you break everything that depends on lang. And
> >> all
> >> > >>>> of the other fineract cn repositories depend on lang. Package
> names
> >> > >>>> will have to be changed in all the repositories at once.
> >> > >>>>
> >> > >>>> We will have to continue to be careful about backwards compatible
> >> > >>>> changes until we have three things:
> >> > >>>> * signature checking
> >> > >>>> * our artifacts in an artifactory
> >> > >>>> * an established process of incrementing versions.
> >> > >>>>
> >> > >>>> Because changing package names is a global change and changing
> >> > >>>> copyright information can be done locally, one repository at a
> >> time, I
> >> > >>>> believe we should adjust the copyright information first.
> >> > >>>>
> >> > >>>>> On a related note, I'd like to ask experienced developers on
> >> Fineract
> >> > >>>> CN if
> >> > >>>>> it would be necessary to change the project's name ( from
> *lang* to
> >> > >>>>> *fineract-cn-lang* ) in the settings.gradle
> >> > >>>>> <https://github.com/apache/fineract-cn-lang/blob/develop/set
> >> > >>>> tings.gradle>
> >> > >>>>> file.
> >> > >>>> I don't see any reason to change those names. the project's
> name is
> >> > >>>> appended to the artifact id. If we did this, the artifact id in
> >> this
> >> > >>>> case would be org.apache.fineract.cn.fineract-cn-lang. It would
> >> > >>>> contain duplicated information. Of course we could adjust the
> build
> >> > >>>> elsewhere to change the artifact id back to lang. But i don't
> see a
> >> > >>>> benefit in changing the project name.
> >> > >>>>
> >> > >>>> But perhaps I'm missing something here?
> >> > >>>>
> >> > >>>>> Also, in the bintray.pkg section of the build.gradle file
> >> > >>>>> <
> >> > https://github.com/apache/fineract-cn-lang/blob/develop/build.gradle
> >,
> >> > >>>>> should the `repo` , `userOrg` and `vcsUrl` variables be changed
> >> too ?
> >> > >>>> These
> >> > >>>>> will help with subsequent updates to fineract-cn-api,
> >> > >>>>> fineract-cn-cassandra, etc.
> >> > >>>> Oops! Good catch. We can delete the bintray section in that
> >> > >>>> build.gradlel file until we're ready to introduce the use of the
> >> > >>>> apache artifactory. I don't think you'll find a section like
> that
> >> in
> >> > >>>> any other fineract cn project. I was experimenting there.
> >> > >>>>
> >> > >>>> Thank you for taking this on Isaac,
> >> > >>>> Myrle
> >> > >>>>
> >> > >>>
> >> >
> >> >
> >>
>
Re: Getting started on Fineract CN
Posted by Myrle Krantz <my...@apache.org>.
Hey Isaac,
I'm reviewing your pull requests bit-by-bit, but I'm not going to be
able to get through them all today, because I've got some other stuff
I have to work on.
What I've seen so far looks great though, so I've been merging them,
once I've tested the build on my local machine.
One tiny niggle that I didn't feel was worth holding up the merge for:
the ext.name and ext.year variables aren't necessary anymore because
the header you're using doesn't address them. Those two lines can
eventually be deleted, even if they aren't hurting anyone now.
Best Regards,
Myrle
On Thu, Mar 1, 2018 at 8:38 PM, Isaac Kamga <is...@mifos.org> wrote:
> Thanks a million Myrle and Phil.
>
> I followed your instructions and have updated the Pull Request with a new
> commit.
>
> At Your Service,
> Isaac Kamga.
>
> On Thu, Mar 1, 2018 at 7:49 PM, Myrle Krantz <my...@apache.org> wrote:
>
>> Oops. Do what Phil says. He knows better.
>>
>> Greets,
>> Myrle
>>
>> On Thu 1. Mar 2018 at 19:43 Phil Steitz <ph...@gmail.com> wrote:
>>
>> > On 3/1/18 10:34 AM, Myrle Krantz wrote:
>> > > Hey Isaac,
>> > >
>> > > At a first glance, it looks good. May I ask though why you removed
>> > > the license parameter strictCheck?
>> > >
>> > > Regards,
>> > > Myrle
>> >
>> > The copyright statement should be removed entirely from the source
>> > header files and placed instead in NOTICE.txt.
>> >
>> > See http://www.apache.org/legal/src-headers.html
>> >
>> > Phil
>> > >
>> > > On Thu, Mar 1, 2018 at 5:27 PM, Isaac Kamga <is...@mifos.org>
>> > wrote:
>> > >> Hi Myrle,
>> > >>
>> > >> I've just updated copyright information in fineract-cn-lang and
>> created
>> > a
>> > >> new pull request <https://github.com/apache/fineract-cn-lang/pull/4>.
>> > >>
>> > >> I patiently await your review and possible merger.
>> > >>
>> > >> At Your Service,
>> > >> Isaac Kamga.
>> > >>
>> > >> On Thu, Mar 1, 2018 at 5:05 PM, Isaac Kamga <is...@mifos.org>
>> > wrote:
>> > >>
>> > >>> Hi Myrle,
>> > >>>
>> > >>> Thanks a million for your advice and guidance on this.
>> > >>>
>> > >>> I've closed the Pull Request, will do appropriate changes and send in
>> > >>> another for review.
>> > >>>
>> > >>> At Your Service,
>> > >>> Isaac Kamga.
>> > >>>
>> > >>> On Thu, Mar 1, 2018 at 4:56 PM, Myrle Krantz <my...@apache.org>
>> wrote:
>> > >>>
>> > >>>> Hey Isaac,
>> > >>>>
>> > >>>> Replies inline:
>> > >>>>
>> > >>>> On Thu, Mar 1, 2018 at 1:20 PM, Isaac Kamga <is...@mifos.org>
>> > >>>> wrote:
>> > >>>>> I have just updated the copyright information and package name on
>> the
>> > >>>>> fineract-cn-lang repository and sent in another pull request
>> > >>>>> <https://github.com/apache/fineract-cn-lang/pull/3> for review.
>> > >>>> Please make a pull request with *just* the copyright information
>> > >>>> adjusted. Changing package names is a backwards incompatible
>> change.
>> > >>>> By changing them, you break everything that depends on lang. And
>> all
>> > >>>> of the other fineract cn repositories depend on lang. Package names
>> > >>>> will have to be changed in all the repositories at once.
>> > >>>>
>> > >>>> We will have to continue to be careful about backwards compatible
>> > >>>> changes until we have three things:
>> > >>>> * signature checking
>> > >>>> * our artifacts in an artifactory
>> > >>>> * an established process of incrementing versions.
>> > >>>>
>> > >>>> Because changing package names is a global change and changing
>> > >>>> copyright information can be done locally, one repository at a
>> time, I
>> > >>>> believe we should adjust the copyright information first.
>> > >>>>
>> > >>>>> On a related note, I'd like to ask experienced developers on
>> Fineract
>> > >>>> CN if
>> > >>>>> it would be necessary to change the project's name ( from *lang* to
>> > >>>>> *fineract-cn-lang* ) in the settings.gradle
>> > >>>>> <https://github.com/apache/fineract-cn-lang/blob/develop/set
>> > >>>> tings.gradle>
>> > >>>>> file.
>> > >>>> I don't see any reason to change those names. the project's name is
>> > >>>> appended to the artifact id. If we did this, the artifact id in
>> this
>> > >>>> case would be org.apache.fineract.cn.fineract-cn-lang. It would
>> > >>>> contain duplicated information. Of course we could adjust the build
>> > >>>> elsewhere to change the artifact id back to lang. But i don't see a
>> > >>>> benefit in changing the project name.
>> > >>>>
>> > >>>> But perhaps I'm missing something here?
>> > >>>>
>> > >>>>> Also, in the bintray.pkg section of the build.gradle file
>> > >>>>> <
>> > https://github.com/apache/fineract-cn-lang/blob/develop/build.gradle>,
>> > >>>>> should the `repo` , `userOrg` and `vcsUrl` variables be changed
>> too ?
>> > >>>> These
>> > >>>>> will help with subsequent updates to fineract-cn-api,
>> > >>>>> fineract-cn-cassandra, etc.
>> > >>>> Oops! Good catch. We can delete the bintray section in that
>> > >>>> build.gradlel file until we're ready to introduce the use of the
>> > >>>> apache artifactory. I don't think you'll find a section like that
>> in
>> > >>>> any other fineract cn project. I was experimenting there.
>> > >>>>
>> > >>>> Thank you for taking this on Isaac,
>> > >>>> Myrle
>> > >>>>
>> > >>>
>> >
>> >
>>
Re: Getting started on Fineract CN
Posted by Isaac Kamga <is...@mifos.org>.
Please disregard the above email.
Reimporting the fineract-cn-permitted-feign-client project once more into
IDE fixed the issue.
I'm continue updating copyright information onwards from
permitted-feign-client.
Cheers,
Isaac Kamga.
On Fri, Mar 2, 2018 at 6:49 PM, Isaac Kamga <is...@mifos.org> wrote:
> Hi Myrle,
>
> You may have observed the pull requests I just created on api, cassandra,
> etc.
>
> I ran into an issue when working on the permitted-feign-client repository.
> `./gradlew publishToMavenLocal` and `./gradlew licenseFormat` work fine but
> `./gradlew prepareForTest` fails because `import
> io.mifos.permittedfeignclient.annotation.EndpointSet` ( amongst other
> imports ) doesn't work.
>
> Exemplary error is
> `error: cannot find symbol
> private final static InitializedMicroservice<Another> another= new
> InitializedMicroservice<>(Another.class, "permitted-feign-client",
> "0.1.0-BUILD-SNAPSHOT", integrationTestEnvironment);
> ^
> symbol: class Another
> location: class TestAccessAnother
> `
> Given that it's copyright information being updated and license checks
> work fine, do I create a PR for permitted-feign-client ? Any suggestions on
> how to fix this will be greatly appreciated.
>
> At Your Service,
> Isaac Kamga.
>
> On Thu, Mar 1, 2018 at 8:38 PM, Isaac Kamga <is...@mifos.org> wrote:
>
>> Thanks a million Myrle and Phil.
>>
>> I followed your instructions and have updated the Pull Request with a new
>> commit.
>>
>> At Your Service,
>> Isaac Kamga.
>>
>> On Thu, Mar 1, 2018 at 7:49 PM, Myrle Krantz <my...@apache.org> wrote:
>>
>>> Oops. Do what Phil says. He knows better.
>>>
>>> Greets,
>>> Myrle
>>>
>>> On Thu 1. Mar 2018 at 19:43 Phil Steitz <ph...@gmail.com> wrote:
>>>
>>> > On 3/1/18 10:34 AM, Myrle Krantz wrote:
>>> > > Hey Isaac,
>>> > >
>>> > > At a first glance, it looks good. May I ask though why you removed
>>> > > the license parameter strictCheck?
>>> > >
>>> > > Regards,
>>> > > Myrle
>>> >
>>> > The copyright statement should be removed entirely from the source
>>> > header files and placed instead in NOTICE.txt.
>>> >
>>> > See http://www.apache.org/legal/src-headers.html
>>> >
>>> > Phil
>>> > >
>>> > > On Thu, Mar 1, 2018 at 5:27 PM, Isaac Kamga <is...@mifos.org>
>>> > wrote:
>>> > >> Hi Myrle,
>>> > >>
>>> > >> I've just updated copyright information in fineract-cn-lang and
>>> created
>>> > a
>>> > >> new pull request <https://github.com/apache/fineract-cn-lang/pull/4
>>> >.
>>> > >>
>>> > >> I patiently await your review and possible merger.
>>> > >>
>>> > >> At Your Service,
>>> > >> Isaac Kamga.
>>> > >>
>>> > >> On Thu, Mar 1, 2018 at 5:05 PM, Isaac Kamga <is...@mifos.org>
>>> > wrote:
>>> > >>
>>> > >>> Hi Myrle,
>>> > >>>
>>> > >>> Thanks a million for your advice and guidance on this.
>>> > >>>
>>> > >>> I've closed the Pull Request, will do appropriate changes and send
>>> in
>>> > >>> another for review.
>>> > >>>
>>> > >>> At Your Service,
>>> > >>> Isaac Kamga.
>>> > >>>
>>> > >>> On Thu, Mar 1, 2018 at 4:56 PM, Myrle Krantz <my...@apache.org>
>>> wrote:
>>> > >>>
>>> > >>>> Hey Isaac,
>>> > >>>>
>>> > >>>> Replies inline:
>>> > >>>>
>>> > >>>> On Thu, Mar 1, 2018 at 1:20 PM, Isaac Kamga <
>>> isaac.kamga@mifos.org>
>>> > >>>> wrote:
>>> > >>>>> I have just updated the copyright information and package name
>>> on the
>>> > >>>>> fineract-cn-lang repository and sent in another pull request
>>> > >>>>> <https://github.com/apache/fineract-cn-lang/pull/3> for review.
>>> > >>>> Please make a pull request with *just* the copyright information
>>> > >>>> adjusted. Changing package names is a backwards incompatible
>>> change.
>>> > >>>> By changing them, you break everything that depends on lang. And
>>> all
>>> > >>>> of the other fineract cn repositories depend on lang. Package
>>> names
>>> > >>>> will have to be changed in all the repositories at once.
>>> > >>>>
>>> > >>>> We will have to continue to be careful about backwards compatible
>>> > >>>> changes until we have three things:
>>> > >>>> * signature checking
>>> > >>>> * our artifacts in an artifactory
>>> > >>>> * an established process of incrementing versions.
>>> > >>>>
>>> > >>>> Because changing package names is a global change and changing
>>> > >>>> copyright information can be done locally, one repository at a
>>> time, I
>>> > >>>> believe we should adjust the copyright information first.
>>> > >>>>
>>> > >>>>> On a related note, I'd like to ask experienced developers on
>>> Fineract
>>> > >>>> CN if
>>> > >>>>> it would be necessary to change the project's name ( from *lang*
>>> to
>>> > >>>>> *fineract-cn-lang* ) in the settings.gradle
>>> > >>>>> <https://github.com/apache/fineract-cn-lang/blob/develop/set
>>> > >>>> tings.gradle>
>>> > >>>>> file.
>>> > >>>> I don't see any reason to change those names. the project's name
>>> is
>>> > >>>> appended to the artifact id. If we did this, the artifact id in
>>> this
>>> > >>>> case would be org.apache.fineract.cn.fineract-cn-lang. It would
>>> > >>>> contain duplicated information. Of course we could adjust the
>>> build
>>> > >>>> elsewhere to change the artifact id back to lang. But i don't
>>> see a
>>> > >>>> benefit in changing the project name.
>>> > >>>>
>>> > >>>> But perhaps I'm missing something here?
>>> > >>>>
>>> > >>>>> Also, in the bintray.pkg section of the build.gradle file
>>> > >>>>> <
>>> > https://github.com/apache/fineract-cn-lang/blob/develop/build.gradle>,
>>> > >>>>> should the `repo` , `userOrg` and `vcsUrl` variables be changed
>>> too ?
>>> > >>>> These
>>> > >>>>> will help with subsequent updates to fineract-cn-api,
>>> > >>>>> fineract-cn-cassandra, etc.
>>> > >>>> Oops! Good catch. We can delete the bintray section in that
>>> > >>>> build.gradlel file until we're ready to introduce the use of the
>>> > >>>> apache artifactory. I don't think you'll find a section like
>>> that in
>>> > >>>> any other fineract cn project. I was experimenting there.
>>> > >>>>
>>> > >>>> Thank you for taking this on Isaac,
>>> > >>>> Myrle
>>> > >>>>
>>> > >>>
>>> >
>>> >
>>>
>>
>>
>
Re: Getting started on Fineract CN
Posted by Isaac Kamga <is...@mifos.org>.
Hi Myrle,
You may have observed the pull requests I just created on api, cassandra,
etc.
I ran into an issue when working on the permitted-feign-client repository.
`./gradlew publishToMavenLocal` and `./gradlew licenseFormat` work fine but
`./gradlew prepareForTest` fails because `import
io.mifos.permittedfeignclient.annotation.EndpointSet` ( amongst other
imports ) doesn't work.
Exemplary error is
`error: cannot find symbol
private final static InitializedMicroservice<Another> another= new
InitializedMicroservice<>(Another.class, "permitted-feign-client",
"0.1.0-BUILD-SNAPSHOT", integrationTestEnvironment);
^
symbol: class Another
location: class TestAccessAnother
`
Given that it's copyright information being updated and license checks work
fine, do I create a PR for permitted-feign-client ? Any suggestions on how
to fix this will be greatly appreciated.
At Your Service,
Isaac Kamga.
On Thu, Mar 1, 2018 at 8:38 PM, Isaac Kamga <is...@mifos.org> wrote:
> Thanks a million Myrle and Phil.
>
> I followed your instructions and have updated the Pull Request with a new
> commit.
>
> At Your Service,
> Isaac Kamga.
>
> On Thu, Mar 1, 2018 at 7:49 PM, Myrle Krantz <my...@apache.org> wrote:
>
>> Oops. Do what Phil says. He knows better.
>>
>> Greets,
>> Myrle
>>
>> On Thu 1. Mar 2018 at 19:43 Phil Steitz <ph...@gmail.com> wrote:
>>
>> > On 3/1/18 10:34 AM, Myrle Krantz wrote:
>> > > Hey Isaac,
>> > >
>> > > At a first glance, it looks good. May I ask though why you removed
>> > > the license parameter strictCheck?
>> > >
>> > > Regards,
>> > > Myrle
>> >
>> > The copyright statement should be removed entirely from the source
>> > header files and placed instead in NOTICE.txt.
>> >
>> > See http://www.apache.org/legal/src-headers.html
>> >
>> > Phil
>> > >
>> > > On Thu, Mar 1, 2018 at 5:27 PM, Isaac Kamga <is...@mifos.org>
>> > wrote:
>> > >> Hi Myrle,
>> > >>
>> > >> I've just updated copyright information in fineract-cn-lang and
>> created
>> > a
>> > >> new pull request <https://github.com/apache/fineract-cn-lang/pull/4
>> >.
>> > >>
>> > >> I patiently await your review and possible merger.
>> > >>
>> > >> At Your Service,
>> > >> Isaac Kamga.
>> > >>
>> > >> On Thu, Mar 1, 2018 at 5:05 PM, Isaac Kamga <is...@mifos.org>
>> > wrote:
>> > >>
>> > >>> Hi Myrle,
>> > >>>
>> > >>> Thanks a million for your advice and guidance on this.
>> > >>>
>> > >>> I've closed the Pull Request, will do appropriate changes and send
>> in
>> > >>> another for review.
>> > >>>
>> > >>> At Your Service,
>> > >>> Isaac Kamga.
>> > >>>
>> > >>> On Thu, Mar 1, 2018 at 4:56 PM, Myrle Krantz <my...@apache.org>
>> wrote:
>> > >>>
>> > >>>> Hey Isaac,
>> > >>>>
>> > >>>> Replies inline:
>> > >>>>
>> > >>>> On Thu, Mar 1, 2018 at 1:20 PM, Isaac Kamga <isaac.kamga@mifos.org
>> >
>> > >>>> wrote:
>> > >>>>> I have just updated the copyright information and package name on
>> the
>> > >>>>> fineract-cn-lang repository and sent in another pull request
>> > >>>>> <https://github.com/apache/fineract-cn-lang/pull/3> for review.
>> > >>>> Please make a pull request with *just* the copyright information
>> > >>>> adjusted. Changing package names is a backwards incompatible
>> change.
>> > >>>> By changing them, you break everything that depends on lang. And
>> all
>> > >>>> of the other fineract cn repositories depend on lang. Package
>> names
>> > >>>> will have to be changed in all the repositories at once.
>> > >>>>
>> > >>>> We will have to continue to be careful about backwards compatible
>> > >>>> changes until we have three things:
>> > >>>> * signature checking
>> > >>>> * our artifacts in an artifactory
>> > >>>> * an established process of incrementing versions.
>> > >>>>
>> > >>>> Because changing package names is a global change and changing
>> > >>>> copyright information can be done locally, one repository at a
>> time, I
>> > >>>> believe we should adjust the copyright information first.
>> > >>>>
>> > >>>>> On a related note, I'd like to ask experienced developers on
>> Fineract
>> > >>>> CN if
>> > >>>>> it would be necessary to change the project's name ( from *lang*
>> to
>> > >>>>> *fineract-cn-lang* ) in the settings.gradle
>> > >>>>> <https://github.com/apache/fineract-cn-lang/blob/develop/set
>> > >>>> tings.gradle>
>> > >>>>> file.
>> > >>>> I don't see any reason to change those names. the project's name
>> is
>> > >>>> appended to the artifact id. If we did this, the artifact id in
>> this
>> > >>>> case would be org.apache.fineract.cn.fineract-cn-lang. It would
>> > >>>> contain duplicated information. Of course we could adjust the
>> build
>> > >>>> elsewhere to change the artifact id back to lang. But i don't see
>> a
>> > >>>> benefit in changing the project name.
>> > >>>>
>> > >>>> But perhaps I'm missing something here?
>> > >>>>
>> > >>>>> Also, in the bintray.pkg section of the build.gradle file
>> > >>>>> <
>> > https://github.com/apache/fineract-cn-lang/blob/develop/build.gradle>,
>> > >>>>> should the `repo` , `userOrg` and `vcsUrl` variables be changed
>> too ?
>> > >>>> These
>> > >>>>> will help with subsequent updates to fineract-cn-api,
>> > >>>>> fineract-cn-cassandra, etc.
>> > >>>> Oops! Good catch. We can delete the bintray section in that
>> > >>>> build.gradlel file until we're ready to introduce the use of the
>> > >>>> apache artifactory. I don't think you'll find a section like that
>> in
>> > >>>> any other fineract cn project. I was experimenting there.
>> > >>>>
>> > >>>> Thank you for taking this on Isaac,
>> > >>>> Myrle
>> > >>>>
>> > >>>
>> >
>> >
>>
>
>
Re: Getting started on Fineract CN
Posted by Isaac Kamga <is...@mifos.org>.
Thanks a million Myrle and Phil.
I followed your instructions and have updated the Pull Request with a new
commit.
At Your Service,
Isaac Kamga.
On Thu, Mar 1, 2018 at 7:49 PM, Myrle Krantz <my...@apache.org> wrote:
> Oops. Do what Phil says. He knows better.
>
> Greets,
> Myrle
>
> On Thu 1. Mar 2018 at 19:43 Phil Steitz <ph...@gmail.com> wrote:
>
> > On 3/1/18 10:34 AM, Myrle Krantz wrote:
> > > Hey Isaac,
> > >
> > > At a first glance, it looks good. May I ask though why you removed
> > > the license parameter strictCheck?
> > >
> > > Regards,
> > > Myrle
> >
> > The copyright statement should be removed entirely from the source
> > header files and placed instead in NOTICE.txt.
> >
> > See http://www.apache.org/legal/src-headers.html
> >
> > Phil
> > >
> > > On Thu, Mar 1, 2018 at 5:27 PM, Isaac Kamga <is...@mifos.org>
> > wrote:
> > >> Hi Myrle,
> > >>
> > >> I've just updated copyright information in fineract-cn-lang and
> created
> > a
> > >> new pull request <https://github.com/apache/fineract-cn-lang/pull/4>.
> > >>
> > >> I patiently await your review and possible merger.
> > >>
> > >> At Your Service,
> > >> Isaac Kamga.
> > >>
> > >> On Thu, Mar 1, 2018 at 5:05 PM, Isaac Kamga <is...@mifos.org>
> > wrote:
> > >>
> > >>> Hi Myrle,
> > >>>
> > >>> Thanks a million for your advice and guidance on this.
> > >>>
> > >>> I've closed the Pull Request, will do appropriate changes and send in
> > >>> another for review.
> > >>>
> > >>> At Your Service,
> > >>> Isaac Kamga.
> > >>>
> > >>> On Thu, Mar 1, 2018 at 4:56 PM, Myrle Krantz <my...@apache.org>
> wrote:
> > >>>
> > >>>> Hey Isaac,
> > >>>>
> > >>>> Replies inline:
> > >>>>
> > >>>> On Thu, Mar 1, 2018 at 1:20 PM, Isaac Kamga <is...@mifos.org>
> > >>>> wrote:
> > >>>>> I have just updated the copyright information and package name on
> the
> > >>>>> fineract-cn-lang repository and sent in another pull request
> > >>>>> <https://github.com/apache/fineract-cn-lang/pull/3> for review.
> > >>>> Please make a pull request with *just* the copyright information
> > >>>> adjusted. Changing package names is a backwards incompatible
> change.
> > >>>> By changing them, you break everything that depends on lang. And
> all
> > >>>> of the other fineract cn repositories depend on lang. Package names
> > >>>> will have to be changed in all the repositories at once.
> > >>>>
> > >>>> We will have to continue to be careful about backwards compatible
> > >>>> changes until we have three things:
> > >>>> * signature checking
> > >>>> * our artifacts in an artifactory
> > >>>> * an established process of incrementing versions.
> > >>>>
> > >>>> Because changing package names is a global change and changing
> > >>>> copyright information can be done locally, one repository at a
> time, I
> > >>>> believe we should adjust the copyright information first.
> > >>>>
> > >>>>> On a related note, I'd like to ask experienced developers on
> Fineract
> > >>>> CN if
> > >>>>> it would be necessary to change the project's name ( from *lang* to
> > >>>>> *fineract-cn-lang* ) in the settings.gradle
> > >>>>> <https://github.com/apache/fineract-cn-lang/blob/develop/set
> > >>>> tings.gradle>
> > >>>>> file.
> > >>>> I don't see any reason to change those names. the project's name is
> > >>>> appended to the artifact id. If we did this, the artifact id in
> this
> > >>>> case would be org.apache.fineract.cn.fineract-cn-lang. It would
> > >>>> contain duplicated information. Of course we could adjust the build
> > >>>> elsewhere to change the artifact id back to lang. But i don't see a
> > >>>> benefit in changing the project name.
> > >>>>
> > >>>> But perhaps I'm missing something here?
> > >>>>
> > >>>>> Also, in the bintray.pkg section of the build.gradle file
> > >>>>> <
> > https://github.com/apache/fineract-cn-lang/blob/develop/build.gradle>,
> > >>>>> should the `repo` , `userOrg` and `vcsUrl` variables be changed
> too ?
> > >>>> These
> > >>>>> will help with subsequent updates to fineract-cn-api,
> > >>>>> fineract-cn-cassandra, etc.
> > >>>> Oops! Good catch. We can delete the bintray section in that
> > >>>> build.gradlel file until we're ready to introduce the use of the
> > >>>> apache artifactory. I don't think you'll find a section like that
> in
> > >>>> any other fineract cn project. I was experimenting there.
> > >>>>
> > >>>> Thank you for taking this on Isaac,
> > >>>> Myrle
> > >>>>
> > >>>
> >
> >
>
Re: Getting started on Fineract CN
Posted by Myrle Krantz <my...@apache.org>.
Oops. Do what Phil says. He knows better.
Greets,
Myrle
On Thu 1. Mar 2018 at 19:43 Phil Steitz <ph...@gmail.com> wrote:
> On 3/1/18 10:34 AM, Myrle Krantz wrote:
> > Hey Isaac,
> >
> > At a first glance, it looks good. May I ask though why you removed
> > the license parameter strictCheck?
> >
> > Regards,
> > Myrle
>
> The copyright statement should be removed entirely from the source
> header files and placed instead in NOTICE.txt.
>
> See http://www.apache.org/legal/src-headers.html
>
> Phil
> >
> > On Thu, Mar 1, 2018 at 5:27 PM, Isaac Kamga <is...@mifos.org>
> wrote:
> >> Hi Myrle,
> >>
> >> I've just updated copyright information in fineract-cn-lang and created
> a
> >> new pull request <https://github.com/apache/fineract-cn-lang/pull/4>.
> >>
> >> I patiently await your review and possible merger.
> >>
> >> At Your Service,
> >> Isaac Kamga.
> >>
> >> On Thu, Mar 1, 2018 at 5:05 PM, Isaac Kamga <is...@mifos.org>
> wrote:
> >>
> >>> Hi Myrle,
> >>>
> >>> Thanks a million for your advice and guidance on this.
> >>>
> >>> I've closed the Pull Request, will do appropriate changes and send in
> >>> another for review.
> >>>
> >>> At Your Service,
> >>> Isaac Kamga.
> >>>
> >>> On Thu, Mar 1, 2018 at 4:56 PM, Myrle Krantz <my...@apache.org> wrote:
> >>>
> >>>> Hey Isaac,
> >>>>
> >>>> Replies inline:
> >>>>
> >>>> On Thu, Mar 1, 2018 at 1:20 PM, Isaac Kamga <is...@mifos.org>
> >>>> wrote:
> >>>>> I have just updated the copyright information and package name on the
> >>>>> fineract-cn-lang repository and sent in another pull request
> >>>>> <https://github.com/apache/fineract-cn-lang/pull/3> for review.
> >>>> Please make a pull request with *just* the copyright information
> >>>> adjusted. Changing package names is a backwards incompatible change.
> >>>> By changing them, you break everything that depends on lang. And all
> >>>> of the other fineract cn repositories depend on lang. Package names
> >>>> will have to be changed in all the repositories at once.
> >>>>
> >>>> We will have to continue to be careful about backwards compatible
> >>>> changes until we have three things:
> >>>> * signature checking
> >>>> * our artifacts in an artifactory
> >>>> * an established process of incrementing versions.
> >>>>
> >>>> Because changing package names is a global change and changing
> >>>> copyright information can be done locally, one repository at a time, I
> >>>> believe we should adjust the copyright information first.
> >>>>
> >>>>> On a related note, I'd like to ask experienced developers on Fineract
> >>>> CN if
> >>>>> it would be necessary to change the project's name ( from *lang* to
> >>>>> *fineract-cn-lang* ) in the settings.gradle
> >>>>> <https://github.com/apache/fineract-cn-lang/blob/develop/set
> >>>> tings.gradle>
> >>>>> file.
> >>>> I don't see any reason to change those names. the project's name is
> >>>> appended to the artifact id. If we did this, the artifact id in this
> >>>> case would be org.apache.fineract.cn.fineract-cn-lang. It would
> >>>> contain duplicated information. Of course we could adjust the build
> >>>> elsewhere to change the artifact id back to lang. But i don't see a
> >>>> benefit in changing the project name.
> >>>>
> >>>> But perhaps I'm missing something here?
> >>>>
> >>>>> Also, in the bintray.pkg section of the build.gradle file
> >>>>> <
> https://github.com/apache/fineract-cn-lang/blob/develop/build.gradle>,
> >>>>> should the `repo` , `userOrg` and `vcsUrl` variables be changed too ?
> >>>> These
> >>>>> will help with subsequent updates to fineract-cn-api,
> >>>>> fineract-cn-cassandra, etc.
> >>>> Oops! Good catch. We can delete the bintray section in that
> >>>> build.gradlel file until we're ready to introduce the use of the
> >>>> apache artifactory. I don't think you'll find a section like that in
> >>>> any other fineract cn project. I was experimenting there.
> >>>>
> >>>> Thank you for taking this on Isaac,
> >>>> Myrle
> >>>>
> >>>
>
>
Re: Getting started on Fineract CN
Posted by Phil Steitz <ph...@gmail.com>.
On 3/1/18 10:34 AM, Myrle Krantz wrote:
> Hey Isaac,
>
> At a first glance, it looks good. May I ask though why you removed
> the license parameter strictCheck?
>
> Regards,
> Myrle
The copyright statement should be removed entirely from the source
header files and placed instead in NOTICE.txt.
See http://www.apache.org/legal/src-headers.html
Phil
>
> On Thu, Mar 1, 2018 at 5:27 PM, Isaac Kamga <is...@mifos.org> wrote:
>> Hi Myrle,
>>
>> I've just updated copyright information in fineract-cn-lang and created a
>> new pull request <https://github.com/apache/fineract-cn-lang/pull/4>.
>>
>> I patiently await your review and possible merger.
>>
>> At Your Service,
>> Isaac Kamga.
>>
>> On Thu, Mar 1, 2018 at 5:05 PM, Isaac Kamga <is...@mifos.org> wrote:
>>
>>> Hi Myrle,
>>>
>>> Thanks a million for your advice and guidance on this.
>>>
>>> I've closed the Pull Request, will do appropriate changes and send in
>>> another for review.
>>>
>>> At Your Service,
>>> Isaac Kamga.
>>>
>>> On Thu, Mar 1, 2018 at 4:56 PM, Myrle Krantz <my...@apache.org> wrote:
>>>
>>>> Hey Isaac,
>>>>
>>>> Replies inline:
>>>>
>>>> On Thu, Mar 1, 2018 at 1:20 PM, Isaac Kamga <is...@mifos.org>
>>>> wrote:
>>>>> I have just updated the copyright information and package name on the
>>>>> fineract-cn-lang repository and sent in another pull request
>>>>> <https://github.com/apache/fineract-cn-lang/pull/3> for review.
>>>> Please make a pull request with *just* the copyright information
>>>> adjusted. Changing package names is a backwards incompatible change.
>>>> By changing them, you break everything that depends on lang. And all
>>>> of the other fineract cn repositories depend on lang. Package names
>>>> will have to be changed in all the repositories at once.
>>>>
>>>> We will have to continue to be careful about backwards compatible
>>>> changes until we have three things:
>>>> * signature checking
>>>> * our artifacts in an artifactory
>>>> * an established process of incrementing versions.
>>>>
>>>> Because changing package names is a global change and changing
>>>> copyright information can be done locally, one repository at a time, I
>>>> believe we should adjust the copyright information first.
>>>>
>>>>> On a related note, I'd like to ask experienced developers on Fineract
>>>> CN if
>>>>> it would be necessary to change the project's name ( from *lang* to
>>>>> *fineract-cn-lang* ) in the settings.gradle
>>>>> <https://github.com/apache/fineract-cn-lang/blob/develop/set
>>>> tings.gradle>
>>>>> file.
>>>> I don't see any reason to change those names. the project's name is
>>>> appended to the artifact id. If we did this, the artifact id in this
>>>> case would be org.apache.fineract.cn.fineract-cn-lang. It would
>>>> contain duplicated information. Of course we could adjust the build
>>>> elsewhere to change the artifact id back to lang. But i don't see a
>>>> benefit in changing the project name.
>>>>
>>>> But perhaps I'm missing something here?
>>>>
>>>>> Also, in the bintray.pkg section of the build.gradle file
>>>>> <https://github.com/apache/fineract-cn-lang/blob/develop/build.gradle>,
>>>>> should the `repo` , `userOrg` and `vcsUrl` variables be changed too ?
>>>> These
>>>>> will help with subsequent updates to fineract-cn-api,
>>>>> fineract-cn-cassandra, etc.
>>>> Oops! Good catch. We can delete the bintray section in that
>>>> build.gradlel file until we're ready to introduce the use of the
>>>> apache artifactory. I don't think you'll find a section like that in
>>>> any other fineract cn project. I was experimenting there.
>>>>
>>>> Thank you for taking this on Isaac,
>>>> Myrle
>>>>
>>>
Re: Getting started on Fineract CN
Posted by Myrle Krantz <my...@apache.org>.
Hey Isaac,
At a first glance, it looks good. May I ask though why you removed
the license parameter strictCheck?
Regards,
Myrle
On Thu, Mar 1, 2018 at 5:27 PM, Isaac Kamga <is...@mifos.org> wrote:
> Hi Myrle,
>
> I've just updated copyright information in fineract-cn-lang and created a
> new pull request <https://github.com/apache/fineract-cn-lang/pull/4>.
>
> I patiently await your review and possible merger.
>
> At Your Service,
> Isaac Kamga.
>
> On Thu, Mar 1, 2018 at 5:05 PM, Isaac Kamga <is...@mifos.org> wrote:
>
>> Hi Myrle,
>>
>> Thanks a million for your advice and guidance on this.
>>
>> I've closed the Pull Request, will do appropriate changes and send in
>> another for review.
>>
>> At Your Service,
>> Isaac Kamga.
>>
>> On Thu, Mar 1, 2018 at 4:56 PM, Myrle Krantz <my...@apache.org> wrote:
>>
>>> Hey Isaac,
>>>
>>> Replies inline:
>>>
>>> On Thu, Mar 1, 2018 at 1:20 PM, Isaac Kamga <is...@mifos.org>
>>> wrote:
>>> > I have just updated the copyright information and package name on the
>>> > fineract-cn-lang repository and sent in another pull request
>>> > <https://github.com/apache/fineract-cn-lang/pull/3> for review.
>>>
>>> Please make a pull request with *just* the copyright information
>>> adjusted. Changing package names is a backwards incompatible change.
>>> By changing them, you break everything that depends on lang. And all
>>> of the other fineract cn repositories depend on lang. Package names
>>> will have to be changed in all the repositories at once.
>>>
>>> We will have to continue to be careful about backwards compatible
>>> changes until we have three things:
>>> * signature checking
>>> * our artifacts in an artifactory
>>> * an established process of incrementing versions.
>>>
>>> Because changing package names is a global change and changing
>>> copyright information can be done locally, one repository at a time, I
>>> believe we should adjust the copyright information first.
>>>
>>> > On a related note, I'd like to ask experienced developers on Fineract
>>> CN if
>>> > it would be necessary to change the project's name ( from *lang* to
>>> > *fineract-cn-lang* ) in the settings.gradle
>>> > <https://github.com/apache/fineract-cn-lang/blob/develop/set
>>> tings.gradle>
>>> > file.
>>>
>>> I don't see any reason to change those names. the project's name is
>>> appended to the artifact id. If we did this, the artifact id in this
>>> case would be org.apache.fineract.cn.fineract-cn-lang. It would
>>> contain duplicated information. Of course we could adjust the build
>>> elsewhere to change the artifact id back to lang. But i don't see a
>>> benefit in changing the project name.
>>>
>>> But perhaps I'm missing something here?
>>>
>>> > Also, in the bintray.pkg section of the build.gradle file
>>> > <https://github.com/apache/fineract-cn-lang/blob/develop/build.gradle>,
>>> > should the `repo` , `userOrg` and `vcsUrl` variables be changed too ?
>>> These
>>> > will help with subsequent updates to fineract-cn-api,
>>> > fineract-cn-cassandra, etc.
>>>
>>> Oops! Good catch. We can delete the bintray section in that
>>> build.gradlel file until we're ready to introduce the use of the
>>> apache artifactory. I don't think you'll find a section like that in
>>> any other fineract cn project. I was experimenting there.
>>>
>>> Thank you for taking this on Isaac,
>>> Myrle
>>>
>>
>>
Re: Getting started on Fineract CN
Posted by Isaac Kamga <is...@mifos.org>.
Hi Myrle,
I've just updated copyright information in fineract-cn-lang and created a
new pull request <https://github.com/apache/fineract-cn-lang/pull/4>.
I patiently await your review and possible merger.
At Your Service,
Isaac Kamga.
On Thu, Mar 1, 2018 at 5:05 PM, Isaac Kamga <is...@mifos.org> wrote:
> Hi Myrle,
>
> Thanks a million for your advice and guidance on this.
>
> I've closed the Pull Request, will do appropriate changes and send in
> another for review.
>
> At Your Service,
> Isaac Kamga.
>
> On Thu, Mar 1, 2018 at 4:56 PM, Myrle Krantz <my...@apache.org> wrote:
>
>> Hey Isaac,
>>
>> Replies inline:
>>
>> On Thu, Mar 1, 2018 at 1:20 PM, Isaac Kamga <is...@mifos.org>
>> wrote:
>> > I have just updated the copyright information and package name on the
>> > fineract-cn-lang repository and sent in another pull request
>> > <https://github.com/apache/fineract-cn-lang/pull/3> for review.
>>
>> Please make a pull request with *just* the copyright information
>> adjusted. Changing package names is a backwards incompatible change.
>> By changing them, you break everything that depends on lang. And all
>> of the other fineract cn repositories depend on lang. Package names
>> will have to be changed in all the repositories at once.
>>
>> We will have to continue to be careful about backwards compatible
>> changes until we have three things:
>> * signature checking
>> * our artifacts in an artifactory
>> * an established process of incrementing versions.
>>
>> Because changing package names is a global change and changing
>> copyright information can be done locally, one repository at a time, I
>> believe we should adjust the copyright information first.
>>
>> > On a related note, I'd like to ask experienced developers on Fineract
>> CN if
>> > it would be necessary to change the project's name ( from *lang* to
>> > *fineract-cn-lang* ) in the settings.gradle
>> > <https://github.com/apache/fineract-cn-lang/blob/develop/set
>> tings.gradle>
>> > file.
>>
>> I don't see any reason to change those names. the project's name is
>> appended to the artifact id. If we did this, the artifact id in this
>> case would be org.apache.fineract.cn.fineract-cn-lang. It would
>> contain duplicated information. Of course we could adjust the build
>> elsewhere to change the artifact id back to lang. But i don't see a
>> benefit in changing the project name.
>>
>> But perhaps I'm missing something here?
>>
>> > Also, in the bintray.pkg section of the build.gradle file
>> > <https://github.com/apache/fineract-cn-lang/blob/develop/build.gradle>,
>> > should the `repo` , `userOrg` and `vcsUrl` variables be changed too ?
>> These
>> > will help with subsequent updates to fineract-cn-api,
>> > fineract-cn-cassandra, etc.
>>
>> Oops! Good catch. We can delete the bintray section in that
>> build.gradlel file until we're ready to introduce the use of the
>> apache artifactory. I don't think you'll find a section like that in
>> any other fineract cn project. I was experimenting there.
>>
>> Thank you for taking this on Isaac,
>> Myrle
>>
>
>
Re: Getting started on Fineract CN
Posted by Isaac Kamga <is...@mifos.org>.
Hi Myrle,
Thanks a million for your advice and guidance on this.
I've closed the Pull Request, will do appropriate changes and send in
another for review.
At Your Service,
Isaac Kamga.
On Thu, Mar 1, 2018 at 4:56 PM, Myrle Krantz <my...@apache.org> wrote:
> Hey Isaac,
>
> Replies inline:
>
> On Thu, Mar 1, 2018 at 1:20 PM, Isaac Kamga <is...@mifos.org> wrote:
> > I have just updated the copyright information and package name on the
> > fineract-cn-lang repository and sent in another pull request
> > <https://github.com/apache/fineract-cn-lang/pull/3> for review.
>
> Please make a pull request with *just* the copyright information
> adjusted. Changing package names is a backwards incompatible change.
> By changing them, you break everything that depends on lang. And all
> of the other fineract cn repositories depend on lang. Package names
> will have to be changed in all the repositories at once.
>
> We will have to continue to be careful about backwards compatible
> changes until we have three things:
> * signature checking
> * our artifacts in an artifactory
> * an established process of incrementing versions.
>
> Because changing package names is a global change and changing
> copyright information can be done locally, one repository at a time, I
> believe we should adjust the copyright information first.
>
> > On a related note, I'd like to ask experienced developers on Fineract CN
> if
> > it would be necessary to change the project's name ( from *lang* to
> > *fineract-cn-lang* ) in the settings.gradle
> > <https://github.com/apache/fineract-cn-lang/blob/develop/settings.gradle
> >
> > file.
>
> I don't see any reason to change those names. the project's name is
> appended to the artifact id. If we did this, the artifact id in this
> case would be org.apache.fineract.cn.fineract-cn-lang. It would
> contain duplicated information. Of course we could adjust the build
> elsewhere to change the artifact id back to lang. But i don't see a
> benefit in changing the project name.
>
> But perhaps I'm missing something here?
>
> > Also, in the bintray.pkg section of the build.gradle file
> > <https://github.com/apache/fineract-cn-lang/blob/develop/build.gradle>,
> > should the `repo` , `userOrg` and `vcsUrl` variables be changed too ?
> These
> > will help with subsequent updates to fineract-cn-api,
> > fineract-cn-cassandra, etc.
>
> Oops! Good catch. We can delete the bintray section in that
> build.gradlel file until we're ready to introduce the use of the
> apache artifactory. I don't think you'll find a section like that in
> any other fineract cn project. I was experimenting there.
>
> Thank you for taking this on Isaac,
> Myrle
>
Re: Getting started on Fineract CN
Posted by Myrle Krantz <my...@apache.org>.
Hey Isaac,
Replies inline:
On Thu, Mar 1, 2018 at 1:20 PM, Isaac Kamga <is...@mifos.org> wrote:
> I have just updated the copyright information and package name on the
> fineract-cn-lang repository and sent in another pull request
> <https://github.com/apache/fineract-cn-lang/pull/3> for review.
Please make a pull request with *just* the copyright information
adjusted. Changing package names is a backwards incompatible change.
By changing them, you break everything that depends on lang. And all
of the other fineract cn repositories depend on lang. Package names
will have to be changed in all the repositories at once.
We will have to continue to be careful about backwards compatible
changes until we have three things:
* signature checking
* our artifacts in an artifactory
* an established process of incrementing versions.
Because changing package names is a global change and changing
copyright information can be done locally, one repository at a time, I
believe we should adjust the copyright information first.
> On a related note, I'd like to ask experienced developers on Fineract CN if
> it would be necessary to change the project's name ( from *lang* to
> *fineract-cn-lang* ) in the settings.gradle
> <https://github.com/apache/fineract-cn-lang/blob/develop/settings.gradle>
> file.
I don't see any reason to change those names. the project's name is
appended to the artifact id. If we did this, the artifact id in this
case would be org.apache.fineract.cn.fineract-cn-lang. It would
contain duplicated information. Of course we could adjust the build
elsewhere to change the artifact id back to lang. But i don't see a
benefit in changing the project name.
But perhaps I'm missing something here?
> Also, in the bintray.pkg section of the build.gradle file
> <https://github.com/apache/fineract-cn-lang/blob/develop/build.gradle>,
> should the `repo` , `userOrg` and `vcsUrl` variables be changed too ? These
> will help with subsequent updates to fineract-cn-api,
> fineract-cn-cassandra, etc.
Oops! Good catch. We can delete the bintray section in that
build.gradlel file until we're ready to introduce the use of the
apache artifactory. I don't think you'll find a section like that in
any other fineract cn project. I was experimenting there.
Thank you for taking this on Isaac,
Myrle