You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/03/01 06:31:34 UTC
[kudu-CR] KUDU-1341 (part 1): improve tablet_random-access-test to be a full integration test
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1341 (part 1): improve tablet_random-access-test to be a full integration test
......................................................................
Patch Set 1:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/2346/1/src/kudu/integration-tests/fuzz-itest.cc
File src/kudu/integration-tests/fuzz-itest.cc:
Line 48: enum TestOp {
doc
Line 112:
extra line
Line 244: void GenerateTestCase(vector<TestOp>* ops, int len) {
doc
Line 336: int update_multiplier = 1) {
align
Line 337: LOG(INFO) << "test case: " << DumpTestCase(test_ops);
more info or remove?
Line 347: LOG(INFO) << TestOp_names[test_op];
did you mean to leave this? vlog maybe?
Line 431: // A particular test case which previously failed TestFuzz.
if you're not going to describe what this does maybe its not worth repeating in every test
--
To view, visit http://gerrit.cloudera.org:8080/2346
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a60436461facbeb39aa4ff5f7b2ba1c2b7a230c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes