You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/07/15 23:48:05 UTC

[GitHub] [incubator-gobblin] autumnust opened a new pull request #3062: [GOBBLIN-1214] Move the fallback of in-eligible shuffleKey to driver

autumnust opened a new pull request #3062:
URL: https://github.com/apache/incubator-gobblin/pull/3062


   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1214
   
   
   ### Description
   Before this change, when a user-specified shuffle-key is not eligible ( e.g. the field in the shuffle doesn't exist in the data schema), the fallback is not working properly as the OrcKeyComparator is still using the shuffle-key specified in jobConfigurator. It ends up with failure in deserialization from byteArray into in-memory ORC row-object. 
   
   This change makes the detection of eligibility happen in the driver level, so that within `OrcValueMapper` the fallback of shuffleKey is transparent. 
   
   Added a unit test for that which would be failing before.
   
   Also rename the `mrOutputSchema` to `mrInputSchema` for the accuracy. This indeed breaks the atomicity of this commit but it is overall relevant. 
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-gobblin] autumnust commented on pull request #3062: [GOBBLIN-1214] Move the fallback of in-eligible shuffleKey to driver

Posted by GitBox <gi...@apache.org>.
autumnust commented on pull request #3062:
URL: https://github.com/apache/incubator-gobblin/pull/3062#issuecomment-659078289


   > LGTM, just double check that job.getConfiguration() will be used to set conf for OrcKeyComparator right?
   
   do you mean "get conf for " ? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-gobblin] asfgit closed pull request #3062: [GOBBLIN-1214] Move the fallback of in-eligible shuffleKey to driver

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3062:
URL: https://github.com/apache/incubator-gobblin/pull/3062


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-gobblin] autumnust closed pull request #3062: [GOBBLIN-1214] Move the fallback of in-eligible shuffleKey to driver

Posted by GitBox <gi...@apache.org>.
autumnust closed pull request #3062:
URL: https://github.com/apache/incubator-gobblin/pull/3062


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-gobblin] ZihanLi58 commented on pull request #3062: [GOBBLIN-1214] Move the fallback of in-eligible shuffleKey to driver

Posted by GitBox <gi...@apache.org>.
ZihanLi58 commented on pull request #3062:
URL: https://github.com/apache/incubator-gobblin/pull/3062#issuecomment-659083308


   > > LGTM, just double check that job.getConfiguration() will be used to set conf for OrcKeyComparator right?
   > 
   > do you mean "get conf for " ?
   Yes, please also check the travis build failure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org