[GitHub] [hbase] Joseph295 commented on a change in pull request #1509: HBASE-24182 log when the region is set to closing status

[GitBox <gi...@apache.org>]

Joseph295 commented on a change in pull request #1509: HBASE-24182 log when the region is set to closing status
URL: https://github.com/apache/hbase/pull/1509#discussion_r410191375
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
 ##########
 @@ -1655,6 +1655,7 @@ public void setTimeoutForWriteLock(long timeoutForWriteLock) {
       }
     }
     this.closing.set(true);
+    LOG.info("Closing {}", this);
 
 Review comment:
   > @Joseph295 Can you change this to "Closing region {}"? `this` is anyways going to print region name as string only.
   
   I think the discussion above really makes sense, so do you guys think we add this log any more? maybe for debug level is enough? We only need it if we concern about the closing cost time for debug? Anyway, let me fix the format for that, any suggestion is welcome. Thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services