You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/26 07:43:39 UTC

[GitHub] [apisix] guoqqqi opened a new pull request #3685: docs: Added title to markdown under `docs`

guoqqqi opened a new pull request #3685:
URL: https://github.com/apache/apisix/pull/3685


   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [x] Have you modified the corresponding document?
   * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
   
   Added title to markdown under docs
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #3685: docs: Added title to markdown under `docs`

Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #3685:
URL: https://github.com/apache/apisix/pull/3685#discussion_r583446692



##########
File path: docs/zh/latest/benchmark.md
##########
@@ -1,3 +1,7 @@
+---
+title: 测试

Review comment:
       benchmark is not test.

##########
File path: docs/en/latest/plugins/response-rewrite.md
##########
@@ -1,3 +1,7 @@
+---
+title: response rewrite

Review comment:
       Should be `response-rewrite`?
   Please update other similar places.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] juzhiyuan merged pull request #3685: docs: Added title to markdown under `docs`

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #3685:
URL: https://github.com/apache/apisix/pull/3685


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #3685: docs: Added title to markdown under `docs`

Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #3685:
URL: https://github.com/apache/apisix/pull/3685#discussion_r583459971



##########
File path: docs/zh/latest/benchmark.md
##########
@@ -1,5 +1,5 @@
 ---
-title: 测试
+title: 基准

Review comment:
       Should be `基准测试`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org