You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/03/13 18:47:44 UTC
[kudu-CR](branch-1.7.x) KUDU-2322: don't spew logs about behind-log-GC follower
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9609
Change subject: KUDU-2322: don't spew logs about behind-log-GC follower
......................................................................
KUDU-2322: don't spew logs about behind-log-GC follower
This patch addresses the issue of a leader spewing a lot of INFO
log messages about missing logs segments for a follower that falls
behind log GC. In the 3-4-3 replica management scheme, such followers
linger around until corresponding non-voter replica catches up with
the leader. That might take long time.
With this patch, the leader throttles messages about missing log
segments for a behind-log-GC follower, outputting 1 message per minute.
Change-Id: I4438e63aef0be26c149c57f9f58cb54327e41a33
Reviewed-on: http://gerrit.cloudera.org:8080/9573
Reviewed-by: Todd Lipcon <to...@apache.org>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit d856107e0b58067f0bbebbbda52f4f67c674897a)
---
M src/kudu/consensus/consensus-test-util.h
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
M src/kudu/util/logging.h
5 files changed, 36 insertions(+), 26 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/9609/1
--
To view, visit http://gerrit.cloudera.org:8080/9609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4438e63aef0be26c149c57f9f58cb54327e41a33
Gerrit-Change-Number: 9609
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR](branch-1.7.x) KUDU-2322: don't spew logs about behind-log-GC follower
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9609 )
Change subject: KUDU-2322: don't spew logs about behind-log-GC follower
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I4438e63aef0be26c149c57f9f58cb54327e41a33
Gerrit-Change-Number: 9609
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 13 Mar 2018 21:19:18 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.7.x) KUDU-2322: don't spew logs about behind-log-GC follower
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9609 )
Change subject: KUDU-2322: don't spew logs about behind-log-GC follower
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I4438e63aef0be26c149c57f9f58cb54327e41a33
Gerrit-Change-Number: 9609
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 13 Mar 2018 18:48:14 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.7.x) KUDU-2322: don't spew logs about behind-log-GC follower
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: KUDU-2322: don't spew logs about behind-log-GC follower
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/9609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I4438e63aef0be26c149c57f9f58cb54327e41a33
Gerrit-Change-Number: 9609
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](branch-1.7.x) KUDU-2322: don't spew logs about behind-log-GC follower
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9609 )
Change subject: KUDU-2322: don't spew logs about behind-log-GC follower
......................................................................
KUDU-2322: don't spew logs about behind-log-GC follower
This patch addresses the issue of a leader spewing a lot of INFO
log messages about missing logs segments for a follower that falls
behind log GC. In the 3-4-3 replica management scheme, such followers
linger around until corresponding non-voter replica catches up with
the leader. That might take long time.
With this patch, the leader throttles messages about missing log
segments for a behind-log-GC follower, outputting 1 message per minute.
Change-Id: I4438e63aef0be26c149c57f9f58cb54327e41a33
Reviewed-on: http://gerrit.cloudera.org:8080/9573
Reviewed-by: Todd Lipcon <to...@apache.org>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit d856107e0b58067f0bbebbbda52f4f67c674897a)
Reviewed-on: http://gerrit.cloudera.org:8080/9609
Tested-by: Grant Henke <gr...@gmail.com>
---
M src/kudu/consensus/consensus-test-util.h
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
M src/kudu/util/logging.h
5 files changed, 36 insertions(+), 26 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Grant Henke: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I4438e63aef0be26c149c57f9f58cb54327e41a33
Gerrit-Change-Number: 9609
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins