You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/23 21:30:01 UTC
[GitHub] [incubator-superset] john-bodley opened a new pull request #9006:
[fix] pydruid export_pandas
john-bodley opened a new pull request #9006: [fix] pydruid export_pandas
URL: https://github.com/apache/incubator-superset/pull/9006
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
This PR fixes a regression introduced in https://github.com/apache/incubator-superset/pull/8948 where I mistook that the `pydruid` `export_pandas` method alway returned an `pd.DataFrame` object (I missed the if statement [here](https://github.com/druid-io/pydruid/blob/80cf6fe767817c8c30e908ea2e145bee09aa6d9b/pydruid/query.py#L164) and thus it could be `None`.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
CI.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
to: @michellethomas @mistercrunch @villebro
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #9006: [fix]
pydruid export_pandas
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #9006: [fix] pydruid export_pandas
URL: https://github.com/apache/incubator-superset/pull/9006#issuecomment-577891033
No plans, but I think it depends on deprecating support for py<3.5, which is about time. Happy to review/merge in that direction
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley merged pull request #9006: [fix]
pydruid export_pandas
Posted by GitBox <gi...@apache.org>.
john-bodley merged pull request #9006: [fix] pydruid export_pandas
URL: https://github.com/apache/incubator-superset/pull/9006
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on issue #9006: [fix]
pydruid export_pandas
Posted by GitBox <gi...@apache.org>.
john-bodley commented on issue #9006: [fix] pydruid export_pandas
URL: https://github.com/apache/incubator-superset/pull/9006#issuecomment-577887592
@mistercrunch do you know if there are any plans to add typing to `pydruid`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9006: [fix]
pydruid export_pandas
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9006: [fix] pydruid export_pandas
URL: https://github.com/apache/incubator-superset/pull/9006#issuecomment-577915487
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9006?src=pr&el=h1) Report
> Merging [#9006](https://codecov.io/gh/apache/incubator-superset/pull/9006?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/04be1d4b422648f5a7744bd753f8481d2f2f135f?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9006?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9006 +/- ##
=======================================
Coverage 59.16% 59.16%
=======================================
Files 367 367
Lines 11680 11680
Branches 2863 2863
=======================================
Hits 6910 6910
Misses 4591 4591
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9006?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9006?src=pr&el=footer). Last update [04be1d4...ce848d1](https://codecov.io/gh/apache/incubator-superset/pull/9006?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org