Review Request 69751: CMake: Disabled "local" clusters in the scheduler libraries.

[Joseph Wu <jo...@mesosphere.io>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69751/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Till Toenshoff.


Repository: mesos


Description
-------

This removes the ability to specify a "local" master in the scheduler
libraries, which subsequently spawns a master and agent.
The consequence of the local cluster is that the scheduler library
is currently required to include the entire master and agent source
tree to instantiate a master/agent in the process.  This dramatically
increases the build cost of this library, but only provides an
oft-unused bit of functionality.

The example framework tests are disabled temporarily because these
tests require the "local" cluster feature.


Diffs
-----

  src/sched/sched.cpp e77a02951831a7e0c5d9a9068f8d014cb1478382 
  src/scheduler/scheduler.cpp cb24ba9c8e1d04b8c62bdf07b12758a61b3bf036 
  src/tests/CMakeLists.txt 7a1265e38e5e3b3a102862d231fc78adae14c4fe 


Diff: https://reviews.apache.org/r/69751/diff/1/


Testing
-------

cmake --build .

The longer term fix for the examples tests is to rewrite them.  The example tests currently use the `TEST_SCRIPT` macro, which launches a script, which launches the framework.  Instead, we can write a normal unit test (MesosTest) which launches the framework directly.  The test itself can launch any required masters/agents.  A rewrite like this would have the benefit of greater control over the example tests, which currently only check if the script succeeds.

Once done, we can consider deleting the "local" cluster code entirely.


Thanks,

Joseph Wu