[GitHub] [superset] etr2460 commented on a change in pull request #16454: feat: add certifiedby & certification details fields to the edit dataset columns fields

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #16454:
URL: https://github.com/apache/superset/pull/16454#discussion_r699740203



##########
File path: superset-frontend/src/datasource/DatasourceModal.tsx
##########
@@ -64,17 +64,17 @@ interface DatasourceModalProps {
   show: boolean;
 }
 
-function buildMetricExtraJsonObject(metric: Record<string, unknown>) {
+function buildExtraJsonObjects(item: Record<string, unknown>) {

Review comment:
       cool refactor, maybe name `buildExtraJsonObject` though since it only returns 1 object?

##########
File path: UPDATING.md
##########
@@ -25,31 +25,37 @@ assists people when migrating to a new version.
 ## Next
 
 ### Breaking Changes
+

Review comment:
       looks like we got some autogenerated changes here. maybe we should move those into another pr (if we think they're desirable?) 

##########
File path: superset/connectors/sqla/models.py
##########
@@ -267,6 +269,28 @@ def get_sqla_col(self, label: Optional[str] = None) -> Column:
     def datasource(self) -> RelationshipProperty:
         return self.table
 
+    def get_extra_dict(self) -> Dict[str, Any]:

Review comment:
       this is copy pasted from the metric model right? Maybe we can have a `CertifiableMixin` that both models can use?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org