svn commit: r1810317 - in /felix/sandbox/cziegeler/osgicheck-maven-plugin/src/main/java/org/apache/felix/maven/osgicheck/impl: CheckMojo.java checks/ImportExportCheck.java checks/SCRCheck.java

[cz...@apache.org]

Author: cziegeler
Date: Mon Oct  2 09:21:16 2017
New Revision: 1810317

URL: http://svn.apache.org/viewvc?rev=1810317&view=rev
Log:
Code clean up

Modified:
    felix/sandbox/cziegeler/osgicheck-maven-plugin/src/main/java/org/apache/felix/maven/osgicheck/impl/CheckMojo.java
    felix/sandbox/cziegeler/osgicheck-maven-plugin/src/main/java/org/apache/felix/maven/osgicheck/impl/checks/ImportExportCheck.java
    felix/sandbox/cziegeler/osgicheck-maven-plugin/src/main/java/org/apache/felix/maven/osgicheck/impl/checks/SCRCheck.java

Modified: felix/sandbox/cziegeler/osgicheck-maven-plugin/src/main/java/org/apache/felix/maven/osgicheck/impl/CheckMojo.java
URL: http://svn.apache.org/viewvc/felix/sandbox/cziegeler/osgicheck-maven-plugin/src/main/java/org/apache/felix/maven/osgicheck/impl/CheckMojo.java?rev=1810317&r1=1810316&r2=1810317&view=diff
==============================================================================
--- felix/sandbox/cziegeler/osgicheck-maven-plugin/src/main/java/org/apache/felix/maven/osgicheck/impl/CheckMojo.java (original)
+++ felix/sandbox/cziegeler/osgicheck-maven-plugin/src/main/java/org/apache/felix/maven/osgicheck/impl/CheckMojo.java Mon Oct  2 09:21:16 2017
@@ -69,7 +69,10 @@ public class CheckMojo extends AbstractM
     protected Mode mode;
 
     /**
-     * The configuration for the checks
+     * The configuration for the checks - currently not used
+     * The configurations can be specified as a CDATA section with an XML
+     * tree for each check. The root name of the tree is the name of the
+     * check.
      */
     @Parameter
     protected String config;

Modified: felix/sandbox/cziegeler/osgicheck-maven-plugin/src/main/java/org/apache/felix/maven/osgicheck/impl/checks/ImportExportCheck.java
URL: http://svn.apache.org/viewvc/felix/sandbox/cziegeler/osgicheck-maven-plugin/src/main/java/org/apache/felix/maven/osgicheck/impl/checks/ImportExportCheck.java?rev=1810317&r1=1810316&r2=1810317&view=diff
==============================================================================
--- felix/sandbox/cziegeler/osgicheck-maven-plugin/src/main/java/org/apache/felix/maven/osgicheck/impl/checks/ImportExportCheck.java (original)
+++ felix/sandbox/cziegeler/osgicheck-maven-plugin/src/main/java/org/apache/felix/maven/osgicheck/impl/checks/ImportExportCheck.java Mon Oct  2 09:21:16 2017
@@ -26,13 +26,13 @@ import org.apache.maven.plugin.MojoExecu
 import org.osgi.framework.Version;
 
 /**
- * Measures:
+ * The following checks are performed:
  * <ul>
- *   <li>Exports without a version
- *   <li>Import without a version (range)
- *   <li>Dynamic import without a version (range)
- *   <li>Dynamic import *
- *   <li>Export of privat looking package
+ *   <li>Exports without a version (ERROR)
+ *   <li>Import without a version (range) (WARNING)
+ *   <li>Dynamic import without a version (range) (WARNING)
+ *   <li>Dynamic import * (WARNING)
+ *   <li>Export of private looking package (WARNING)
  * </ul>
  */
 public class ImportExportCheck implements Check {

Modified: felix/sandbox/cziegeler/osgicheck-maven-plugin/src/main/java/org/apache/felix/maven/osgicheck/impl/checks/SCRCheck.java
URL: http://svn.apache.org/viewvc/felix/sandbox/cziegeler/osgicheck-maven-plugin/src/main/java/org/apache/felix/maven/osgicheck/impl/checks/SCRCheck.java?rev=1810317&r1=1810316&r2=1810317&view=diff
==============================================================================
--- felix/sandbox/cziegeler/osgicheck-maven-plugin/src/main/java/org/apache/felix/maven/osgicheck/impl/checks/SCRCheck.java (original)
+++ felix/sandbox/cziegeler/osgicheck-maven-plugin/src/main/java/org/apache/felix/maven/osgicheck/impl/checks/SCRCheck.java Mon Oct  2 09:21:16 2017
@@ -48,10 +48,9 @@ import org.osgi.framework.Version;
 import org.osgi.service.component.ComponentException;
 
 /**
- * Measure
+ * The following checks are performed
  * <ul>
  *   <li>Immediate flag
- *   <li>Metatype (TODO)
  *   <li>Unary references should be greedy
  *   <li>References ordering (Not finished yet)
  * </ul>
@@ -91,8 +90,8 @@ public class SCRCheck implements Check {
     /**
      * Check the immediate flag
      * <ul>
-     *   <li>If a component it must not be declared (Error)
-     *   <li>If a service it should not be declared (Warning)
+     *   <li>If a component: it must not be declared (Error)
+     *   <li>If a service: it should not be declared (Warning)
      * <ul>
      * @param ctx
      * @param md