You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/06/22 11:09:31 UTC
[GitHub] [zeppelin] Reamer opened a new pull request #4146: [ZEPPELIN-5421] Update surefire version
Reamer opened a new pull request #4146:
URL: https://github.com/apache/zeppelin/pull/4146
### What is this PR for?
This PR updates the surefire version to 2.22.2
### What type of PR is it?
- Refactoring
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-5421
### How should this be tested?
* CI
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] huage1994 commented on pull request #4146: [ZEPPELIN-5421] Update surefire version
Posted by GitBox <gi...@apache.org>.
huage1994 commented on pull request #4146:
URL: https://github.com/apache/zeppelin/pull/4146#issuecomment-1072990382
> Hey @huage1994 I think I made it. Could you look over the PR. The main problem was that the `ZeppelinServer` class did not respond to interrupt exception. Also, with the environment variable `ZEPPELIN_IDENT_STRING` was programmed a different behavior of the application (even during the tests).
Oh great! !!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] huage1994 commented on pull request #4146: [ZEPPELIN-5421] Update surefire version
Posted by GitBox <gi...@apache.org>.
huage1994 commented on pull request #4146:
URL: https://github.com/apache/zeppelin/pull/4146#issuecomment-1046019861
> I know, but did you find the corresponding line? Thanks for the maven call, this is definitely very helpful.
AbstractTestRestApi.shutDown(false);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4146: [ZEPPELIN-5421] Update surefire version
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4146:
URL: https://github.com/apache/zeppelin/pull/4146#issuecomment-1072042841
Ci has passed, I will merge this into master if no further comments are received.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] huage1994 commented on pull request #4146: [ZEPPELIN-5421] Update surefire version
Posted by GitBox <gi...@apache.org>.
huage1994 commented on pull request #4146:
URL: https://github.com/apache/zeppelin/pull/4146#issuecomment-1044223470
> Hi @huage1994 my last stand was that I was looking for `System.exit(0)`. But I didn't find the call, did you find the location?
Sorry for the late reply. I didn't notice the github message in email.
I found it failed when I run
`mvn -pl zeppelin-server -Dtest=NotebookRestApiTest#testRunWithServerRestart test`
with plugin.surefire.version 3.0.0-M5.
System.exit is called when shutdown Zeppelin server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4146: [ZEPPELIN-5421] Update surefire version
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4146:
URL: https://github.com/apache/zeppelin/pull/4146#issuecomment-1072042841
Ci has passed, I will merge this into master if no further comments are received.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4146: [ZEPPELIN-5421] Update surefire version
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4146:
URL: https://github.com/apache/zeppelin/pull/4146#issuecomment-1044633658
I know, but did you find the corresponding line?
Thanks for the maven call, this is definitely very helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4146: [ZEPPELIN-5421] Update surefire version
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4146:
URL: https://github.com/apache/zeppelin/pull/4146#issuecomment-866025578
Is the failed test related ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] asfgit closed pull request #4146: [ZEPPELIN-5421] Update surefire version
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4146:
URL: https://github.com/apache/zeppelin/pull/4146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4146: [ZEPPELIN-5421] Update surefire version
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4146:
URL: https://github.com/apache/zeppelin/pull/4146#issuecomment-866069752
> Is the failed test related ?
Yes, but I don't know the source at the moment. Locally, however, I can reproduce it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4146: [ZEPPELIN-5421] Update surefire version
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4146:
URL: https://github.com/apache/zeppelin/pull/4146#issuecomment-1041175980
Hi @huage1994
my last stand was that I was looking for `System.exit(0)`. But I didn't find the call, did you find the location?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] huage1994 edited a comment on pull request #4146: [ZEPPELIN-5421] Update surefire version
Posted by GitBox <gi...@apache.org>.
huage1994 edited a comment on pull request #4146:
URL: https://github.com/apache/zeppelin/pull/4146#issuecomment-1046019861
> I know, but did you find the corresponding line? Thanks for the maven call, this is definitely very helpful.
NotebookRestApiTest.java - line 841
`AbstractTestRestApi.shutDown(false);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] huage1994 edited a comment on pull request #4146: [ZEPPELIN-5421] Update surefire version
Posted by GitBox <gi...@apache.org>.
huage1994 edited a comment on pull request #4146:
URL: https://github.com/apache/zeppelin/pull/4146#issuecomment-1044223470
> Hi @huage1994 my last stand was that I was looking for `System.exit(0)`. But I didn't find the call, did you find the location?
Hi @Reamer. I'm sorry for the late reply. I didn't notice the github message in email.
I found it failed when I run
`mvn -pl zeppelin-server -Dtest=NotebookRestApiTest#testRunWithServerRestart test`
with plugin.surefire.version 3.0.0-M5.
System.exit is called when shutdown Zeppelin server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] huage1994 commented on pull request #4146: [ZEPPELIN-5421] Update surefire version
Posted by GitBox <gi...@apache.org>.
huage1994 commented on pull request #4146:
URL: https://github.com/apache/zeppelin/pull/4146#issuecomment-1041046615
hi @Reamer. I have the same problem when developing for ZEPPELIN-5612.
The reason seems to be that some test case call System.exit().
Do you have any idea how to solve this problem？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] asfgit closed pull request #4146: [ZEPPELIN-5421] Update surefire version
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4146:
URL: https://github.com/apache/zeppelin/pull/4146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4146: [ZEPPELIN-5421] Update surefire version
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4146:
URL: https://github.com/apache/zeppelin/pull/4146#issuecomment-1067094641
Hey @huage1994
I think I made it. Could you look over the PR.
The main problem was that the `ZeppelinServer` class did not respond to interrupt exception.
Also, with the environment variable `ZEPPELIN_IDENT_STRING` was programmed a different behavior of the application (even during the tests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org