You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2022/09/15 05:56:24 UTC

[GitHub] [phoenix] stoty commented on a diff in pull request #1500: PHOENIX-6789 Remove com.sun.istack.NotNull usage

stoty commented on code in PR #1500:
URL: https://github.com/apache/phoenix/pull/1500#discussion_r971555170


##########
pom.xml:
##########
@@ -506,6 +502,13 @@
                       <bannedImport>org.apache.commons.lang.**</bannedImport>
                     </bannedImports>
                   </restrictImports>
+                  <restrictImports implementation="de.skuzzle.enforcer.restrictimports.rule.RestrictImports">
+                    <includeTestCode>true</includeTestCode>
+                    <reason>Use edu.umd.cs.findbugs.annotations</reason>

Review Comment:
   NP, such stuff happens, @dbwong .
   
   AFAIU javax.validation.constraints is for runtime validation, when the constraint is actively checked during runtime. (used mostly by IoC / DI stuff like Spring / Java EE)
   
   Using that here would be confusing, since we only use these annotations to indicate intent, and to help with static code analysis (and I don't think findbugs would even understand that). 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org