You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/20 14:52:21 UTC

[GitHub] [arrow-rs] bmmeijers commented on a diff in pull request #3578: Use native types in PageIndex (#3575)

bmmeijers commented on code in PR #3578:
URL: https://github.com/apache/arrow-rs/pull/3578#discussion_r1082651910


##########
parquet/src/bin/parquet-index.rs:
##########
@@ -132,7 +132,7 @@ fn compute_row_counts(offset_index: &[PageLocation], rows: i64) -> Vec<i64> {
 }
 
 /// Prints index information for a single column chunk
-fn print_index<T: std::fmt::Debug>(
+fn print_index<T: std::fmt::Display>(

Review Comment:
   Would it make sense to format the types for bytearray/fixedlenbytearray with hex layout (using `:x?`) by default?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org