You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/06/05 13:53:08 UTC
[GitHub] [incubator-yunikorn-release] kingamarton opened a new pull request #7: [YUNIKORN-167] Fixed release tool after helm chart related changes
kingamarton opened a new pull request #7:
URL: https://github.com/apache/incubator-yunikorn-release/pull/7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] yangwwei commented on a change in pull request #7: [YUNIKORN-167] Fixed release tool after helm chart related changes
Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #7:
URL: https://github.com/apache/incubator-yunikorn-release/pull/7#discussion_r436077143
##########
File path: docs/release-procedure.md
##########
@@ -91,3 +92,15 @@ Once the voting is passed, move the release artifacts to https://dist.apache.org
Publish an announcement blog to https://blogs.apache.org/yunikorn/, update the web-site with corresponding
release notes, download links.
+
+# Release Helm Charts
+
+After the voting passed and the RC is accepted, release the helm chart
+- Create a release branch for the target release in this release repo
+- Package the charts:
+```shell script
+helm package helm-charts/yunikorn --destination .
Review comment:
can you please include the doc about how to sign a helm-chart-tarball?
##########
File path: tools/build-release.py
##########
@@ -41,19 +42,16 @@ def build_release():
release_base = os.path.join(staging_dir, release_package_name)
release_top_path = os.path.join(os.path.dirname(tools_dir),
"release-top-level-artifacts")
+ helm_chart_path = os.path.join(os.path.dirname(tools_dir),
+ "helm-charts")
Review comment:
the changes for this file seems not enough.
because the helm charts file in this dir is hard-coded to 0.8.
can we add a folder for all helm-chart files, and each released version can have one on its own?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] kingamarton commented on a change in pull request #7: [YUNIKORN-167] Fixed release tool after helm chart related changes
Posted by GitBox <gi...@apache.org>.
kingamarton commented on a change in pull request #7:
URL: https://github.com/apache/incubator-yunikorn-release/pull/7#discussion_r438042198
##########
File path: tools/build-release.py
##########
@@ -41,19 +42,16 @@ def build_release():
release_base = os.path.join(staging_dir, release_package_name)
release_top_path = os.path.join(os.path.dirname(tools_dir),
"release-top-level-artifacts")
+ helm_chart_path = os.path.join(os.path.dirname(tools_dir),
+ "helm-charts")
Review comment:
I changed the version to latest to the helm charts and implemented a version replace for the charts that will be packaged. It will pickup the version from the config file and replace the values from values.yaml and Chart.yaml. Also I removed the index.yaml file, since we don't need it to master branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] yangwwei commented on a change in pull request #7: [YUNIKORN-167] Fixed release tool after helm chart related changes
Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #7:
URL: https://github.com/apache/incubator-yunikorn-release/pull/7#discussion_r437059625
##########
File path: tools/build-release.py
##########
@@ -41,19 +42,16 @@ def build_release():
release_base = os.path.join(staging_dir, release_package_name)
release_top_path = os.path.join(os.path.dirname(tools_dir),
"release-top-level-artifacts")
+ helm_chart_path = os.path.join(os.path.dirname(tools_dir),
+ "helm-charts")
Review comment:
OK, I am good with setting it to the latest.
But when we release a version, e.g next 0.9.0. Our script will copy the helm charts to the release-dir, then our script should be able to replace `latest` to the actual version we are going to release, i.e 0.9.0.
##########
File path: tools/build-release.py
##########
@@ -41,19 +42,16 @@ def build_release():
release_base = os.path.join(staging_dir, release_package_name)
release_top_path = os.path.join(os.path.dirname(tools_dir),
"release-top-level-artifacts")
+ helm_chart_path = os.path.join(os.path.dirname(tools_dir),
+ "helm-charts")
Review comment:
OK, I am good with setting it to the latest.
But when we release a version, e.g next 0.9.0. Our script will copy the helm charts to the release-dir, then our script should be able to replace `latest` to the actual version we are going to release, i.e 0.9.0. I think we have to include the helm-charts in the release tarball because we want users to be able. to install even without the internet connection. Does this make sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] yangwwei commented on a change in pull request #7: [YUNIKORN-167] Fixed release tool after helm chart related changes
Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #7:
URL: https://github.com/apache/incubator-yunikorn-release/pull/7#discussion_r438320922
##########
File path: tools/build-release.py
##########
@@ -41,19 +42,16 @@ def build_release():
release_base = os.path.join(staging_dir, release_package_name)
release_top_path = os.path.join(os.path.dirname(tools_dir),
"release-top-level-artifacts")
+ helm_chart_path = os.path.join(os.path.dirname(tools_dir),
+ "helm-charts")
Review comment:
OK. This also works, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] kingamarton commented on a change in pull request #7: [YUNIKORN-167] Fixed release tool after helm chart related changes
Posted by GitBox <gi...@apache.org>.
kingamarton commented on a change in pull request #7:
URL: https://github.com/apache/incubator-yunikorn-release/pull/7#discussion_r436545219
##########
File path: tools/build-release.py
##########
@@ -41,19 +42,16 @@ def build_release():
release_base = os.path.join(staging_dir, release_package_name)
release_top_path = os.path.join(os.path.dirname(tools_dir),
"release-top-level-artifacts")
+ helm_chart_path = os.path.join(os.path.dirname(tools_dir),
+ "helm-charts")
Review comment:
I don't think we should include the helm charts for all versions, since the released ones can be installed without having this files.
I think the better solution is to change 0.8.0 version from the helm charts to latest. When testing it, we will need to change the image version to the locally built ones as mentioned in the README: https://github.com/apache/incubator-yunikorn-release/blob/master/release-top-level-artifacts/README.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org