You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2019/02/11 19:14:34 UTC

Review Request 69945: Added a test to test memfd file clone.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69945/
-----------------------------------------------------------

Review request for mesos, Andrei Budnik, Gilbert Song, and James Peach.


Repository: mesos


Description
-------

This patch added a test to test the memfd::cloneFile.


Diffs
-----

  src/Makefile.am 3f7daf2cca63c1b9c9e78264f241892327741aa0 
  src/tests/CMakeLists.txt 42f820715ac43dc70a776f30783d9bc078ef99a5 
  src/tests/containerizer/linux_memfd_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/69945/diff/1/


Testing
-------

sudo make check


Thanks,

Jie Yu

Re: Review Request 69945: Added a test to test memfd file clone.

Posted by Gilbert Song <so...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69945/#review212711
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On Feb. 11, 2019, 11:14 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69945/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2019, 11:14 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch added a test to test the memfd::cloneFile.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 3f7daf2cca63c1b9c9e78264f241892327741aa0 
>   src/tests/CMakeLists.txt 42f820715ac43dc70a776f30783d9bc078ef99a5 
>   src/tests/containerizer/linux_memfd_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69945/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>