You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by rajkrrsingh <gi...@git.apache.org> on 2018/05/10 19:59:59 UTC
[GitHub] storm pull request #2670: STORM-3068: STORM_JAR_JVM_OPTS are not passed to s...
GitHub user rajkrrsingh opened a pull request:
https://github.com/apache/storm/pull/2670
STORM-3068: STORM_JAR_JVM_OPTS are not passed to storm-kafka-monitor …
added STORM_JAR_JVM_OPTS to java command in storm-kafka-monitor file to pass java configuration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rajkrrsingh/storm STORM-3068
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2670.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2670
----
commit d976f4890ab3f2f81bf2a86b23584b341aacc798
Author: Rajkumar singh <ra...@...>
Date: 2018-05-10T19:58:01Z
STORM-3068: STORM_JAR_JVM_OPTS are not passed to storm-kafka-monitor properly
----
---
[GitHub] storm issue #2670: STORM-3068: STORM_JAR_JVM_OPTS are not passed to storm-ka...
Posted by priyank5485 <gi...@git.apache.org>.
Github user priyank5485 commented on the issue:
https://github.com/apache/storm/pull/2670
+1(NB)
---
[GitHub] storm issue #2670: STORM-3068: STORM_JAR_JVM_OPTS are not passed to storm-ka...
Posted by priyank5485 <gi...@git.apache.org>.
Github user priyank5485 commented on the issue:
https://github.com/apache/storm/pull/2670
@rajkrrsingh Is the presumption that STORM_JAR_JVM_OPTS will be set? Have you checked if its okay when the variable is not set? Can you add it to README as well regarding this change?
---
[GitHub] storm issue #2670: STORM-3068: STORM_JAR_JVM_OPTS are not passed to storm-ka...
Posted by rajkrrsingh <gi...@git.apache.org>.
Github user rajkrrsingh commented on the issue:
https://github.com/apache/storm/pull/2670
@priyank5485 I actually verified that STORM_JAR_JVM_OPTS is not propagating to the java args, the test I ran to confirm is
without the change java command look like
```
+ exec /usr/jdk64/jdk1.8.0_112/bin/java -cp /usr/hdp/2.6.2.0-205/storm/toollib/storm-kafka-monitor-1.1.0.2.6.2.0-205.jar org.apache.storm.kafka.monitor.KafkaOffsetLagUtil
```
while with the change and setting STORM_JAR_JVM_OPTS=-Xmx1024m the command look like
```
+ exec /usr/jdk64/jdk1.8.0_112/bin/java -Xmx1024m -cp /usr/hdp/2.6.2.0-205/storm/toollib/storm-kafka-monitor-1.1.0.2.6.2.0-205.jar org.apache.storm.kafka.monitor.KafkaOffsetLagUtil
```
---
[GitHub] storm pull request #2670: STORM-3068: STORM_JAR_JVM_OPTS are not passed to s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2670
---
[GitHub] storm issue #2670: STORM-3068: STORM_JAR_JVM_OPTS are not passed to storm-ka...
Posted by priyank5485 <gi...@git.apache.org>.
Github user priyank5485 commented on the issue:
https://github.com/apache/storm/pull/2670
@rajkrrsingh When you say STORM_JAR_JVM_OPTS is not propagating to the java args, where is it not propagating from? I don't see it being set anywhere in this script. And i see that its sourcing the storm-env.sh script. So i was just suggesting just adding a check like we have for JAVA_HOME to handle case where its not defined.
---
[GitHub] storm issue #2670: STORM-3068: STORM_JAR_JVM_OPTS are not passed to storm-ka...
Posted by rajkrrsingh <gi...@git.apache.org>.
Github user rajkrrsingh commented on the issue:
https://github.com/apache/storm/pull/2670
@priyank5485 yes STORM_JAR_JVM_OPTS is sourced from storm-env, if nothing is set for this conf in storm-env the value propagated to storm-kafka-monitor will be blank.
---