You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2023/11/27 12:42:41 UTC
[Impala-ASF-CR] IMPALA-12577: Correctly update last-synced-event-time
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20732
Change subject: IMPALA-12577: Correctly update last-synced-event-time
......................................................................
IMPALA-12577: Correctly update last-synced-event-time
There are two metrics tracking the progress of HMS event processing:
last-synced-event-id and last-synced-event-time. We have several places
that only update last-synced-event-id without updating
last-synced-event-time which is used to calculate the lag of event
processing. Users might set up alerts on the lag so we'd better keep it
updated.
Tests
- Add codes to verify the metrics in MetastoreEventsProcessorTest
- Ran MetastoreEventsProcessorTest#testIgnoreNonDefaultCatalogs
Change-Id: I033ace83221bc5e0c84c19aac78a41c1eeda31f2
---
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/test/java/org/apache/impala/catalog/events/SynchronousHMSEventProcessorForTests.java
2 files changed, 65 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/20732/1
--
To view, visit http://gerrit.cloudera.org:8080/20732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I033ace83221bc5e0c84c19aac78a41c1eeda31f2
Gerrit-Change-Number: 20732
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-12577: Correctly update last-synced-event-time
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20732
to look at the new patch set (#2).
Change subject: IMPALA-12577: Correctly update last-synced-event-time
......................................................................
IMPALA-12577: Correctly update last-synced-event-time
There are two metrics tracking the progress of HMS event processing:
last-synced-event-id and last-synced-event-time. We have several places
that only update last-synced-event-id without updating
last-synced-event-time which is used to calculate the lag of event
processing. Users might set up alerts on the lag so we'd better keep it
updated.
Tests
- Add codes to verify the metrics in MetastoreEventsProcessorTest
- Fix a potential NullPointer error in HiveJdbcClientPool.java
- Ran CORE test
Change-Id: I033ace83221bc5e0c84c19aac78a41c1eeda31f2
---
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/test/java/org/apache/impala/catalog/events/SynchronousHMSEventProcessorForTests.java
M fe/src/test/java/org/apache/impala/testutil/HiveJdbcClientPool.java
3 files changed, 71 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/20732/2
--
To view, visit http://gerrit.cloudera.org:8080/20732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I033ace83221bc5e0c84c19aac78a41c1eeda31f2
Gerrit-Change-Number: 20732
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-12577: Correctly update last-synced-event-time
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Andrew Sherman, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20732
to look at the new patch set (#3).
Change subject: IMPALA-12577: Correctly update last-synced-event-time
......................................................................
IMPALA-12577: Correctly update last-synced-event-time
There are two metrics tracking the progress of HMS event processing:
last-synced-event-id and last-synced-event-time. We have several places
that only update last-synced-event-id without updating
last-synced-event-time which is used to calculate the lag of event
processing. Users might set up alerts on the lag so we'd better keep it
updated.
Tests
- Add code to verify the metrics in MetastoreEventsProcessorTest
- Fix a potential NullPointer error in HiveJdbcClientPool.java
- Ran CORE test
Change-Id: I033ace83221bc5e0c84c19aac78a41c1eeda31f2
---
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/test/java/org/apache/impala/catalog/events/SynchronousHMSEventProcessorForTests.java
M fe/src/test/java/org/apache/impala/testutil/HiveJdbcClientPool.java
3 files changed, 71 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/20732/3
--
To view, visit http://gerrit.cloudera.org:8080/20732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I033ace83221bc5e0c84c19aac78a41c1eeda31f2
Gerrit-Change-Number: 20732
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-12577: Correctly update last-synced-event-time
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20732 )
Change subject: IMPALA-12577: Correctly update last-synced-event-time
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I033ace83221bc5e0c84c19aac78a41c1eeda31f2
Gerrit-Change-Number: 20732
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 29 Nov 2023 04:24:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12577: Correctly update last-synced-event-time
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20732 )
Change subject: IMPALA-12577: Correctly update last-synced-event-time
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/14527/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I033ace83221bc5e0c84c19aac78a41c1eeda31f2
Gerrit-Change-Number: 20732
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2023 08:55:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12577: Correctly update last-synced-event-time
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20732 )
Change subject: IMPALA-12577: Correctly update last-synced-event-time
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9959/
--
To view, visit http://gerrit.cloudera.org:8080/20732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I033ace83221bc5e0c84c19aac78a41c1eeda31f2
Gerrit-Change-Number: 20732
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2023 02:53:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12577: Correctly update last-synced-event-time
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20732 )
Change subject: IMPALA-12577: Correctly update last-synced-event-time
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9959/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/20732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I033ace83221bc5e0c84c19aac78a41c1eeda31f2
Gerrit-Change-Number: 20732
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Nov 2023 22:28:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12577: Correctly update last-synced-event-time
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20732 )
Change subject: IMPALA-12577: Correctly update last-synced-event-time
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/14521/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I033ace83221bc5e0c84c19aac78a41c1eeda31f2
Gerrit-Change-Number: 20732
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Nov 2023 13:11:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12577: Correctly update last-synced-event-time
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20732 )
Change subject: IMPALA-12577: Correctly update last-synced-event-time
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20732/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20732/2//COMMIT_MSG@17
PS2, Line 17: codes
Nit: "code"
--
To view, visit http://gerrit.cloudera.org:8080/20732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I033ace83221bc5e0c84c19aac78a41c1eeda31f2
Gerrit-Change-Number: 20732
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2023 16:20:26 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12577: Correctly update last-synced-event-time
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20732 )
Change subject: IMPALA-12577: Correctly update last-synced-event-time
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20732/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20732/2//COMMIT_MSG@17
PS2, Line 17: code
> Nit: "code"
Done
--
To view, visit http://gerrit.cloudera.org:8080/20732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I033ace83221bc5e0c84c19aac78a41c1eeda31f2
Gerrit-Change-Number: 20732
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 28 Nov 2023 22:22:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12577: Correctly update last-synced-event-time
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20732 )
Change subject: IMPALA-12577: Correctly update last-synced-event-time
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I033ace83221bc5e0c84c19aac78a41c1eeda31f2
Gerrit-Change-Number: 20732
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 29 Nov 2023 00:01:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12577: Correctly update last-synced-event-time
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20732 )
Change subject: IMPALA-12577: Correctly update last-synced-event-time
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9963/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/20732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I033ace83221bc5e0c84c19aac78a41c1eeda31f2
Gerrit-Change-Number: 20732
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 29 Nov 2023 00:01:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12577: Correctly update last-synced-event-time
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20732 )
Change subject: IMPALA-12577: Correctly update last-synced-event-time
......................................................................
IMPALA-12577: Correctly update last-synced-event-time
There are two metrics tracking the progress of HMS event processing:
last-synced-event-id and last-synced-event-time. We have several places
that only update last-synced-event-id without updating
last-synced-event-time which is used to calculate the lag of event
processing. Users might set up alerts on the lag so we'd better keep it
updated.
Tests
- Add code to verify the metrics in MetastoreEventsProcessorTest
- Fix a potential NullPointer error in HiveJdbcClientPool.java
- Ran CORE test
Change-Id: I033ace83221bc5e0c84c19aac78a41c1eeda31f2
Reviewed-on: http://gerrit.cloudera.org:8080/20732
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/test/java/org/apache/impala/catalog/events/SynchronousHMSEventProcessorForTests.java
M fe/src/test/java/org/apache/impala/testutil/HiveJdbcClientPool.java
3 files changed, 71 insertions(+), 15 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/20732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I033ace83221bc5e0c84c19aac78a41c1eeda31f2
Gerrit-Change-Number: 20732
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-12577: Correctly update last-synced-event-time
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20732 )
Change subject: IMPALA-12577: Correctly update last-synced-event-time
......................................................................
Patch Set 3: Code-Review+2
carry forward +2
--
To view, visit http://gerrit.cloudera.org:8080/20732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I033ace83221bc5e0c84c19aac78a41c1eeda31f2
Gerrit-Change-Number: 20732
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 28 Nov 2023 23:34:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12577: Correctly update last-synced-event-time
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20732 )
Change subject: IMPALA-12577: Correctly update last-synced-event-time
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9961/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/20732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I033ace83221bc5e0c84c19aac78a41c1eeda31f2
Gerrit-Change-Number: 20732
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2023 10:31:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12577: Correctly update last-synced-event-time
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20732 )
Change subject: IMPALA-12577: Correctly update last-synced-event-time
......................................................................
Patch Set 3:
Thanks for the quick review, Andrew!
--
To view, visit http://gerrit.cloudera.org:8080/20732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I033ace83221bc5e0c84c19aac78a41c1eeda31f2
Gerrit-Change-Number: 20732
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 29 Nov 2023 00:01:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12577: Correctly update last-synced-event-time
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20732 )
Change subject: IMPALA-12577: Correctly update last-synced-event-time
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I033ace83221bc5e0c84c19aac78a41c1eeda31f2
Gerrit-Change-Number: 20732
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2023 15:02:12 +0000
Gerrit-HasComments: No