[GitHub] [druid] loquisgon commented on a change in pull request #11376: define superuser permissions set in druid-server instead of druid-basic-auth extension

[GitBox <gi...@apache.org>]

loquisgon commented on a change in pull request #11376:
URL: https://github.com/apache/druid/pull/11376#discussion_r656516073



##########
File path: server/src/main/java/org/apache/druid/server/security/AuthorizationUtils.java
##########
@@ -359,6 +359,51 @@ public static Access authorizeAllResourceActions(
     return filteredResources;
   }
 
+  public static List<ResourceAction> makeSuperUserPermissions()
+  {
+    ResourceAction datasourceR = new ResourceAction(
+        new Resource(".*", ResourceType.DATASOURCE),

Review comment:
       Given that this pattern, ".*", is used frequently, does it make sense to create a specific string named constant for it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org