You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/26 02:34:37 UTC

[GitHub] [airflow] pauldalewilliams commented on a diff in pull request #26666: SFTPOperator - add support for list of file paths

pauldalewilliams commented on code in PR #26666:
URL: https://github.com/apache/airflow/pull/26666#discussion_r979516391


##########
airflow/providers/sftp/operators/sftp.py:
##########
@@ -129,7 +143,7 @@ def __init__(
                 )
                 self.sftp_hook = SFTPHook(ssh_hook=self.ssh_hook)
 
-    def execute(self, context: Any) -> str | None:
+    def execute(self, context: Any) -> list[str] | None:

Review Comment:
   Ah, good point - I had considered that at one point and forgot to incorporate it.  Hmm, what do you think - set a flag if I converted a `str` to a `list[str]` or just make `execute` return a `str` if `len(list)` == 1?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org