You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "felipecrv (via GitHub)" <gi...@apache.org> on 2023/04/25 16:47:51 UTC

[GitHub] [arrow] felipecrv commented on a diff in pull request #35283: GH-35282: [C++] auto enable brotli when enable fuzzing

felipecrv commented on code in PR #35283:
URL: https://github.com/apache/arrow/pull/35283#discussion_r1176785833


##########
cpp/cmake_modules/DefineOptions.cmake:
##########
@@ -264,7 +264,8 @@ takes precedence over ccache if a storage backend is configured" ON)
                 "Build Arrow Fuzzing executables"
                 OFF
                 DEPENDS
-                ARROW_TESTING)
+                ARROW_TESTING
+                ARROW_WITH_BROTLI)

Review Comment:
   This is nice, but it means build scripts will error out when options don't satisfy these dependencies, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org