You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Duncan Grant <no...@github.com> on 2016/05/19 10:40:20 UTC
[jclouds/jclouds] JCLOUDS-1044 fix handling NULL JsonTokens in adapters under NullFilte… (#958)
…ringTypeAdapterFactories class
This PR backports this fix (0fb1b459a607f21f6a8ebd7492879d02553c4b88) from 2.0.0 to 1.9.x.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/958
-- Commit Summary --
* JCLOUDS-1044 fix handling NULL JsonTokens in adapters under NullFilteringTypeAdapterFactories class
-- File Changes --
M apis/chef/src/main/java/org/jclouds/chef/config/ChefParserModule.java (59)
M apis/chef/src/test/java/org/jclouds/chef/config/ChefParserModuleTest.java (24)
M core/src/main/java/org/jclouds/json/internal/NullFilteringTypeAdapterFactories.java (11)
M core/src/test/java/org/jclouds/json/internal/NullFilteringTypeAdapterFactoriesTest.java (21)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/958.patch
https://github.com/jclouds/jclouds/pull/958.diff
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/958
Re: [jclouds/jclouds] JCLOUDS-1044 fix handling NULL JsonTokens in adapters under NullFilte… (#958)
Posted by Andrea Turli <no...@github.com>.
Closed #958.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/958#event-665833402
Re: [jclouds/jclouds] JCLOUDS-1044 fix handling NULL JsonTokens in adapters under NullFilte… (#958)
Posted by Andrea Turli <no...@github.com>.
ok build is happy, merging now
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/958#issuecomment-220331954
Re: [jclouds/jclouds] JCLOUDS-1044 fix handling NULL JsonTokens in adapters under NullFilte… (#958)
Posted by Duncan Grant <no...@github.com>.
@nacx thanks
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/958#issuecomment-220327819
Re: [jclouds/jclouds] JCLOUDS-1044 fix handling NULL JsonTokens in adapters under NullFilte… (#958)
Posted by Andrea Turli <no...@github.com>.
thanks @duncangrant
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/958#issuecomment-220332124
Re: [jclouds/jclouds] JCLOUDS-1044 fix handling NULL JsonTokens in adapters under NullFilte… (#958)
Posted by Andrea Turli <no...@github.com>.
Merged at [1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/7016b040)
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/958#issuecomment-220332030
Re: [jclouds/jclouds] JCLOUDS-1044 fix handling NULL JsonTokens in adapters under NullFilte… (#958)
Posted by Andrea Turli <no...@github.com>.
Sorry @grkvlt I've been notified just now about this PR by github, looks like @nacx already reviewed it: thanks @nacx !
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/958#issuecomment-220329463
Re: [jclouds/jclouds] JCLOUDS-1044 fix handling NULL JsonTokens in adapters under NullFilte… (#958)
Posted by Ignasi Barrera <no...@github.com>.
LGTM! Let's merge it once the build finishes and is green. Thanks @duncangrant @grkvlt!
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/958#issuecomment-220291027
Re: [jclouds/jclouds] JCLOUDS-1044 fix handling NULL JsonTokens in adapters under NullFilte… (#958)
Posted by Andrew Donald Kennedy <no...@github.com>.
@andreaturli Can you take a look, please? We need this for the jclouds-labs Docker provider, to fix behaviour where JSON maps returned by the Docker REST API have entries with null values, instead of empty lists.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/958#issuecomment-220289715