You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (Created) (JIRA)" <ji...@apache.org> on 2012/01/21 15:11:41 UTC
[jira] [Created] (LUCENE-3712) Remove unused (and untested) methods
from ReaderUtil that are also veeeeery ineffective
Remove unused (and untested) methods from ReaderUtil that are also veeeeery ineffective
---------------------------------------------------------------------------------------
Key: LUCENE-3712
URL: https://issues.apache.org/jira/browse/LUCENE-3712
Project: Lucene - Java
Issue Type: Task
Components: core/other
Reporter: Uwe Schindler
Assignee: Uwe Schindler
ReaderUtil contains two methods that are nowhere used and not even tested. Additionally those are implemented with useless List->array copying; ineffective docStart calculation for a binary search later instead directly returning the reader while scanning -- and I am not sure if they really work as expected. As ReaderUtil is @lucene.internal we should remove them in 3.x and trunk, alternatively the useless array copy / docStarts handling should be removed and tests added:
{code:java}
public static IndexReader subReader(int doc, IndexReader reader)
public static IndexReader subReader(IndexReader reader, int subIndex)
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3712) Remove unused (and untested)
methods from ReaderUtil that are also veeeeery ineffective
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190429#comment-13190429 ]
Robert Muir commented on LUCENE-3712:
-------------------------------------
+1, untested and unused, nuke it.
> Remove unused (and untested) methods from ReaderUtil that are also veeeeery ineffective
> ---------------------------------------------------------------------------------------
>
> Key: LUCENE-3712
> URL: https://issues.apache.org/jira/browse/LUCENE-3712
> Project: Lucene - Java
> Issue Type: Task
> Components: core/other
> Affects Versions: 3.5
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3712.patch
>
>
> ReaderUtil contains two methods that are nowhere used and not even tested. Additionally those are implemented with useless List->array copying; ineffective docStart calculation for a binary search later instead directly returning the reader while scanning -- and I am not sure if they really work as expected. As ReaderUtil is @lucene.internal we should remove them in 3.x and trunk, alternatively the useless array copy / docStarts handling should be removed and tests added:
> {code:java}
> public static IndexReader subReader(int doc, IndexReader reader)
> public static IndexReader subReader(IndexReader reader, int subIndex)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3712) Remove unused (and untested) methods
from ReaderUtil that are also veeeeery ineffective
Posted by "Uwe Schindler (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-3712:
----------------------------------
Attachment: LUCENE-3712.patch
> Remove unused (and untested) methods from ReaderUtil that are also veeeeery ineffective
> ---------------------------------------------------------------------------------------
>
> Key: LUCENE-3712
> URL: https://issues.apache.org/jira/browse/LUCENE-3712
> Project: Lucene - Java
> Issue Type: Task
> Components: core/other
> Affects Versions: 3.5
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3712.patch
>
>
> ReaderUtil contains two methods that are nowhere used and not even tested. Additionally those are implemented with useless List->array copying; ineffective docStart calculation for a binary search later instead directly returning the reader while scanning -- and I am not sure if they really work as expected. As ReaderUtil is @lucene.internal we should remove them in 3.x and trunk, alternatively the useless array copy / docStarts handling should be removed and tests added:
> {code:java}
> public static IndexReader subReader(int doc, IndexReader reader)
> public static IndexReader subReader(IndexReader reader, int subIndex)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3712) Remove unused (and untested) methods
from ReaderUtil that are also veeeeery ineffective
Posted by "Uwe Schindler (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-3712:
----------------------------------
Affects Version/s: 3.5
Fix Version/s: 4.0
3.6
> Remove unused (and untested) methods from ReaderUtil that are also veeeeery ineffective
> ---------------------------------------------------------------------------------------
>
> Key: LUCENE-3712
> URL: https://issues.apache.org/jira/browse/LUCENE-3712
> Project: Lucene - Java
> Issue Type: Task
> Components: core/other
> Affects Versions: 3.5
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3712.patch
>
>
> ReaderUtil contains two methods that are nowhere used and not even tested. Additionally those are implemented with useless List->array copying; ineffective docStart calculation for a binary search later instead directly returning the reader while scanning -- and I am not sure if they really work as expected. As ReaderUtil is @lucene.internal we should remove them in 3.x and trunk, alternatively the useless array copy / docStarts handling should be removed and tests added:
> {code:java}
> public static IndexReader subReader(int doc, IndexReader reader)
> public static IndexReader subReader(IndexReader reader, int subIndex)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3712) Remove unused (and untested)
methods from ReaderUtil that are also veeeeery ineffective
Posted by "Uwe Schindler (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler resolved LUCENE-3712.
-----------------------------------
Resolution: Fixed
Committed trunk revision: 1235228
Committed 3.x revision: 1235234
> Remove unused (and untested) methods from ReaderUtil that are also veeeeery ineffective
> ---------------------------------------------------------------------------------------
>
> Key: LUCENE-3712
> URL: https://issues.apache.org/jira/browse/LUCENE-3712
> Project: Lucene - Java
> Issue Type: Task
> Components: core/other
> Affects Versions: 3.5
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3712.patch
>
>
> ReaderUtil contains two methods that are nowhere used and not even tested. Additionally those are implemented with useless List->array copying; ineffective docStart calculation for a binary search later instead directly returning the reader while scanning -- and I am not sure if they really work as expected. As ReaderUtil is @lucene.internal we should remove them in 3.x and trunk, alternatively the useless array copy / docStarts handling should be removed and tests added:
> {code:java}
> public static IndexReader subReader(int doc, IndexReader reader)
> public static IndexReader subReader(IndexReader reader, int subIndex)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org