[GitHub] [airflow] LionelZhao28 commented on pull request #17502: localize the dag_run

[GitBox <gi...@apache.org>]

LionelZhao28 commented on pull request #17502:
URL: https://github.com/apache/airflow/pull/17502#issuecomment-895111608


   > I kind of feel maybe we should just use this behaviour all the time. The run ID is only for identifying the run, and using UTC has no advantage beside being easy to implement.
   
   I agree that the `run ID` is only for identifying the run, but for the user, they may want to locate the specific run to check the dag logs, especially when debugging or troubleshooting, they may run the dag serval times manually. If the dag `run ID` is generated using the local time, it is really convenient for them.
   It will not increase the compatibility for our system to allow the user to localize the `run_id`, we will be very happy to see this change. 
   I've talked with some friends who are using the airflow, actually, most of them change the sources codes here and re-compile the project to launch.
   
   > Either way though, you need some tests to ensure this works.
   I've tested the code changes, setting this value to `True`, `False`, and with this config missing. It works fine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org