You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Yurii Shylov <yu...@gmail.com> on 2015/02/10 18:47:42 UTC
Re: Review Request 30568: Rolling Upgrade Bootstrap - Allow Ambari
upgrade from 1.7.0 - 2.0.0 to populate new tables
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30568/
-----------------------------------------------------------
(Updated Фев. 10, 2015, 5:47 п.п.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
Summary (updated)
-----------------
Rolling Upgrade Bootstrap - Allow Ambari upgrade from 1.7.0 - 2.0.0 to populate new tables
Bugs: AMBARI-9054
https://issues.apache.org/jira/browse/AMBARI-9054
Repository: ambari
Description
-------
During the upgrade process, populate the repo_version, cluster_version, and host_version tables.
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/script/script.py 683397a
ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java a71bbd1
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 80ef542
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 4fe219c
Diff: https://reviews.apache.org/r/30568/diff/
Testing (updated)
-------
Manual testing done, UT passing
Thanks,
Yurii Shylov
Re: Review Request 30568: Rolling Upgrade Bootstrap - Allow Ambari
upgrade from 1.7.0 - 2.0.0 to populate new tables
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30568/#review71846
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Feb. 10, 2015, 5:47 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30568/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2015, 5:47 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9054
> https://issues.apache.org/jira/browse/AMBARI-9054
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During the upgrade process, populate the repo_version, cluster_version, and host_version tables.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/script/script.py 683397a
> ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java a71bbd1
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 80ef542
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 4fe219c
>
> Diff: https://reviews.apache.org/r/30568/diff/
>
>
> Testing
> -------
>
> Manual testing done, UT passing
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 30568: Rolling Upgrade Bootstrap - Allow Ambari
upgrade from 1.7.0 - 2.0.0 to populate new tables
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30568/#review72146
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Feb. 11, 2015, 11:21 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30568/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2015, 11:21 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9054
> https://issues.apache.org/jira/browse/AMBARI-9054
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During the upgrade process, populate the repo_version, cluster_version, and host_version tables.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/script/script.py 683397a
> ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java a71bbd1
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java b60af2f
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 4fe219c
>
> Diff: https://reviews.apache.org/r/30568/diff/
>
>
> Testing
> -------
>
> UPD: manual testing done again. I couldn't get through finalize but it was caused by another issue. Database state and logs show that patch doesn't make changes to regulare RU workflow.
>
> Manual testing done, UT passing
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 30568: Rolling Upgrade Bootstrap - Allow Ambari
upgrade from 1.7.0 - 2.0.0 to populate new tables
Posted by Yurii Shylov <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30568/
-----------------------------------------------------------
(Updated Фев. 12, 2015, 6:02 п.п.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
Changes
-------
Rebased again
Bugs: AMBARI-9054
https://issues.apache.org/jira/browse/AMBARI-9054
Repository: ambari
Description
-------
During the upgrade process, populate the repo_version, cluster_version, and host_version tables.
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/script/script.py e470690
ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java a71bbd1
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java b60af2f
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 4fe219c
Diff: https://reviews.apache.org/r/30568/diff/
Testing
-------
UPD: manual testing done again. I couldn't get through finalize but it was caused by another issue. Database state and logs show that patch doesn't make changes to regulare RU workflow.
Manual testing done, UT passing
Thanks,
Yurii Shylov
Re: Review Request 30568: Rolling Upgrade Bootstrap - Allow Ambari
upgrade from 1.7.0 - 2.0.0 to populate new tables
Posted by Yurii Shylov <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30568/
-----------------------------------------------------------
(Updated Фев. 12, 2015, 5:27 п.п.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
Changes
-------
Rebased on latest trunk as the patch stopped applying.
Can we get this pushed?
Bugs: AMBARI-9054
https://issues.apache.org/jira/browse/AMBARI-9054
Repository: ambari
Description
-------
During the upgrade process, populate the repo_version, cluster_version, and host_version tables.
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/script/script.py 683397a
ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java a71bbd1
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java b60af2f
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 4fe219c
Diff: https://reviews.apache.org/r/30568/diff/
Testing
-------
UPD: manual testing done again. I couldn't get through finalize but it was caused by another issue. Database state and logs show that patch doesn't make changes to regulare RU workflow.
Manual testing done, UT passing
Thanks,
Yurii Shylov
Re: Review Request 30568: Rolling Upgrade Bootstrap - Allow Ambari
upgrade from 1.7.0 - 2.0.0 to populate new tables
Posted by Yurii Shylov <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30568/
-----------------------------------------------------------
(Updated Фев. 11, 2015, 11:21 п.п.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
Changes
-------
Final patch added, now it supports both 1.7->2.0 and RU workflow.
There was a problem with saving version to structured out on status commands. Agents use the same file for every status command and thus even if version was written there once it is populated for every status response. After RU was performed real version of 2.2.0.1 could be overwritten by old cached one which would cause finalize failure. It is hotfixed by removing version from structured out if it was not requested.
Bugs: AMBARI-9054
https://issues.apache.org/jira/browse/AMBARI-9054
Repository: ambari
Description
-------
During the upgrade process, populate the repo_version, cluster_version, and host_version tables.
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/script/script.py 683397a
ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java a71bbd1
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java b60af2f
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 4fe219c
Diff: https://reviews.apache.org/r/30568/diff/
Testing (updated)
-------
UPD: manual testing done again. I couldn't get through finalize but it was caused by another issue. Database state and logs show that patch doesn't make changes to regulare RU workflow.
Manual testing done, UT passing
Thanks,
Yurii Shylov
Re: Review Request 30568: Rolling Upgrade Bootstrap - Allow Ambari
upgrade from 1.7.0 - 2.0.0 to populate new tables
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30568/#review71821
-----------------------------------------------------------
Ship it!
ambari-common/src/main/python/resource_management/libraries/script/script.py
<https://reviews.apache.org/r/30568/#comment117689>
Should perhaps add an else block to return False for the case where command_name is "status" since there's no need to execute line 151.
- Alejandro Fernandez
On Feb. 10, 2015, 5:47 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30568/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2015, 5:47 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9054
> https://issues.apache.org/jira/browse/AMBARI-9054
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During the upgrade process, populate the repo_version, cluster_version, and host_version tables.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/script/script.py 683397a
> ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java a71bbd1
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 80ef542
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 4fe219c
>
> Diff: https://reviews.apache.org/r/30568/diff/
>
>
> Testing
> -------
>
> Manual testing done, UT passing
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 30568: Rolling Upgrade Bootstrap - Allow Ambari
upgrade from 1.7.0 - 2.0.0 to populate new tables
Posted by Yurii Shylov <yu...@gmail.com>.
> On Фев. 10, 2015, 5:57 п.п., Nate Cole wrote:
> > ambari-common/src/main/python/resource_management/libraries/script/script.py, line 124
> > <https://reviews.apache.org/r/30568/diff/4/?file=860030#file860030line124>
> >
> > It's ok to move this import to the top with the others.
default.py imports script.py and it causes circular dependency, python throws error
- Yurii
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30568/#review71812
-----------------------------------------------------------
On Фев. 10, 2015, 5:47 п.п., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30568/
> -----------------------------------------------------------
>
> (Updated Фев. 10, 2015, 5:47 п.п.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9054
> https://issues.apache.org/jira/browse/AMBARI-9054
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During the upgrade process, populate the repo_version, cluster_version, and host_version tables.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/script/script.py 683397a
> ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java a71bbd1
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 80ef542
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 4fe219c
>
> Diff: https://reviews.apache.org/r/30568/diff/
>
>
> Testing
> -------
>
> Manual testing done, UT passing
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 30568: Rolling Upgrade Bootstrap - Allow Ambari
upgrade from 1.7.0 - 2.0.0 to populate new tables
Posted by Nate Cole <nc...@hortonworks.com>.
> On Feb. 10, 2015, 12:57 p.m., Nate Cole wrote:
> > ambari-common/src/main/python/resource_management/libraries/script/script.py, line 124
> > <https://reviews.apache.org/r/30568/diff/4/?file=860030#file860030line124>
> >
> > It's ok to move this import to the top with the others.
>
> Yurii Shylov wrote:
> default.py imports script.py and it causes circular dependency, python throws error
Wow that's pathetic. Ok :)
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30568/#review71812
-----------------------------------------------------------
On Feb. 10, 2015, 12:47 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30568/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2015, 12:47 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9054
> https://issues.apache.org/jira/browse/AMBARI-9054
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During the upgrade process, populate the repo_version, cluster_version, and host_version tables.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/script/script.py 683397a
> ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java a71bbd1
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 80ef542
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 4fe219c
>
> Diff: https://reviews.apache.org/r/30568/diff/
>
>
> Testing
> -------
>
> Manual testing done, UT passing
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 30568: Rolling Upgrade Bootstrap - Allow Ambari
upgrade from 1.7.0 - 2.0.0 to populate new tables
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30568/#review71812
-----------------------------------------------------------
Ship it!
ambari-common/src/main/python/resource_management/libraries/script/script.py
<https://reviews.apache.org/r/30568/#comment117672>
It's ok to move this import to the top with the others.
ambari-common/src/main/python/resource_management/libraries/script/script.py
<https://reviews.apache.org/r/30568/#comment117673>
Move import to the top since you use this more than once.
- Nate Cole
On Feb. 10, 2015, 12:47 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30568/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2015, 12:47 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9054
> https://issues.apache.org/jira/browse/AMBARI-9054
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During the upgrade process, populate the repo_version, cluster_version, and host_version tables.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/script/script.py 683397a
> ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java a71bbd1
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 80ef542
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 4fe219c
>
> Diff: https://reviews.apache.org/r/30568/diff/
>
>
> Testing
> -------
>
> Manual testing done, UT passing
>
>
> Thanks,
>
> Yurii Shylov
>
>