You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@celeborn.apache.org by ni...@apache.org on 2026/05/27 02:08:06 UTC
(celeborn) branch main updated (f154efcbd -> 1d92a4071)
This is an automated email from the ASF dual-hosted git repository.
SteNicholas pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/celeborn.git
omit f154efcbd [CELEBORN-2338] Remove hardcoded CELEBORN_PRINT_LAUNCH_COMMAND=0
omit 48c6b0778 [CELEBORN-2337] Celeborn OpenAPI client should not shade slf4j-api
new 9e6f93e17 [CELEBORN-2337] Celeborn OpenAPI client should not shade slf4j-api
new 1d92a4071 [CELEBORN-2338] Remove hardcoded CELEBORN_PRINT_LAUNCH_COMMAND=0
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (f154efcbd)
\
N -- N -- N refs/heads/main (1d92a4071)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
(celeborn) 02/02: [CELEBORN-2338] Remove hardcoded CELEBORN_PRINT_LAUNCH_COMMAND=0
Posted by ni...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
SteNicholas pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/celeborn.git
commit 1d92a4071e647f8722ea49e378c48be9c7340485
Author: Cheng Pan <ch...@apache.org>
AuthorDate: Tue May 26 20:17:38 2026 +0800
[CELEBORN-2338] Remove hardcoded CELEBORN_PRINT_LAUNCH_COMMAND=0
### What changes were proposed in this pull request?
Remove hardcoded `CELEBORN_PRINT_LAUNCH_COMMAND=0` in `bin/celeborn-class`
### Why are the changes needed?
It should be picked from the environment variable.
### Does this PR resolve a correctness bug?
- [ ] Yes
### Does this PR introduce _any_ user-facing change?
- [ ] Yes
### How was this patch tested?
```
$ CELEBORN_PRINT_LAUNCH_COMMAND=1 sbin/celeborn-cli --version
...
Start to launch /opt/java/openjdk/bin/java -XX:+IgnoreUnrecognizedVMOptions -cp /opt/celeborn/conf::/opt/celeborn/cli-jars/*: org.apache.celeborn.cli.CelebornCli --version
...
```
Closes #3702 from pan3793/CELEBORN-2338.
Authored-by: Cheng Pan <ch...@apache.org>
Signed-off-by: SteNicholas <pr...@163.com>
---
bin/celeborn-class | 3 ---
1 file changed, 3 deletions(-)
diff --git a/bin/celeborn-class b/bin/celeborn-class
index 0ee4b213b..ad1f9087e 100755
--- a/bin/celeborn-class
+++ b/bin/celeborn-class
@@ -22,9 +22,6 @@ fi
export CELEBORN_CONF_DIR="${CELEBORN_CONF_DIR:-"${CELEBORN_HOME}/conf"}"
-# print launch command for debug
-export CELEBORN_PRINT_LAUNCH_COMMAND="0"
-
if [ -z "$CELEBORN_ENV_LOADED" ]; then
export CELEBORN_ENV_LOADED=1
(celeborn) 01/02: [CELEBORN-2337] Celeborn OpenAPI client should not shade slf4j-api
Posted by ni...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
SteNicholas pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/celeborn.git
commit 9e6f93e170f1c115342b0893210f688c8e3cb9d0
Author: Cheng Pan <ch...@apache.org>
AuthorDate: Tue May 26 20:14:54 2026 +0800
[CELEBORN-2337] Celeborn OpenAPI client should not shade slf4j-api
### What changes were proposed in this pull request?
As the title, it's a packaging change.
### Why are the changes needed?
I found that `celeborn-cli` always prints such warnings, but actually the slf4j-api and log4j2 jars are correctly present in classpath.
```
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
```
after some investigation, I found that `celeborn-openapi-client-*.jar` bundles shaded slf4j classes, which causes the issue.
```
$ jar tf $CELEBORN_HOME/cli-jars/celeborn-openapi-client-*.jar | grep slf4j
...
org/apache/celeborn/shaded/org/slf4j/
org/apache/celeborn/shaded/org/slf4j/ILoggerFactory.class
org/apache/celeborn/shaded/org/slf4j/IMarkerFactory.class
org/apache/celeborn/shaded/org/slf4j/Logger.class
...
```
### Does this PR resolve a correctness bug?
- [ ] Yes
### Does this PR introduce _any_ user-facing change?
- [ ] Yes
### How was this patch tested?
Tested with `celeborn-cli`, `SLF4J` binding warnings have gone.
Closes #3701 from pan3793/CELEBORN-2337.
Authored-by: Cheng Pan <ch...@apache.org>
Signed-off-by: SteNicholas <pr...@163.com>
---
openapi/openapi-client/pom.xml | 5 -----
project/CelebornBuild.scala | 6 ++----
2 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/openapi/openapi-client/pom.xml b/openapi/openapi-client/pom.xml
index 29c080129..d761bcd35 100644
--- a/openapi/openapi-client/pom.xml
+++ b/openapi/openapi-client/pom.xml
@@ -115,10 +115,6 @@
<pattern>org.apache.hc</pattern>
<shadedPattern>${shading.prefix}.org.apache.hc</shadedPattern>
</relocation>
- <relocation>
- <pattern>org.slf4j</pattern>
- <shadedPattern>${shading.prefix}.org.slf4j</shadedPattern>
- </relocation>
<relocation>
<pattern>META-INF/versions/11/com/fasterxml/jackson</pattern>
<shadedPattern>META-INF/versions/11/org/apache/celeborn/shaded/com/fasterxml/jackson</shadedPattern>
@@ -144,7 +140,6 @@
<include>com.google.code.findbugs:jsr305</include>
<include>jakarta.annotation:jakarta.annotation-api</include>
<include>org.openapitools:jackson-databind-nullable</include>
- <include>org.slf4j:slf4j-api</include>
</includes>
</artifactSet>
<filters>
diff --git a/project/CelebornBuild.scala b/project/CelebornBuild.scala
index bcbd9d60a..e369ef80e 100644
--- a/project/CelebornBuild.scala
+++ b/project/CelebornBuild.scala
@@ -1802,8 +1802,7 @@ object CelebornOpenApi {
name.startsWith("httpclient5-") ||
name.startsWith("httpcore5-") ||
name.startsWith("httpcore5-h2-") ||
- name.startsWith("jackson-databind-nullable-") ||
- name.startsWith("slf4j-api-"))
+ name.startsWith("jackson-databind-nullable-"))
}
},
@@ -1814,8 +1813,7 @@ object CelebornOpenApi {
ShadeRule.rename("jakarta.validation.**" -> "org.apache.celeborn.shaded.jakarta.validation.@1").inAll,
ShadeRule.rename("javax.validation.**" -> "org.apache.celeborn.shaded.javax.validation.@1").inAll,
ShadeRule.rename("javax.ws.rs.ext.**" -> "org.apache.celeborn.shaded.javax.ws.rs.ext.@1").inAll,
- ShadeRule.rename("org.apache.hc.**" -> "org.apache.celeborn.shaded.org.apache.hc.@1").inAll,
- ShadeRule.rename("org.slf4j.**" -> "org.apache.celeborn.shaded.org.slf4j.@1").inAll
+ ShadeRule.rename("org.apache.hc.**" -> "org.apache.celeborn.shaded.org.apache.hc.@1").inAll
),
(assembly / assemblyMergeStrategy) := {