You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/05/13 19:19:10 UTC
Review Request 34171: Allow NFS mounts to be skipped during agent
health check
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34171/
-----------------------------------------------------------
Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Sid Wagle.
Bugs: AMBARI-10882
https://issues.apache.org/jira/browse/AMBARI-10882
Repository: ambari
Description
-------
The 'df' checks traverses the entire fstab (including the automounted user directories). This causes the timeout for each mounted user directory to reset. And since we are checking so often (even every few heartbeats), these automounted user directory never unmount.
Adding the '-l' to the 'df' check, would only parse the local disks, and allow the automounted user folders to timeout properly.
This should be a configurable property to skip or not.
Diffs
-----
ambari-agent/conf/unix/ambari-agent.ini 173bb51
ambari-agent/conf/windows/ambari-agent.ini 61a3ad9
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 13e9f03
ambari-agent/src/main/python/ambari_agent/Controller.py ccd1233
ambari-agent/src/main/python/ambari_agent/Hardware.py 5fbe2f8
ambari-agent/src/main/python/ambari_agent/Heartbeat.py 27aef04
ambari-agent/src/main/python/ambari_agent/HostInfo.py 98c8045
ambari-agent/src/main/python/ambari_agent/RecoveryManager.py 12ba75d
ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 9af45ac
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java ab17db6
ambari-server/src/main/java/org/apache/ambari/server/agent/RegistrationResponse.java 8768a46
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 3ceb05b
Diff: https://reviews.apache.org/r/34171/diff/
Testing
-------
Unit tests are in progress
Thanks,
Dmytro Sen
Re: Review Request 34171: Allow NFS mounts to be skipped during agent
health check
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34171/
-----------------------------------------------------------
(Updated Май 19, 2015, 7 п.п.)
Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Sid Wagle.
Bugs: AMBARI-10882
https://issues.apache.org/jira/browse/AMBARI-10882
Repository: ambari
Description
-------
The 'df' checks traverses the entire fstab (including the automounted user directories). This causes the timeout for each mounted user directory to reset. And since we are checking so often (even every few heartbeats), these automounted user directory never unmount.
Adding the '-l' to the 'df' check, would only parse the local disks, and allow the automounted user folders to timeout properly.
This should be a configurable property to skip or not.
Diffs (updated)
-----
ambari-agent/conf/unix/ambari-agent.ini 173bb51
ambari-agent/conf/windows/ambari-agent.ini 61a3ad9
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 13e9f03
ambari-agent/src/main/python/ambari_agent/Controller.py ccd1233
ambari-agent/src/main/python/ambari_agent/Hardware.py 5fbe2f8
ambari-agent/src/main/python/ambari_agent/Heartbeat.py 27aef04
ambari-agent/src/main/python/ambari_agent/HostInfo.py 98c8045
ambari-agent/src/main/python/ambari_agent/RecoveryManager.py 12ba75d
ambari-agent/src/test/python/ambari_agent/TestHardware.py 8a3d257
ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 9af45ac
ambari-agent/src/test/python/unitTests.py cb7a64f
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java ab17db6
ambari-server/src/main/java/org/apache/ambari/server/agent/RegistrationResponse.java 8768a46
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java d8f89b2
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 39192c4
Diff: https://reviews.apache.org/r/34171/diff/
Testing
-------
Unit tests are in progress
Thanks,
Dmytro Sen
Re: Review Request 34171: Allow NFS mounts to be skipped during agent
health check
Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34171/#review84325
-----------------------------------------------------------
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Травень 19, 2015, 6:50 після полудня, Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34171/
> -----------------------------------------------------------
>
> (Updated Травень 19, 2015, 6:50 після полудня)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Sid Wagle.
>
>
> Bugs: AMBARI-10882
> https://issues.apache.org/jira/browse/AMBARI-10882
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The 'df' checks traverses the entire fstab (including the automounted user directories). This causes the timeout for each mounted user directory to reset. And since we are checking so often (even every few heartbeats), these automounted user directory never unmount.
> Adding the '-l' to the 'df' check, would only parse the local disks, and allow the automounted user folders to timeout properly.
> This should be a configurable property to skip or not.
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/ambari-agent.ini 173bb51
> ambari-agent/conf/windows/ambari-agent.ini 61a3ad9
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 13e9f03
> ambari-agent/src/main/python/ambari_agent/Controller.py ccd1233
> ambari-agent/src/main/python/ambari_agent/Hardware.py 5fbe2f8
> ambari-agent/src/main/python/ambari_agent/Heartbeat.py 27aef04
> ambari-agent/src/main/python/ambari_agent/HostInfo.py 98c8045
> ambari-agent/src/main/python/ambari_agent/RecoveryManager.py 12ba75d
> ambari-agent/src/test/python/ambari_agent/TestHardware.py 8a3d257
> ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 9af45ac
> ambari-agent/src/test/python/unitTests.py cb7a64f
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java ab17db6
> ambari-server/src/main/java/org/apache/ambari/server/agent/RegistrationResponse.java 8768a46
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java d8f89b2
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 39192c4
>
> Diff: https://reviews.apache.org/r/34171/diff/
>
>
> Testing
> -------
>
> Unit tests are in progress
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 34171: Allow NFS mounts to be skipped during agent
health check
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34171/
-----------------------------------------------------------
(Updated Май 19, 2015, 3:50 п.п.)
Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Sid Wagle.
Bugs: AMBARI-10882
https://issues.apache.org/jira/browse/AMBARI-10882
Repository: ambari
Description
-------
The 'df' checks traverses the entire fstab (including the automounted user directories). This causes the timeout for each mounted user directory to reset. And since we are checking so often (even every few heartbeats), these automounted user directory never unmount.
Adding the '-l' to the 'df' check, would only parse the local disks, and allow the automounted user folders to timeout properly.
This should be a configurable property to skip or not.
Diffs (updated)
-----
ambari-agent/conf/unix/ambari-agent.ini 173bb51
ambari-agent/conf/windows/ambari-agent.ini 61a3ad9
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 13e9f03
ambari-agent/src/main/python/ambari_agent/Controller.py ccd1233
ambari-agent/src/main/python/ambari_agent/Hardware.py 5fbe2f8
ambari-agent/src/main/python/ambari_agent/Heartbeat.py 27aef04
ambari-agent/src/main/python/ambari_agent/HostInfo.py 98c8045
ambari-agent/src/main/python/ambari_agent/RecoveryManager.py 12ba75d
ambari-agent/src/test/python/ambari_agent/TestHardware.py 8a3d257
ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 9af45ac
ambari-agent/src/test/python/unitTests.py cb7a64f
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java ab17db6
ambari-server/src/main/java/org/apache/ambari/server/agent/RegistrationResponse.java 8768a46
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java d8f89b2
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 39192c4
Diff: https://reviews.apache.org/r/34171/diff/
Testing
-------
Unit tests are in progress
Thanks,
Dmytro Sen
Re: Review Request 34171: Allow NFS mounts to be skipped during agent
health check
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34171/#review84066
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Травень 13, 2015, 5:19 після полудня, Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34171/
> -----------------------------------------------------------
>
> (Updated Травень 13, 2015, 5:19 після полудня)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Sid Wagle.
>
>
> Bugs: AMBARI-10882
> https://issues.apache.org/jira/browse/AMBARI-10882
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The 'df' checks traverses the entire fstab (including the automounted user directories). This causes the timeout for each mounted user directory to reset. And since we are checking so often (even every few heartbeats), these automounted user directory never unmount.
> Adding the '-l' to the 'df' check, would only parse the local disks, and allow the automounted user folders to timeout properly.
> This should be a configurable property to skip or not.
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/ambari-agent.ini 173bb51
> ambari-agent/conf/windows/ambari-agent.ini 61a3ad9
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 13e9f03
> ambari-agent/src/main/python/ambari_agent/Controller.py ccd1233
> ambari-agent/src/main/python/ambari_agent/Hardware.py 5fbe2f8
> ambari-agent/src/main/python/ambari_agent/Heartbeat.py 27aef04
> ambari-agent/src/main/python/ambari_agent/HostInfo.py 98c8045
> ambari-agent/src/main/python/ambari_agent/RecoveryManager.py 12ba75d
> ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 9af45ac
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java ab17db6
> ambari-server/src/main/java/org/apache/ambari/server/agent/RegistrationResponse.java 8768a46
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 3ceb05b
>
> Diff: https://reviews.apache.org/r/34171/diff/
>
>
> Testing
> -------
>
> Unit tests are in progress
>
>
> Thanks,
>
> Dmytro Sen
>
>