You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/11 19:27:06 UTC

[GitHub] [pulsar-helm-chart] jeantil commented on a change in pull request #80: Use `.Release.Namespace` by default to handle namespaces

jeantil commented on a change in pull request #80:
URL: https://github.com/apache/pulsar-helm-chart/pull/80#discussion_r521587737



##########
File path: charts/pulsar/templates/bookkeeper-configmap.yaml
##########
@@ -22,7 +22,7 @@ apiVersion: v1
 kind: ConfigMap
 metadata:
   name: "{{ template "pulsar.fullname" . }}-{{ .Values.bookkeeper.component }}"
-  namespace: {{ .Values.namespace }}
+  namespace: {{ .Values.namespace | default .Release.Namespace }}

Review comment:
       sure, see updated commit




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org