[GitHub] [flink] steveloughran commented on a diff in pull request #21160: [FLINK-29761][runtime][security] Simplify HadoopModule

[GitBox <gi...@apache.org>]

steveloughran commented on code in PR #21160:
URL: https://github.com/apache/flink/pull/21160#discussion_r1005501511


##########
flink-runtime/src/main/java/org/apache/flink/runtime/security/modules/HadoopModule.java:
##########
@@ -69,71 +60,34 @@ public void install() throws SecurityInstallException {
         UserGroupInformation loginUser;
 
         try {
-            if (UserGroupInformation.isSecurityEnabled()
-                    && !StringUtils.isBlank(securityConfig.getKeytab())
-                    && !StringUtils.isBlank(securityConfig.getPrincipal())) {
-                String keytabPath = (new File(securityConfig.getKeytab())).getAbsolutePath();
-
-                UserGroupInformation.loginUserFromKeytab(securityConfig.getPrincipal(), keytabPath);

Review Comment:
   yes, plus sets up a renewer thread to do relogin on a regular basis.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org