You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "William A. Rowe, Jr." <wr...@rowe-clan.net> on 2008/06/17 23:43:14 UTC
[VOTE] initial release of httpd-mod_ftp-0.9.0
mod_ftp fans;
We seem to have identified and solved most post 0.9.1 candidate issues,
so it's time for another try.
Please fetch up the newly prepared httpd-mod_ftp-0.9.2.tar.gz (available
now), or the win32/netware/os2 suitable package httpd-mod_ftp-0.9.2-crlf.zip
(still needs to sync in the next hour) from:
http://httpd.apache.org/dev/dist/mod_ftp/
review, take it for a spin, and cast your choice
[ ] -1 for any release of 0.9.2
[ ] +1 to release as 0.9.2-alpha
[ ] +1 to release as 0.9.2-beta
[ ] +1 to release as 0.9.2-beta, and ready to tag GA (1.0.0)
See http://svn.apache.org/repos/asf/httpd/mod_ftp/tags/0.9.2/STATUS-FTP
identifying several issues (I don't plan to vote for better than -beta
just yet). Supporting -beta means +1 to -alpha instead if that's the
majority opinion.
For getting started,
http://httpd.apache.org/mod_ftp/
and
http://svn.apache.org/repos/asf/httpd/mod_ftp/tags/0.9.2/README-FTP
Bill
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
Posted by Jorge Schrauwen <jo...@gmail.com>.
Oops hit ctrl+s :/
...
I haven't given the latest source a spin (due to time problems with exams).
Last one I played with seemed to work reasonably well as a single server.
named vhost was broken though (wrowe: how is that coming along? can I give
that another run for its money later this week?)
If around the same state as when I was messing with it I'd say +1 for
beta... it was usable at least as single server. (was using it with FlashFXP
to mess around with it)
I'm not sure how it will cope with heavy usage though.
~Jorge
On Wed, Jun 18, 2008 at 10:23 AM, Jorge Schrauwen <jo...@gmail.com>
wrote:
> I haven't given the latest source a spin (due to time problems with exams).
> Last one I played with seemed to work reasonably well as a single server.
>
> named vhost was broken though (wrowe: how is that coming along? can I give
> that another run for its money later this week?)
>
> If around the same state as when I was messing with it I'd say +1 for
> beta... it was usable atleast as
>
> ~Jorge
>
> On Tue, Jun 17, 2008 at 11:43 PM, William A. Rowe, Jr. <
> wrowe@rowe-clan.net> wrote:
>
>> mod_ftp fans;
>>
>> We seem to have identified and solved most post 0.9.1 candidate issues,
>> so it's time for another try.
>>
>> Please fetch up the newly prepared httpd-mod_ftp-0.9.2.tar.gz (available
>> now), or the win32/netware/os2 suitable package
>> httpd-mod_ftp-0.9.2-crlf.zip (still needs to sync in the next hour) from:
>>
>> http://httpd.apache.org/dev/dist/mod_ftp/
>>
>> review, take it for a spin, and cast your choice
>>
>> [ ] -1 for any release of 0.9.2
>> [ ] +1 to release as 0.9.2-alpha
>> [ ] +1 to release as 0.9.2-beta
>> [ ] +1 to release as 0.9.2-beta, and ready to tag GA (1.0.0)
>>
>> See http://svn.apache.org/repos/asf/httpd/mod_ftp/tags/0.9.2/STATUS-FTP
>> identifying several issues (I don't plan to vote for better than -beta
>> just yet). Supporting -beta means +1 to -alpha instead if that's the
>> majority opinion.
>>
>> For getting started,
>>
>> http://httpd.apache.org/mod_ftp/
>>
>> and
>>
>> http://svn.apache.org/repos/asf/httpd/mod_ftp/tags/0.9.2/README-FTP
>>
>> Bill
>>
>>
>>
>>
>>
>
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
Posted by Jorge Schrauwen <jo...@gmail.com>.
I haven't given the latest source a spin (due to time problems with exams).
Last one I played with seemed to work reasonably well as a single server.
named vhost was broken though (wrowe: how is that coming along? can I give
that another run for its money later this week?)
If around the same state as when I was messing with it I'd say +1 for
beta... it was usable atleast as
~Jorge
On Tue, Jun 17, 2008 at 11:43 PM, William A. Rowe, Jr. <wr...@rowe-clan.net>
wrote:
> mod_ftp fans;
>
> We seem to have identified and solved most post 0.9.1 candidate issues,
> so it's time for another try.
>
> Please fetch up the newly prepared httpd-mod_ftp-0.9.2.tar.gz (available
> now), or the win32/netware/os2 suitable package
> httpd-mod_ftp-0.9.2-crlf.zip (still needs to sync in the next hour) from:
>
> http://httpd.apache.org/dev/dist/mod_ftp/
>
> review, take it for a spin, and cast your choice
>
> [ ] -1 for any release of 0.9.2
> [ ] +1 to release as 0.9.2-alpha
> [ ] +1 to release as 0.9.2-beta
> [ ] +1 to release as 0.9.2-beta, and ready to tag GA (1.0.0)
>
> See http://svn.apache.org/repos/asf/httpd/mod_ftp/tags/0.9.2/STATUS-FTP
> identifying several issues (I don't plan to vote for better than -beta
> just yet). Supporting -beta means +1 to -alpha instead if that's the
> majority opinion.
>
> For getting started,
>
> http://httpd.apache.org/mod_ftp/
>
> and
>
> http://svn.apache.org/repos/asf/httpd/mod_ftp/tags/0.9.2/README-FTP
>
> Bill
>
>
>
>
>
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Jim Jagielski wrote:
> +1 for beta....
That's three; and as promised I'll promote my vote from alpha to beta.
At 2200 GMT I'll collect any final votes and promote to released.
Bill
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
Posted by Jim Jagielski <ji...@jaguNET.com>.
+1 for beta....
On Jun 26, 2008, at 10:28 PM, William A. Rowe, Jr. wrote:
> Sander Temme wrote:
>>> [X] +1 to release as 0.9.2-beta, and ready to tag GA (1.0.0)
>> Compiles cleanly (no emits) on httpd 2.2.9 w/ APR and APU 1.3.x
>> r671971 built w/ libtool 1.5.26.
>> Module loads, config loads with all defaults, I can connect and be
>> denied login access, which seems a comfortable level of default
>> lockdown.
>
> Good to hear, and thanks for testing. Unfortunately that's 2
> binding +1's
> with a little over 18 hours left in the vote. I'll probably swing
> my vote
> to beta if a third beta vote came in beta. My main reason for
> choosing
> -alpha was the revert of the old ABOR handling that Jim had wedged
> into the
> cmd table (BOR, ABO etc with some binary nuggets that broke HELP).
>
> So many client authors were clueless about telnet and out of band data
> that I think some users would be frustrated by the broken ^C behavior,
> we could probably get more coherent reports if it was -alpha. But I'm
> happy either way.
>
> Thanks too to Jorge and Takashi for their review.
>
>> I'd be +1 on seeing this out there, but would fix Takashi San's
>> observations before GA.
>
> Agreed, I'd actually want to address them all before 0.9.3-whatever,
> but it's certainly not broad enough to hold up at least something
> as beta or alpha. He was correct that it's not GA until those are
> fixed.
>
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Sander Temme wrote:
>
>> [X] +1 to release as 0.9.2-beta, and ready to tag GA (1.0.0)
>
> Compiles cleanly (no emits) on httpd 2.2.9 w/ APR and APU 1.3.x r671971
> built w/ libtool 1.5.26.
>
> Module loads, config loads with all defaults, I can connect and be
> denied login access, which seems a comfortable level of default lockdown.
Good to hear, and thanks for testing. Unfortunately that's 2 binding +1's
with a little over 18 hours left in the vote. I'll probably swing my vote
to beta if a third beta vote came in beta. My main reason for choosing
-alpha was the revert of the old ABOR handling that Jim had wedged into the
cmd table (BOR, ABO etc with some binary nuggets that broke HELP).
So many client authors were clueless about telnet and out of band data
that I think some users would be frustrated by the broken ^C behavior,
we could probably get more coherent reports if it was -alpha. But I'm
happy either way.
Thanks too to Jorge and Takashi for their review.
> I'd be +1 on seeing this out there, but would fix Takashi San's
> observations before GA.
Agreed, I'd actually want to address them all before 0.9.3-whatever,
but it's certainly not broad enough to hold up at least something
as beta or alpha. He was correct that it's not GA until those are
fixed.
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
Posted by Sander Temme <sc...@apache.org>.
On Jun 26, 2008, at 11:47 AM, Sander Temme wrote:
>> [X] +1 to release as 0.9.2-beta, and ready to tag GA (1.0.0)
>
> Compiles cleanly (no emits) on httpd 2.2.9 w/ APR and APU 1.3.x
> r671971 built w/ libtool 1.5.26.
Oh:
Darwin Legadema.local 9.3.0 Darwin Kernel Version 9.3.0: Fri May 23
00:49:16 PDT 2008; root:xnu-1228.5.18~1/RELEASE_I386 i386
S.
--
Sander Temme
sctemme@apache.org
PGP FP: 51B4 8727 466A 0BC3 69F4 B7B8 B2BE BC40 1529 24AF
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
Posted by Sander Temme <sc...@apache.org>.
On Jun 17, 2008, at 2:43 PM, William A. Rowe, Jr. wrote:
> review, take it for a spin, and cast your choice
>
> [ ] -1 for any release of 0.9.2
> [ ] +1 to release as 0.9.2-alpha
> [ ] +1 to release as 0.9.2-beta
> [X] +1 to release as 0.9.2-beta, and ready to tag GA (1.0.0)
Compiles cleanly (no emits) on httpd 2.2.9 w/ APR and APU 1.3.x
r671971 built w/ libtool 1.5.26.
Module loads, config loads with all defaults, I can connect and be
denied login access, which seems a comfortable level of default
lockdown.
I'd be +1 on seeing this out there, but would fix Takashi San's
observations before GA.
S.
--
Sander Temme
sctemme@apache.org
PGP FP: 51B4 8727 466A 0BC3 69F4 B7B8 B2BE BC40 1529 24AF
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
Posted by Jorge Schrauwen <jo...@gmail.com>.
Compiles fine and is working as before on gentoo...
named vhosting still broken though
[ X ] +1 to release as 0.9.2-beta
~Jorge
On Sat, Jun 21, 2008 at 9:17 AM, Takashi Sato <ta...@lans-tv.com> wrote:
> On Tue, 17 Jun 2008 16:43:14 -0500
> "William A. Rowe, Jr." <wr...@rowe-clan.net> wrote:
>
> > [ ] -1 for any release of 0.9.2
> > [ ] +1 to release as 0.9.2-alpha
> > [ ] +1 to release as 0.9.2-beta
> > [ ] +1 to release as 0.9.2-beta, and ready to tag GA (1.0.0)
>
> -0
>
> ftp_commands.c: In function 'ftp_cmd_pbsz':
> ftp_commands.c:1706: warning: comparison is always false due to limited
> range of data type
>
> If 'arg' is "2147483647"
> on the sizeof(int) == 4 == sizeof(long) system,
> fc->pbsz == LONG_MAX.
> But on the sizeof(int) == 4 < sizeof(long) system,
> fc->pbsz != LONG_MAX.
>
> I have not read the code deeply, but I think this is not quite dangerous.
> There is no code using pbsz.
> I have found other assignments of resutl of strtol to int.
>
> mod_ftp.c line 406
> *(int *) ((char *) fsc + offset) = strtol(arg, &endptr, 10);
> line 436
> umask = strtol(arg, &endp, 8);
> line 459
> umask = strtol(arg, &endp, 8);
>
> My environment:
> FreeBSD 7-STABLE AMD64
> gcc version 4.2.1 20070719 [FreeBSD]
>
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0^H2
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Takashi Sato wrote:
>
> ftp_commands.c: In function 'ftp_cmd_pbsz':
> ftp_commands.c:1706: warning: comparison is always false due to limited range of data type
>
> If 'arg' is "2147483647"
> on the sizeof(int) == 4 == sizeof(long) system,
> fc->pbsz == LONG_MAX.
> But on the sizeof(int) == 4 < sizeof(long) system,
> fc->pbsz != LONG_MAX.
>
> I have not read the code deeply, but I think this is not quite dangerous.
> There is no code using pbsz.
> I have found other assignments of resutl of strtol to int.
>
> mod_ftp.c line 406
> *(int *) ((char *) fsc + offset) = strtol(arg, &endptr, 10);
> line 436
> umask = strtol(arg, &endp, 8);
> line 459
> umask = strtol(arg, &endp, 8);
>
> My environment:
> FreeBSD 7-STABLE AMD64
> gcc version 4.2.1 20070719 [FreeBSD]
All good bugs to fix, thanks Takashi. None look like showstoppers to an
alpha quality release though ;-)
Bill
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
Posted by Takashi Sato <ta...@lans-tv.com>.
On Tue, 17 Jun 2008 16:43:14 -0500
"William A. Rowe, Jr." <wr...@rowe-clan.net> wrote:
> [ ] -1 for any release of 0.9.2
> [ ] +1 to release as 0.9.2-alpha
> [ ] +1 to release as 0.9.2-beta
> [ ] +1 to release as 0.9.2-beta, and ready to tag GA (1.0.0)
-0
ftp_commands.c: In function 'ftp_cmd_pbsz':
ftp_commands.c:1706: warning: comparison is always false due to limited range of data type
If 'arg' is "2147483647"
on the sizeof(int) == 4 == sizeof(long) system,
fc->pbsz == LONG_MAX.
But on the sizeof(int) == 4 < sizeof(long) system,
fc->pbsz != LONG_MAX.
I have not read the code deeply, but I think this is not quite dangerous.
There is no code using pbsz.
I have found other assignments of resutl of strtol to int.
mod_ftp.c line 406
*(int *) ((char *) fsc + offset) = strtol(arg, &endptr, 10);
line 436
umask = strtol(arg, &endp, 8);
line 459
umask = strtol(arg, &endp, 8);
My environment:
FreeBSD 7-STABLE AMD64
gcc version 4.2.1 20070719 [FreeBSD]
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
William A. Rowe, Jr. wrote:
> review, take it for a spin, and cast your choice
>
> [X] +1 to release as 0.9.2-alpha
My vote, of course. Going to declare this vote done tomorrow night and
rm the candidates if it fails.
Caught up with Jorge, his vhost confusion stemmed from old docs (long ago
updated on the site and in trunk/). He's reported success (interestingly
with ServerName but not ServerAlias, I suspect misconfig but will review.)
Bill
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
William A. Rowe, Jr. wrote:
> Please fetch up the newly prepared httpd-mod_ftp-0.9.2.tar.gz (available
> now), or the win32/netware/os2 suitable package
> httpd-mod_ftp-0.9.2-crlf.zip (still needs to sync in the next hour) from:
>
> http://httpd.apache.org/dev/dist/mod_ftp/
>
> review, take it for a spin, and cast your choice
Gonna let this vote spin a good 10 days to give people a chance to try this
out and review, there's no rush. So we'll call it on the 27th, a week from
today.
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
William A. Rowe, Jr. wrote:
> Please fetch up the newly prepared httpd-mod_ftp-0.9.2.tar.gz (available
> now), or the win32/netware/os2 suitable package
> httpd-mod_ftp-0.9.2-crlf.zip (still needs to sync in the next hour) from:
>
> http://httpd.apache.org/dev/dist/mod_ftp/
>
> review, take it for a spin, and cast your choice
Gonna let this vote spin a good 10 days to give people a chance to try this
out and review, there's no rush. So we'll call it on the 27th, a week from
today.
---------------------------------------------------------------------
To unsubscribe, e-mail: testers-unsubscribe@httpd.apache.org
For additional commands, e-mail: testers-help@httpd.apache.org
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
William A. Rowe, Jr. wrote:
> review, take it for a spin, and cast your choice
>
> [X] +1 to release as 0.9.2-alpha
My vote, of course. Going to declare this vote done tomorrow night and
rm the candidates if it fails.
Caught up with Jorge, his vhost confusion stemmed from old docs (long ago
updated on the site and in trunk/). He's reported success (interestingly
with ServerName but not ServerAlias, I suspect misconfig but will review.)
Bill
---------------------------------------------------------------------
To unsubscribe, e-mail: testers-unsubscribe@httpd.apache.org
For additional commands, e-mail: testers-help@httpd.apache.org