[jira] Commented: (AMQ-2813) BrokerService @PostConstruct invalidates XBeanBrokerService w/ start=false

["Dan Nawrocki (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/activemq/browse/AMQ-2813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61597#action_61597 ] 

Dan Nawrocki commented on AMQ-2813:
-----------------------------------

I can confirm that removing the @PostConstruct annotation work w/ 5.4.0 as well.

I should also mention that the reason I am having so much trouble with this is because I am running my webapp under JBoss.  When JBoss attempts to deploy my EAR file, the "main" thread ends up calling BrokerService#start.  Because the "main" thread is not blocked indefinitely, JBoss is left in an inconsistent state and will never serve ANY http requests, and will not respond to a kill command.  I have to kill -9 the java process to get it to terminate.

> BrokerService @PostConstruct invalidates XBeanBrokerService w/ start=false
> --------------------------------------------------------------------------
>
>                 Key: AMQ-2813
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2813
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.3.1
>            Reporter: Dan Nawrocki
>            Assignee: Dejan Bosanac
>            Priority: Minor
>             Fix For: 5.4.0
>
>
> - XBeanBrokerService#afterPropertiesSet() method checks the start flag and is annotated as @PostConstruct so it's called at startup
> - BrokerService#start() method has the @PostConstruct annotation as well
> - There is no way for the BrokerService class to check the 'start' flag in the XBeanBrokerService subclass.
> - Spring will call BOTH @PostConstruct methods resulting in the broker being started regardless of the xbean start flag
> According to Gary Tully:
> That looks like a bug that was introduced in
> http://svn.apache.org/viewvc?rev=908182&view=rev the postConstruct on
> the start method does invalidate the
> XBeanBrokerService#afterPropertiesSet()  smarts. 
> As discussed in:
> http://old.nabble.com/XBean-%27start%3Dfalse%27-not-working--td29086727.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.