[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4068: [CARBONDATA-3987] Handled filter and IUD operation for pagination reader in SDK

[GitBox <gi...@apache.org>]

ajantha-bhat commented on a change in pull request #4068:
URL: https://github.com/apache/carbondata/pull/4068#discussion_r551238408



##########
File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java
##########
@@ -427,6 +436,50 @@ private CarbonFileInputFormat prepareFileInputFormat(Job job, boolean enableBloc
     }
   }
 
+  private <T> void totalRowCountInSplits(Job job, List<InputSplit> splits,
+      List<Long> rowCountInSplit) throws IOException, InterruptedException {
+    long sum = 0;
+    boolean isIUDTable = false;
+    // Check if update or delete happened on the table.
+    if (!StringUtils.isEmpty(this.tablePath)) {
+      CarbonFile[] fileList = FileFactory.getCarbonFile(this.tablePath,
+          this.hadoopConf).listFiles();
+      for (CarbonFile file : fileList) {

Review comment:
       If you have too many files in table path, checking each file is delta file or not will take time, 
   please manually check SDK update testcase and see if we write any metadata (like table status or update status) to know update has happened or not.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org