You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by florianschmidt1994 <gi...@git.apache.org> on 2018/03/19 12:37:04 UTC
[GitHub] flink pull request #5717: [FLINK-9020][E2E Tests] Use separate modules per t...
GitHub user florianschmidt1994 opened a pull request:
https://github.com/apache/flink/pull/5717
[FLINK-9020][E2E Tests] Use separate modules per testcase
## Use separate maven modules per test case in end-to-end tests
This change sets up the end-to-end project dir in a way that each test that provides its own sources does so with a separate module.
The main motivation is that now each test case can easier specify the way that it is supposed to be built, which could often for example be based on the quickstart example. There then is no need anymore to put together custom packaging instructions for each addition that is added to the test cases.
## Brief change log
- Change parent artifact from jar to pom packaging
- Rename parent artifact from `flink-end-to-end-tests_${scala.binary.version}` to `flink-end-to-end-tests` (needed for having a successful build)
- Move existing ClassLoader PoC to its own module
- Fix paths in test scripts
## Verifying this change
* I reran the tests by hand and they still behave the same
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/florianschmidt1994/flink 9020-refactor-end-to-end-project-structure
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5717.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5717
----
commit d2ff3e1ff7ed00784a6fda1c6fbf82dcfdedeb07
Author: Florian Schmidt <fl...@...>
Date: 2018-03-19T12:26:14Z
[FLINK-9020][E2ETests] Use separate modules per testcase
----
---
[GitHub] flink issue #5717: [FLINK-9020][E2E Tests] Use separate modules per testcase
Posted by florianschmidt1994 <gi...@git.apache.org>.
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/5717
@kl0u Could you have a look at this?
---
[GitHub] flink issue #5717: [FLINK-9020][E2E Tests] Use separate modules per testcase
Posted by florianschmidt1994 <gi...@git.apache.org>.
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/5717
Thanks @zentol! I addressed your comments and will squash if approved
---
[GitHub] flink pull request #5717: [FLINK-9020][E2E Tests] Use separate modules per t...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5717#discussion_r176032646
--- Diff: flink-end-to-end-tests/parent-child-classloading-test/pom.xml ---
@@ -0,0 +1,107 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ -->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+
+ <parent>
+ <artifactId>flink-end-to-end-tests</artifactId>
+ <groupId>org.apache.flink</groupId>
+ <version>1.6-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>parent-child-classloading-test</artifactId>
--- End diff --
* add `flink` prefix
* add `_${scala.binary.version}` suffix
* add `<name>flink-parent-child-classloading-test</name>` (this is what allows us to omit the scala stuff when listing child modules)
---
[GitHub] flink pull request #5717: [FLINK-9020][E2E Tests] Use separate modules per t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5717
---
[GitHub] flink issue #5717: [FLINK-9020][E2E Tests] Use separate modules per testcase
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5717
merging.
---