You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/23 05:31:25 UTC

[GitHub] [flink] JingsongLi opened a new pull request #19209: [FLINK-26805][table] Managed table breaks legacy connector without 'connector.type'

JingsongLi opened a new pull request #19209:
URL: https://github.com/apache/flink/pull/19209


   ## What is the purpose of the change
   
   Fix the bug, Managed table breaks:
   ```
   CREATE TABLE T (a INT) WITH ('type'='legacy');
   INSERT INTO T VALUES (1); 
   ```
   This case can be misinterpreted as a managed table, which the user might expect to be resolved by the legacy table factory.
   
   ## Brief change log
   
   - Move `isLegacyConnectorOptions` to `TableFactoryUtil`.
   - `ManagedTableListener.isManagedTable` should exclude legacy connector.
   
   ## Verifying this change
   
   - `LegacyTableFactoryTest`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19209: [FLINK-26805][table] Managed table breaks legacy connector without 'connector.type'

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19209:
URL: https://github.com/apache/flink/pull/19209#issuecomment-1075935081


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fc5332a07f7e94ce4295b2480ae2745c85614a03",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33634",
       "triggerID" : "fc5332a07f7e94ce4295b2480ae2745c85614a03",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fc5332a07f7e94ce4295b2480ae2745c85614a03",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33634",
       "triggerID" : "1076325604",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * fc5332a07f7e94ce4295b2480ae2745c85614a03 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33634) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19209: [FLINK-26805][table] Managed table breaks legacy connector without 'connector.type'

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19209:
URL: https://github.com/apache/flink/pull/19209#issuecomment-1075935081


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fc5332a07f7e94ce4295b2480ae2745c85614a03",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33634",
       "triggerID" : "fc5332a07f7e94ce4295b2480ae2745c85614a03",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fc5332a07f7e94ce4295b2480ae2745c85614a03 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33634) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19209: [FLINK-26805][table] Managed table breaks legacy connector without 'connector.type'

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19209:
URL: https://github.com/apache/flink/pull/19209#issuecomment-1075935081


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fc5332a07f7e94ce4295b2480ae2745c85614a03",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fc5332a07f7e94ce4295b2480ae2745c85614a03",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fc5332a07f7e94ce4295b2480ae2745c85614a03 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19209: [FLINK-26805][table] Managed table breaks legacy connector without 'connector.type'

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19209:
URL: https://github.com/apache/flink/pull/19209#issuecomment-1075935081


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fc5332a07f7e94ce4295b2480ae2745c85614a03",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33634",
       "triggerID" : "fc5332a07f7e94ce4295b2480ae2745c85614a03",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fc5332a07f7e94ce4295b2480ae2745c85614a03",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33634",
       "triggerID" : "1076325604",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * fc5332a07f7e94ce4295b2480ae2745c85614a03 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33634) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] JingsongLi commented on pull request #19209: [FLINK-26805][table] Managed table breaks legacy connector without 'connector.type'

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on pull request #19209:
URL: https://github.com/apache/flink/pull/19209#issuecomment-1076325604


   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19209: [FLINK-26805][table] Managed table breaks legacy connector without 'connector.type'

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19209:
URL: https://github.com/apache/flink/pull/19209#issuecomment-1075935081


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fc5332a07f7e94ce4295b2480ae2745c85614a03",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33634",
       "triggerID" : "fc5332a07f7e94ce4295b2480ae2745c85614a03",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fc5332a07f7e94ce4295b2480ae2745c85614a03",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33634",
       "triggerID" : "1076325604",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * fc5332a07f7e94ce4295b2480ae2745c85614a03 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33634) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19209: [FLINK-26805][table] Managed table breaks legacy connector without 'connector.type'

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19209:
URL: https://github.com/apache/flink/pull/19209#issuecomment-1075935081


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fc5332a07f7e94ce4295b2480ae2745c85614a03",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33634",
       "triggerID" : "fc5332a07f7e94ce4295b2480ae2745c85614a03",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fc5332a07f7e94ce4295b2480ae2745c85614a03 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33634) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] JingsongLi merged pull request #19209: [FLINK-26805][table] Managed table breaks legacy connector without 'connector.type'

Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #19209:
URL: https://github.com/apache/flink/pull/19209


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org