You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "PurelyApplied (GitHub)" <gi...@apache.org> on 2018/11/08 19:57:04 UTC
[GitHub] [geode] PurelyApplied opened pull request #2814: GEODE-6019:
Move gradle constants in constants files.
* gradle.startParameter.continueOnFailure moved to settings.gradle
* Project properties group and scriptDir moved to gradle.properties
* Removed unnecessary import and semicolons in *.gradle
* Improved property and task comments
-----
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [Build is Build] Have you written or updated unit tests to verify your changes?
- [n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/2814 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] rhoughton-pivot closed pull request #2814:
GEODE-6019: Move gradle constants in constants files.
Posted by "rhoughton-pivot (GitHub)" <gi...@apache.org>.
[ pull request closed by rhoughton-pivot ]
[ Full content available at: https://github.com/apache/geode/pull/2814 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] rhoughton-pivot commented on pull request #2814:
GEODE-6019: Move gradle constants in constants files.
Posted by "rhoughton-pivot (GitHub)" <gi...@apache.org>.
This import is required to be Gradle5.0 compatible. Please restore it
[ Full content available at: https://github.com/apache/geode/pull/2814 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on pull request #2814:
GEODE-6019: Move gradle constants in constants files.
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
Done and done!
[ Full content available at: https://github.com/apache/geode/pull/2814 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] rhoughton-pivot commented on pull request #2814:
GEODE-6019: Move gradle constants in constants files.
Posted by "rhoughton-pivot (GitHub)" <gi...@apache.org>.
This import is needed for Gradle 5.0 compatibility. Please restore it.
[ Full content available at: https://github.com/apache/geode/pull/2814 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org