You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by trixpan <gi...@git.apache.org> on 2017/07/16 08:02:59 UTC
[GitHub] nifi pull request #2013: NIFI-4098 - Adjust ParseCEF to re-use bean validato...
GitHub user trixpan opened a pull request:
https://github.com/apache/nifi/pull/2013
NIFI-4098 - Adjust ParseCEF to re-use bean validator in order to impr…
…ove performance
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [X] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [X] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trixpan/nifi NIFI-4098
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2013.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2013
----
commit 39236a9cd73b3164d73cfa2ce25c897a756dc966
Author: Andre F de Miranda <tr...@users.noreply.github.com>
Date: 2017-06-21T05:08:08Z
NIFI-4098 - Adjust ParseCEF to re-use bean validator in order to improve performance
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #2013: NIFI-4098 - Adjust ParseCEF to re-use bean validato...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2013#discussion_r128133516
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-nar/src/main/resources/META-INF/NOTICE ---
@@ -26,6 +26,20 @@ Apache Software License v2
The following binary components are provided under the Apache Software License v2
+ (ASLv2) Apache BVal Project
+ The following NOTICE information applies:
+ Apache BVal project
+ Copyright 2010-2016 The Apache Software Foundation.
+
+ This product includes software developed by
--- End diff --
please remove lines 34-38.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #2013: NIFI-4098 - Adjust ParseCEF to re-use bean validato...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2013#discussion_r128133492
--- Diff: nifi-assembly/NOTICE ---
@@ -44,6 +44,20 @@ Apache Software License v2
The following binary components are provided under the Apache Software License v2
+ (ASLv2) Apache BVal Project
+ The following NOTICE information applies:
+ Apache BVal project
+ Copyright 2010-2016 The Apache Software Foundation.
+
+ This product includes software developed by
--- End diff --
please remove lines 52-56.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #2013: NIFI-4098 - Adjust ParseCEF to re-use bean validato...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2013
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2013: NIFI-4098 - Adjust ParseCEF to re-use bean validator in or...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2013
From a coding point of view, it LGTM. On the L&N side, I'd appreciate another pair of eyes to be sure we're good to go. @joewitt ?
Also, @trixpan, I think the updated dependency is now available in Maven central, could you force another Travis build?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2013: NIFI-4098 - Adjust ParseCEF to re-use bean validator in or...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2013
have verified L&N. Fixed an unrelated L&N finding and cleaned up the things i left comments on. Checked all dependencies and they're covered too. Good job. +1 merging to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---