You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by GitBox <gi...@apache.org> on 2020/03/14 02:36:15 UTC
[GitHub] [incubator-weex] YorkShen opened a new pull request #3167:
Feature(Android): Support x86_64
YorkShen opened a new pull request #3167: Feature(Android): Support x86_64
URL: https://github.com/apache/incubator-weex/pull/3167
Please note:
**X86_64** is supported only if the JS interpretator supports **X86_64**, which means:
* Weex with `libjsc.so` is supported on X86_64
* Weex with `JavaScriptCore.so` is **not** supported on X86_64
And JavaScriptCore.so is no longer provided after Weex 0.28
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-weex] YorkShen edited a comment on issue #3167:
Feature(Android): Support x86_64
Posted by GitBox <gi...@apache.org>.
YorkShen edited a comment on issue #3167: Feature(Android): Support x86_64
URL: https://github.com/apache/incubator-weex/pull/3167#issuecomment-599014559
@cnryb I could fix it by removing maven mirrors of Alibaba Cloud, which would however cause a problem to our users in China.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-weex] cnryb commented on a change in pull request #3167:
Feature(Android): Support x86_64
Posted by GitBox <gi...@apache.org>.
cnryb commented on a change in pull request #3167: Feature(Android): Support x86_64
URL: https://github.com/apache/incubator-weex/pull/3167#discussion_r392575544
##########
File path: .travis.yml
##########
@@ -141,9 +152,11 @@ script:
if npm run danger -- ci --dangerfile ./dangerfile-android.js | grep -q "hasAndroidFile" ; then
cd android
./gradlew clean assembleRelease --quiet -PbuildRuntimeApi=true ${GRADLE_ABI} -PapachePackageName="false" || exit 1
- ./gradlew assembleRelease --quiet ${GRADLE_ABI} -PbuildRuntimeApi=false -Pjsc_url="https://raw.githubusercontent.com/apache/incubator-weex/release/0.26/android/sdk/weex_sdk-0.26.0.aar" -Paar_name="weex_sdk" -PJSInterpolatorName="JavaScriptCore" -PapachePackageName="false" || exit 1
./gradlew :weex_sdk:assembleRelease --quiet -PbuildRuntimeApi=true ${GRADLE_ABI} -PapachePackageName="true" || exit 1
- ./gradlew :weex_sdk:assembleRelease --quiet ${GRADLE_ABI} -PbuildRuntimeApi=false -Pjsc_url="https://raw.githubusercontent.com/apache/incubator-weex/release/0.26/android/sdk/weex_sdk-0.26.0.aar" -Paar_name="weex_sdk" -PJSInterpolatorName="JavaScriptCore" -PapachePackageName="true" || exit 1
+ if [[ "$ABI" != "x86_64" ]]; then
+ ./gradlew assembleRelease --quiet ${GRADLE_ABI} -PbuildRuntimeApi=false -Pjsc_url="https://raw.githubusercontent.com/apache/incubator-weex/release/0.26/android/sdk/weex_sdk-0.26.0.aar" -Paar_name="weex_sdk" -PJSInterpolatorName="JavaScriptCore" -PapachePackageName="false" || exit 1
Review comment:
Is Pjsc_url still useful?
Didn't understand why the weex_sdk v0.26 aar is used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-weex] weex-bot edited a comment on issue #3167:
Feature(Android): Support x86_64
Posted by GitBox <gi...@apache.org>.
weex-bot edited a comment on issue #3167: Feature(Android): Support x86_64
URL: https://github.com/apache/incubator-weex/pull/3167#issuecomment-599000238
<!--
0 failure:
3 warning: No Changelog chan..., Current pr not bi..., If your PR is abo...
DangerID: danger-id-danger;
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes! - <i>Can you add a Changelog? To do so,append your changes to the changelog.md</i></td>
</tr>
<tr>
<td>:warning:</td>
<td>Current pr not bind the milestone</td>
</tr>
<tr>
<td>:warning:</td>
<td>If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: <a href='http://dotwe.org/vue'>http://dotwe.org/vue</a></td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="https://danger.systems/js">dangerJS</a> against ecc58a4c45095fa819879cafe12175c1c52e8cb0
</p>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-weex] cnryb commented on a change in pull request #3167:
Feature(Android): Support x86_64
Posted by GitBox <gi...@apache.org>.
cnryb commented on a change in pull request #3167: Feature(Android): Support x86_64
URL: https://github.com/apache/incubator-weex/pull/3167#discussion_r392582567
##########
File path: .travis.yml
##########
@@ -141,9 +152,11 @@ script:
if npm run danger -- ci --dangerfile ./dangerfile-android.js | grep -q "hasAndroidFile" ; then
cd android
./gradlew clean assembleRelease --quiet -PbuildRuntimeApi=true ${GRADLE_ABI} -PapachePackageName="false" || exit 1
- ./gradlew assembleRelease --quiet ${GRADLE_ABI} -PbuildRuntimeApi=false -Pjsc_url="https://raw.githubusercontent.com/apache/incubator-weex/release/0.26/android/sdk/weex_sdk-0.26.0.aar" -Paar_name="weex_sdk" -PJSInterpolatorName="JavaScriptCore" -PapachePackageName="false" || exit 1
./gradlew :weex_sdk:assembleRelease --quiet -PbuildRuntimeApi=true ${GRADLE_ABI} -PapachePackageName="true" || exit 1
- ./gradlew :weex_sdk:assembleRelease --quiet ${GRADLE_ABI} -PbuildRuntimeApi=false -Pjsc_url="https://raw.githubusercontent.com/apache/incubator-weex/release/0.26/android/sdk/weex_sdk-0.26.0.aar" -Paar_name="weex_sdk" -PJSInterpolatorName="JavaScriptCore" -PapachePackageName="true" || exit 1
+ if [[ "$ABI" != "x86_64" ]]; then
+ ./gradlew assembleRelease --quiet ${GRADLE_ABI} -PbuildRuntimeApi=false -Pjsc_url="https://raw.githubusercontent.com/apache/incubator-weex/release/0.26/android/sdk/weex_sdk-0.26.0.aar" -Paar_name="weex_sdk" -PJSInterpolatorName="JavaScriptCore" -PapachePackageName="false" || exit 1
Review comment:
thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-weex] YorkShen commented on a change in pull request
#3167: Feature(Android): Support x86_64
Posted by GitBox <gi...@apache.org>.
YorkShen commented on a change in pull request #3167: Feature(Android): Support x86_64
URL: https://github.com/apache/incubator-weex/pull/3167#discussion_r392580465
##########
File path: .travis.yml
##########
@@ -141,9 +152,11 @@ script:
if npm run danger -- ci --dangerfile ./dangerfile-android.js | grep -q "hasAndroidFile" ; then
cd android
./gradlew clean assembleRelease --quiet -PbuildRuntimeApi=true ${GRADLE_ABI} -PapachePackageName="false" || exit 1
- ./gradlew assembleRelease --quiet ${GRADLE_ABI} -PbuildRuntimeApi=false -Pjsc_url="https://raw.githubusercontent.com/apache/incubator-weex/release/0.26/android/sdk/weex_sdk-0.26.0.aar" -Paar_name="weex_sdk" -PJSInterpolatorName="JavaScriptCore" -PapachePackageName="false" || exit 1
./gradlew :weex_sdk:assembleRelease --quiet -PbuildRuntimeApi=true ${GRADLE_ABI} -PapachePackageName="true" || exit 1
- ./gradlew :weex_sdk:assembleRelease --quiet ${GRADLE_ABI} -PbuildRuntimeApi=false -Pjsc_url="https://raw.githubusercontent.com/apache/incubator-weex/release/0.26/android/sdk/weex_sdk-0.26.0.aar" -Paar_name="weex_sdk" -PJSInterpolatorName="JavaScriptCore" -PapachePackageName="true" || exit 1
+ if [[ "$ABI" != "x86_64" ]]; then
+ ./gradlew assembleRelease --quiet ${GRADLE_ABI} -PbuildRuntimeApi=false -Pjsc_url="https://raw.githubusercontent.com/apache/incubator-weex/release/0.26/android/sdk/weex_sdk-0.26.0.aar" -Paar_name="weex_sdk" -PJSInterpolatorName="JavaScriptCore" -PapachePackageName="false" || exit 1
Review comment:
`JavaScriptCore.so` is still working now, but no body is maintaining it. As time goes and things happen(like it doesn't support x86_64), it will be abondoned eventually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-weex] weex-bot edited a comment on issue #3167:
Feature(Android): Support x86_64
Posted by GitBox <gi...@apache.org>.
weex-bot edited a comment on issue #3167: Feature(Android): Support x86_64
URL: https://github.com/apache/incubator-weex/pull/3167#issuecomment-599000238
<!--
0 failure:
3 warning: No Changelog chan..., Current pr not bi..., If your PR is abo...
DangerID: danger-id-danger;
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes! - <i>Can you add a Changelog? To do so,append your changes to the changelog.md</i></td>
</tr>
<tr>
<td>:warning:</td>
<td>Current pr not bind the milestone</td>
</tr>
<tr>
<td>:warning:</td>
<td>If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: <a href='http://dotwe.org/vue'>http://dotwe.org/vue</a></td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="https://danger.systems/js">dangerJS</a> against 56a407c7a4538c77eaa5201866132d3c08304fb6
</p>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-weex] YorkShen commented on issue #3167:
Feature(Android): Support x86_64
Posted by GitBox <gi...@apache.org>.
YorkShen commented on issue #3167: Feature(Android): Support x86_64
URL: https://github.com/apache/incubator-weex/pull/3167#issuecomment-599014559
@cnryb I fix it by removing maven mirrors of Alibaba Cloud, which would however cause a problem to our users in China.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-weex] YorkShen commented on a change in pull request
#3167: Feature(Android): Support x86_64
Posted by GitBox <gi...@apache.org>.
YorkShen commented on a change in pull request #3167: Feature(Android): Support x86_64
URL: https://github.com/apache/incubator-weex/pull/3167#discussion_r392579430
##########
File path: .travis.yml
##########
@@ -141,9 +152,11 @@ script:
if npm run danger -- ci --dangerfile ./dangerfile-android.js | grep -q "hasAndroidFile" ; then
cd android
./gradlew clean assembleRelease --quiet -PbuildRuntimeApi=true ${GRADLE_ABI} -PapachePackageName="false" || exit 1
- ./gradlew assembleRelease --quiet ${GRADLE_ABI} -PbuildRuntimeApi=false -Pjsc_url="https://raw.githubusercontent.com/apache/incubator-weex/release/0.26/android/sdk/weex_sdk-0.26.0.aar" -Paar_name="weex_sdk" -PJSInterpolatorName="JavaScriptCore" -PapachePackageName="false" || exit 1
./gradlew :weex_sdk:assembleRelease --quiet -PbuildRuntimeApi=true ${GRADLE_ABI} -PapachePackageName="true" || exit 1
- ./gradlew :weex_sdk:assembleRelease --quiet ${GRADLE_ABI} -PbuildRuntimeApi=false -Pjsc_url="https://raw.githubusercontent.com/apache/incubator-weex/release/0.26/android/sdk/weex_sdk-0.26.0.aar" -Paar_name="weex_sdk" -PJSInterpolatorName="JavaScriptCore" -PapachePackageName="true" || exit 1
+ if [[ "$ABI" != "x86_64" ]]; then
+ ./gradlew assembleRelease --quiet ${GRADLE_ABI} -PbuildRuntimeApi=false -Pjsc_url="https://raw.githubusercontent.com/apache/incubator-weex/release/0.26/android/sdk/weex_sdk-0.26.0.aar" -Paar_name="weex_sdk" -PJSInterpolatorName="JavaScriptCore" -PapachePackageName="false" || exit 1
Review comment:
As we delete `JavaScriptCore.so` from our code, and some developers still want it for some reasons.
So, with `Pjsc_url=0.26xxx`, weex will use `JavaScriptCore.so` as JS interpretator. This is a edge case in Travis CI, and never happened in a release code.
Developers have the freedom of choosing what JS interpretator they want, and I'd like our test case can cover some of their choice on JS interpretator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-weex] weex-bot commented on issue #3167:
Feature(Android): Support x86_64
Posted by GitBox <gi...@apache.org>.
weex-bot commented on issue #3167: Feature(Android): Support x86_64
URL: https://github.com/apache/incubator-weex/pull/3167#issuecomment-599000238
<!--
0 failure:
3 warning: No Changelog chan..., Current pr not bi..., If your PR is abo...
DangerID: danger-id-danger;
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes! - <i>Can you add a Changelog? To do so,append your changes to the changelog.md</i></td>
</tr>
<tr>
<td>:warning:</td>
<td>Current pr not bind the milestone</td>
</tr>
<tr>
<td>:warning:</td>
<td>If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: <a href='http://dotwe.org/vue'>http://dotwe.org/vue</a></td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="https://danger.systems/js">dangerJS</a> against c24d8cde0b68af24747046a1dfc75c49bdac3945
</p>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-weex] cnryb commented on issue #3167: Feature(Android):
Support x86_64
Posted by GitBox <gi...@apache.org>.
cnryb commented on issue #3167: Feature(Android): Support x86_64
URL: https://github.com/apache/incubator-weex/pull/3167#issuecomment-599008068
The Travis CI build is so slow, and it is easy to fail because of network problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-weex] YorkShen commented on a change in pull request
#3167: Feature(Android): Support x86_64
Posted by GitBox <gi...@apache.org>.
YorkShen commented on a change in pull request #3167: Feature(Android): Support x86_64
URL: https://github.com/apache/incubator-weex/pull/3167#discussion_r392579430
##########
File path: .travis.yml
##########
@@ -141,9 +152,11 @@ script:
if npm run danger -- ci --dangerfile ./dangerfile-android.js | grep -q "hasAndroidFile" ; then
cd android
./gradlew clean assembleRelease --quiet -PbuildRuntimeApi=true ${GRADLE_ABI} -PapachePackageName="false" || exit 1
- ./gradlew assembleRelease --quiet ${GRADLE_ABI} -PbuildRuntimeApi=false -Pjsc_url="https://raw.githubusercontent.com/apache/incubator-weex/release/0.26/android/sdk/weex_sdk-0.26.0.aar" -Paar_name="weex_sdk" -PJSInterpolatorName="JavaScriptCore" -PapachePackageName="false" || exit 1
./gradlew :weex_sdk:assembleRelease --quiet -PbuildRuntimeApi=true ${GRADLE_ABI} -PapachePackageName="true" || exit 1
- ./gradlew :weex_sdk:assembleRelease --quiet ${GRADLE_ABI} -PbuildRuntimeApi=false -Pjsc_url="https://raw.githubusercontent.com/apache/incubator-weex/release/0.26/android/sdk/weex_sdk-0.26.0.aar" -Paar_name="weex_sdk" -PJSInterpolatorName="JavaScriptCore" -PapachePackageName="true" || exit 1
+ if [[ "$ABI" != "x86_64" ]]; then
+ ./gradlew assembleRelease --quiet ${GRADLE_ABI} -PbuildRuntimeApi=false -Pjsc_url="https://raw.githubusercontent.com/apache/incubator-weex/release/0.26/android/sdk/weex_sdk-0.26.0.aar" -Paar_name="weex_sdk" -PJSInterpolatorName="JavaScriptCore" -PapachePackageName="false" || exit 1
Review comment:
Though we deleted `JavaScriptCore.so` from our code, some developers still want it for some reasons.
So, with `Pjsc_url=0.26xxx`, Apache Weex will import `JavaScriptCore.so` as a JS interpretator. This is a edge case in Travis CI, and never happened in a release code.
Developers have the freedom of choosing what JS interpretator they want, and I'd like our test case can cover some of their choice on JS interpretator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-weex] YorkShen commented on issue #3167:
Feature(Android): Support x86_64
Posted by GitBox <gi...@apache.org>.
YorkShen commented on issue #3167: Feature(Android): Support x86_64
URL: https://github.com/apache/incubator-weex/pull/3167#issuecomment-599019189
The failure of previous build is because that `JavaScriptCore.so` dont' support x86_64.
@cnryb Please review it again.
FYI: We still need to figure out how to sovle the network problem on CI server, however.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-weex] YorkShen commented on a change in pull request
#3167: Feature(Android): Support x86_64
Posted by GitBox <gi...@apache.org>.
YorkShen commented on a change in pull request #3167: Feature(Android): Support x86_64
URL: https://github.com/apache/incubator-weex/pull/3167#discussion_r392579430
##########
File path: .travis.yml
##########
@@ -141,9 +152,11 @@ script:
if npm run danger -- ci --dangerfile ./dangerfile-android.js | grep -q "hasAndroidFile" ; then
cd android
./gradlew clean assembleRelease --quiet -PbuildRuntimeApi=true ${GRADLE_ABI} -PapachePackageName="false" || exit 1
- ./gradlew assembleRelease --quiet ${GRADLE_ABI} -PbuildRuntimeApi=false -Pjsc_url="https://raw.githubusercontent.com/apache/incubator-weex/release/0.26/android/sdk/weex_sdk-0.26.0.aar" -Paar_name="weex_sdk" -PJSInterpolatorName="JavaScriptCore" -PapachePackageName="false" || exit 1
./gradlew :weex_sdk:assembleRelease --quiet -PbuildRuntimeApi=true ${GRADLE_ABI} -PapachePackageName="true" || exit 1
- ./gradlew :weex_sdk:assembleRelease --quiet ${GRADLE_ABI} -PbuildRuntimeApi=false -Pjsc_url="https://raw.githubusercontent.com/apache/incubator-weex/release/0.26/android/sdk/weex_sdk-0.26.0.aar" -Paar_name="weex_sdk" -PJSInterpolatorName="JavaScriptCore" -PapachePackageName="true" || exit 1
+ if [[ "$ABI" != "x86_64" ]]; then
+ ./gradlew assembleRelease --quiet ${GRADLE_ABI} -PbuildRuntimeApi=false -Pjsc_url="https://raw.githubusercontent.com/apache/incubator-weex/release/0.26/android/sdk/weex_sdk-0.26.0.aar" -Paar_name="weex_sdk" -PJSInterpolatorName="JavaScriptCore" -PapachePackageName="false" || exit 1
Review comment:
Though we deleted `JavaScriptCore.so` from our code, some developers still want it for some reasons.
So, with `Pjsc_url=0.26xxx`, Apache Weex will import `JavaScriptCore.so` as a JS interpretator. This is a edge case in Travis CI, and never happened in a release code.
Developers have the freedom of choosing whatever JS interpretator they want, and I'd like our test cases can cover some of their choice on JS interpretator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-weex] YorkShen merged pull request #3167:
Feature(Android): Support x86_64
Posted by GitBox <gi...@apache.org>.
YorkShen merged pull request #3167: Feature(Android): Support x86_64
URL: https://github.com/apache/incubator-weex/pull/3167
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-weex] YorkShen commented on a change in pull request
#3167: Feature(Android): Support x86_64
Posted by GitBox <gi...@apache.org>.
YorkShen commented on a change in pull request #3167: Feature(Android): Support x86_64
URL: https://github.com/apache/incubator-weex/pull/3167#discussion_r392579430
##########
File path: .travis.yml
##########
@@ -141,9 +152,11 @@ script:
if npm run danger -- ci --dangerfile ./dangerfile-android.js | grep -q "hasAndroidFile" ; then
cd android
./gradlew clean assembleRelease --quiet -PbuildRuntimeApi=true ${GRADLE_ABI} -PapachePackageName="false" || exit 1
- ./gradlew assembleRelease --quiet ${GRADLE_ABI} -PbuildRuntimeApi=false -Pjsc_url="https://raw.githubusercontent.com/apache/incubator-weex/release/0.26/android/sdk/weex_sdk-0.26.0.aar" -Paar_name="weex_sdk" -PJSInterpolatorName="JavaScriptCore" -PapachePackageName="false" || exit 1
./gradlew :weex_sdk:assembleRelease --quiet -PbuildRuntimeApi=true ${GRADLE_ABI} -PapachePackageName="true" || exit 1
- ./gradlew :weex_sdk:assembleRelease --quiet ${GRADLE_ABI} -PbuildRuntimeApi=false -Pjsc_url="https://raw.githubusercontent.com/apache/incubator-weex/release/0.26/android/sdk/weex_sdk-0.26.0.aar" -Paar_name="weex_sdk" -PJSInterpolatorName="JavaScriptCore" -PapachePackageName="true" || exit 1
+ if [[ "$ABI" != "x86_64" ]]; then
+ ./gradlew assembleRelease --quiet ${GRADLE_ABI} -PbuildRuntimeApi=false -Pjsc_url="https://raw.githubusercontent.com/apache/incubator-weex/release/0.26/android/sdk/weex_sdk-0.26.0.aar" -Paar_name="weex_sdk" -PJSInterpolatorName="JavaScriptCore" -PapachePackageName="false" || exit 1
Review comment:
Though we deleted `JavaScriptCore.so` from our code, some developers still want it for some reasons.
So, with `Pjsc_url=0.26xxx`, weex will use `JavaScriptCore.so` as JS interpretator. This is a edge case in Travis CI, and never happened in a release code.
Developers have the freedom of choosing what JS interpretator they want, and I'd like our test case can cover some of their choice on JS interpretator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services