You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/05 19:02:33 UTC

[GitHub] [incubator-nuttx] patacongo commented on pull request #5421: sched/wdog: fix adding one extra tick to any delay

patacongo commented on pull request #5421:
URL: https://github.com/apache/incubator-nuttx/pull/5421#issuecomment-1030681140


   This is an incorrect change and has has been rejected numerous times.  It is a consequence of faulty testing.  There is an good explanation of why this change is incorrect here:  https://cwiki.apache.org/confluence/display/NUTTX/Short+Time+Delays
   
   This has to be at least the 10th time this change has been suggested and rejected.  The most recent was just a couple of months ago.  I will try to find it for your.
   
   If this change were merged, it might improve timing in your faulty test case, but will introduce fatal timing errors in other cases.
   
   THIS MUST NOT BE MERGED!!!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org