[GitHub] [storm] bipinprasad commented on a change in pull request #3295: STORM-3660: Remove use of queues for updating credentials

[GitBox <gi...@apache.org>]

bipinprasad commented on a change in pull request #3295:
URL: https://github.com/apache/storm/pull/3295#discussion_r446255031



##########
File path: storm-client/src/jvm/org/apache/storm/executor/ExecutorShutdown.java
##########
@@ -60,16 +60,7 @@ public ExecutorStats renderStats() {
 
     @Override
     public void credentialsChanged(Credentials credentials) {
-        TupleImpl tuple = new TupleImpl(executor.getWorkerTopologyContext(), new Values(credentials),
-                                        Constants.SYSTEM_COMPONENT_ID, (int) Constants.SYSTEM_TASK_ID,
-                                        Constants.CREDENTIALS_CHANGED_STREAM_ID);
-        AddressedTuple addressedTuple = new AddressedTuple(AddressedTuple.BROADCAST_DEST, tuple);
-        try {
-            executor.getReceiveQueue().publish(addressedTuple);
-            executor.getReceiveQueue().flush();
-        } catch (InterruptedException e) {
-            throw new RuntimeException(e);
-        }
+        executor.needToRefreshCreds = true;

Review comment:
       Minor: Does this method name and signature needs to change since it is setting a flag and not using the supplied parameter?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org