You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by Mark <el...@gmail.com> on 2007/08/17 03:50:54 UTC
Re: [jira] Commented: (DIRMINA-376) Fine-grained logging control in LoggingFilter
Just getting around to looking at this again. I have checked in my latest
version of CopyOnWriteMap to org.apache.mina.util in the trunk. I have
tested the class using ConTest from IBM and all seems to go well. Let me
know what you think, and if all is well I can begin to incorporate the class
into parts of the trunk.
Thanks.
On 7/24/07, Trustin Lee (JIRA) <ji...@apache.org> wrote:
>
>
> [
> https://issues.apache.org/jira/browse/DIRMINA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515142]
>
> Trustin Lee commented on DIRMINA-376:
> -------------------------------------
>
> The implementation looks somewhat weird. It's modifying the map before
> creating a new copy. And if we are going to use a ConcurrentHashMap, we
> won't even need to make a copy of it. I found an existing implementation
> that might help you in Commons Collections:
>
>
> http://jakarta.apache.org/commons/collections/api-release/org/apache/commons/collections/FastHashMap.html
>
> Source code:
>
> http://www.krugle.com/kse/codespaces/EPwm08
>
> > Fine-grained logging control in LoggingFilter
> > ---------------------------------------------
> >
> > Key: DIRMINA-376
> > URL: https://issues.apache.org/jira/browse/DIRMINA-376
> > Project: MINA
> > Issue Type: New Feature
> > Components: Filter
> > Reporter: Trustin Lee
> > Assignee: Mark Webb
> > Priority: Minor
> > Fix For: 2.0.0-M1
> >
> >
> > LoggingFilter of MINA 1.0 has limited usability because there's no way
> to disable certain log messages. For example, you can't:
> > * disable logging for certain event type (e.g. exceptionCaught, which is
> often logged again in IoHandler.exceptionCaught()).
> > * log only certain type of received messages
> > Category filtering feature provided by logging frameworks will solve
> this problem somewhat, but it's very coarse-grained and won't work as
> expected because LoggingFilter gets the logger instance using the IoHandler
> implementation class and therefore affect logging messages in an IoHandler
> implementation.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
--
..Cheers
Mark
Re: [jira] Commented: (DIRMINA-376) Fine-grained logging control in LoggingFilter
Posted by Mark <el...@gmail.com>.
I was looking into whether or not I should clone, or just pass the existing
Map into the constructor of a new Map. Looking at the constructor and
clone(), I was torn between which is the preferred method. I guess now I
know :).
On 8/17/07, Trustin Lee <tr...@gmail.com> wrote:
>
> I made the necessary changes by myself; I had some free time. :)
>
> Please review the changes.
>
> Cheers,
> Trustin
>
> On 8/17/07, Trustin Lee <tr...@gmail.com> wrote:
> > On 8/17/07, Mark <el...@gmail.com> wrote:
> > > Just getting around to looking at this again. I have checked in my
> latest
> > > version of CopyOnWriteMap to org.apache.mina.util in the trunk. I
> have
> > > tested the class using ConTest from IBM and all seems to go well. Let
> me
> > > know what you think, and if all is well I can begin to incorporate the
> class
> > > into parts of the trunk.
> >
> > It looks very good. I made a few small changes, but nothing has been
> > changed essentially. Great work!
> >
> > Let's make logging filter to utilize it.
> >
> > Cheers,
> > Trustin
> > --
> > what we call human nature is actually human habit
> > --
> > http://gleamynode.net/
> > --
> > PGP Key ID: 0x0255ECA6
> >
>
>
> --
> what we call human nature is actually human habit
> --
> http://gleamynode.net/
> --
> PGP Key ID: 0x0255ECA6
>
--
..Cheers
Mark
Re: [jira] Commented: (DIRMINA-376) Fine-grained logging control in LoggingFilter
Posted by Trustin Lee <tr...@gmail.com>.
I made the necessary changes by myself; I had some free time. :)
Please review the changes.
Cheers,
Trustin
On 8/17/07, Trustin Lee <tr...@gmail.com> wrote:
> On 8/17/07, Mark <el...@gmail.com> wrote:
> > Just getting around to looking at this again. I have checked in my latest
> > version of CopyOnWriteMap to org.apache.mina.util in the trunk. I have
> > tested the class using ConTest from IBM and all seems to go well. Let me
> > know what you think, and if all is well I can begin to incorporate the class
> > into parts of the trunk.
>
> It looks very good. I made a few small changes, but nothing has been
> changed essentially. Great work!
>
> Let's make logging filter to utilize it.
>
> Cheers,
> Trustin
> --
> what we call human nature is actually human habit
> --
> http://gleamynode.net/
> --
> PGP Key ID: 0x0255ECA6
>
--
what we call human nature is actually human habit
--
http://gleamynode.net/
--
PGP Key ID: 0x0255ECA6
Re: [jira] Commented: (DIRMINA-376) Fine-grained logging control in LoggingFilter
Posted by Trustin Lee <tr...@gmail.com>.
On 8/17/07, Mark <el...@gmail.com> wrote:
> Just getting around to looking at this again. I have checked in my latest
> version of CopyOnWriteMap to org.apache.mina.util in the trunk. I have
> tested the class using ConTest from IBM and all seems to go well. Let me
> know what you think, and if all is well I can begin to incorporate the class
> into parts of the trunk.
It looks very good. I made a few small changes, but nothing has been
changed essentially. Great work!
Let's make logging filter to utilize it.
Cheers,
Trustin
--
what we call human nature is actually human habit
--
http://gleamynode.net/
--
PGP Key ID: 0x0255ECA6